Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1490228 > unrolled thread

[PATCH net-next 02/15] rxrpc: Don't send an ACK at the end of service call response transmission

Started byDavid Howells <dhowells@redhat.com>
First post2016-09-23 17:20 +0200
Last post2016-09-23 17:20 +0200
Articles 1 — 1 participant

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  [PATCH net-next 02/15] rxrpc: Don't send an ACK at the end of  service call response transmission David Howells <dhowells@redhat.com> - 2016-09-23 17:20 +0200

#1490228 — [PATCH net-next 02/15] rxrpc: Don't send an ACK at the end of service call response transmission

FromDavid Howells <dhowells@redhat.com>
Date2016-09-23 17:20 +0200
Subject[PATCH net-next 02/15] rxrpc: Don't send an ACK at the end of service call response transmission
Message-ID<skAqB-5wp-7@gated-at.bofh.it>
Don't send an IDLE ACK at the end of the transmission of the response to a
service call.  The service end resends DATA packets until the client sends an
ACK that hard-acks all the send data.  At that point, the call is complete.

Signed-off-by: David Howells <dhowells@redhat.com>
---

 net/rxrpc/recvmsg.c |    2 --
 1 file changed, 2 deletions(-)

diff --git a/net/rxrpc/recvmsg.c b/net/rxrpc/recvmsg.c
index 6ba4af5a8d95..99e4c0ae30f1 100644
--- a/net/rxrpc/recvmsg.c
+++ b/net/rxrpc/recvmsg.c
@@ -143,8 +143,6 @@ static void rxrpc_end_rx_phase(struct rxrpc_call *call)
 	if (call->state == RXRPC_CALL_CLIENT_RECV_REPLY) {
 		rxrpc_propose_ACK(call, RXRPC_ACK_IDLE, 0, 0, true, false);
 		rxrpc_send_call_packet(call, RXRPC_PACKET_TYPE_ACK);
-	} else {
-		rxrpc_propose_ACK(call, RXRPC_ACK_IDLE, 0, 0, false, false);
 	}
 
 	write_lock_bh(&call->state_lock);

[toc] | [standalone]


Back to top | Article view | linux.kernel


csiph-web