Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1488541 > unrolled thread
| Started by | Daeseok Youn <daeseok.youn@gmail.com> |
|---|---|
| First post | 2016-09-22 07:30 +0200 |
| Last post | 2016-09-22 09:30 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH 01/11] staging: dgnc: remove redundant initialization for Daeseok Youn <daeseok.youn@gmail.com> - 2016-09-22 07:30 +0200
Re: [PATCH 01/11] staging: dgnc: remove redundant initialization for Greg KH <gregkh@linuxfoundation.org> - 2016-09-22 09:30 +0200
| From | Daeseok Youn <daeseok.youn@gmail.com> |
|---|---|
| Date | 2016-09-22 07:30 +0200 |
| Subject | [PATCH 01/11] staging: dgnc: remove redundant initialization for |
| Message-ID | <sk4K6-2dI-5@gated-at.bofh.it> |
The channel array in board_t was initialized in dgnc_found_board() with NULL. But the channel is going to initialize in dgnc_tty_init(). So the channel array doesn't need to set NULL for initailization. Signed-off-by: Daeseok Youn <daeseok.youn@gmail.com> --- drivers/staging/dgnc/dgnc_driver.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/staging/dgnc/dgnc_driver.c b/drivers/staging/dgnc/dgnc_driver.c index 01e948c..b598034 100644 --- a/drivers/staging/dgnc/dgnc_driver.c +++ b/drivers/staging/dgnc/dgnc_driver.c @@ -400,9 +400,6 @@ static int dgnc_found_board(struct pci_dev *pdev, int id) brd->state = BOARD_FOUND; - for (i = 0; i < MAXPORTS; i++) - brd->channels[i] = NULL; - /* store which card & revision we have */ pci_read_config_word(pdev, PCI_SUBSYSTEM_VENDOR_ID, &brd->subvendor); pci_read_config_word(pdev, PCI_SUBSYSTEM_ID, &brd->subdevice); -- 1.9.1
[toc] | [next] | [standalone]
| From | Greg KH <gregkh@linuxfoundation.org> |
|---|---|
| Date | 2016-09-22 09:30 +0200 |
| Message-ID | <sk6Cd-3ml-7@gated-at.bofh.it> |
| In reply to | #1488541 |
On Thu, Sep 22, 2016 at 02:20:51PM +0900, Daeseok Youn wrote: > The channel array in board_t was initialized in dgnc_found_board() > with NULL. But the channel is going to initialize in dgnc_tty_init(). > So the channel array doesn't need to set NULL for initailization. > > Signed-off-by: Daeseok Youn <daeseok.youn@gmail.com> > --- > drivers/staging/dgnc/dgnc_driver.c | 3 --- > 1 file changed, 3 deletions(-) Your subject is odd, why end in "for"?
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web