Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1488492 > unrolled thread
| Started by | Shuah Khan <shuahkh@osg.samsung.com> |
|---|---|
| First post | 2016-09-22 03:00 +0200 |
| Last post | 2016-09-22 09:40 +0200 |
| Articles | 3 — 3 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
[PATCH v2 3/3] tools: move pcmcia crc32hash tool from Documentation Shuah Khan <shuahkh@osg.samsung.com> - 2016-09-22 03:00 +0200
Re: [PATCH v2 3/3] tools: move pcmcia crc32hash tool from Documentation Greg KH <gregkh@linuxfoundation.org> - 2016-09-22 07:20 +0200
Re: [PATCH v2 3/3] tools: move pcmcia crc32hash tool from Documentation Dominik Brodowski <linux@dominikbrodowski.net> - 2016-09-22 09:40 +0200
| From | Shuah Khan <shuahkh@osg.samsung.com> |
|---|---|
| Date | 2016-09-22 03:00 +0200 |
| Subject | [PATCH v2 3/3] tools: move pcmcia crc32hash tool from Documentation |
| Message-ID | <sk0wO-7KL-1@gated-at.bofh.it> |
Move pcmcia crc32hash tool from Documentation to tools/pcmcia and
remove it from Documentation Makefile. Update location information
for this tool. Create a new Makefile to build pcmcia. It can be built
from top level directory or from pcmcia directory:
Run make -C tools/pcmcia or cd tools/pcmcia; make
Signed-off-by: Shuah Khan <shuahkh@osg.samsung.com>
---
Documentation/Makefile | 3 +--
Documentation/pcmcia/.gitignore | 1 -
Documentation/pcmcia/Makefile | 7 -------
Documentation/pcmcia/crc32hash.c | 32 --------------------------------
Documentation/pcmcia/devicetable.txt | 4 ++--
MAINTAINERS | 1 +
tools/pcmcia/.gitignore | 1 +
tools/pcmcia/Makefile | 9 +++++++++
tools/pcmcia/crc32hash.c | 32 ++++++++++++++++++++++++++++++++
9 files changed, 46 insertions(+), 44 deletions(-)
delete mode 100644 Documentation/pcmcia/.gitignore
delete mode 100644 Documentation/pcmcia/Makefile
delete mode 100644 Documentation/pcmcia/crc32hash.c
create mode 100644 tools/pcmcia/.gitignore
create mode 100644 tools/pcmcia/Makefile
create mode 100644 tools/pcmcia/crc32hash.c
diff --git a/Documentation/Makefile b/Documentation/Makefile
index 0ddb50c..8435965 100644
--- a/Documentation/Makefile
+++ b/Documentation/Makefile
@@ -1,2 +1 @@
-subdir-y := blackfin \
- pcmcia
+subdir-y := blackfin
diff --git a/Documentation/pcmcia/.gitignore b/Documentation/pcmcia/.gitignore
deleted file mode 100644
index 53d0813..0000000
--- a/Documentation/pcmcia/.gitignore
+++ /dev/null
@@ -1 +0,0 @@
-crc32hash
diff --git a/Documentation/pcmcia/Makefile b/Documentation/pcmcia/Makefile
deleted file mode 100644
index 47a8fa1..0000000
--- a/Documentation/pcmcia/Makefile
+++ /dev/null
@@ -1,7 +0,0 @@
-# List of programs to build
-hostprogs-y := crc32hash
-
-# Tell kbuild to always build the programs
-always := $(hostprogs-y)
-
-HOSTCFLAGS_crc32hash.o += -I$(objtree)/usr/include
diff --git a/Documentation/pcmcia/crc32hash.c b/Documentation/pcmcia/crc32hash.c
deleted file mode 100644
index 44f8bee..0000000
--- a/Documentation/pcmcia/crc32hash.c
+++ /dev/null
@@ -1,32 +0,0 @@
-/* crc32hash.c - derived from linux/lib/crc32.c, GNU GPL v2 */
-/* Usage example:
-$ ./crc32hash "Dual Speed"
-*/
-
-#include <string.h>
-#include <stdio.h>
-#include <ctype.h>
-#include <stdlib.h>
-
-static unsigned int crc32(unsigned char const *p, unsigned int len)
-{
- int i;
- unsigned int crc = 0;
- while (len--) {
- crc ^= *p++;
- for (i = 0; i < 8; i++)
- crc = (crc >> 1) ^ ((crc & 1) ? 0xedb88320 : 0);
- }
- return crc;
-}
-
-int main(int argc, char **argv) {
- unsigned int result;
- if (argc != 2) {
- printf("no string passed as argument\n");
- return -1;
- }
- result = crc32((unsigned char const *)argv[1], strlen(argv[1]));
- printf("0x%x\n", result);
- return 0;
-}
diff --git a/Documentation/pcmcia/devicetable.txt b/Documentation/pcmcia/devicetable.txt
index 199afd1..5f3e00a 100644
--- a/Documentation/pcmcia/devicetable.txt
+++ b/Documentation/pcmcia/devicetable.txt
@@ -27,7 +27,7 @@ pcmcia:m0149cC1ABf06pfn00fn00pa725B842DpbF1EFEE84pc0877B627pd00000000
The hex value after "pa" is the hash of product ID string 1, after "pb" for
string 2 and so on.
-Alternatively, you can use crc32hash (see Documentation/pcmcia/crc32hash.c)
+Alternatively, you can use crc32hash (see tools/pcmcia/crc32hash.c)
to determine the crc32 hash. Simply pass the string you want to evaluate
as argument to this program, e.g.:
-$ ./crc32hash "Dual Speed"
+$ tools/pcmcia/crc32hash "Dual Speed"
diff --git a/MAINTAINERS b/MAINTAINERS
index afd3577..54b70ce 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -9125,6 +9125,7 @@ W: http://lists.infradead.org/mailman/listinfo/linux-pcmcia
T: git git://git.kernel.org/pub/scm/linux/kernel/git/brodo/pcmcia.git
S: Maintained
F: Documentation/pcmcia/
+F: tools/pcmcia/
F: drivers/pcmcia/
F: include/pcmcia/
diff --git a/tools/pcmcia/.gitignore b/tools/pcmcia/.gitignore
new file mode 100644
index 0000000..53d0813
--- /dev/null
+++ b/tools/pcmcia/.gitignore
@@ -0,0 +1 @@
+crc32hash
diff --git a/tools/pcmcia/Makefile b/tools/pcmcia/Makefile
new file mode 100644
index 0000000..81a7498
--- /dev/null
+++ b/tools/pcmcia/Makefile
@@ -0,0 +1,9 @@
+CC := $(CROSS_COMPILE)gcc
+CFLAGS := -I../../usr/include
+
+PROGS := crc32hash
+
+all: $(PROGS)
+
+clean:
+ rm -fr $(PROGS)
diff --git a/tools/pcmcia/crc32hash.c b/tools/pcmcia/crc32hash.c
new file mode 100644
index 0000000..44f8bee
--- /dev/null
+++ b/tools/pcmcia/crc32hash.c
@@ -0,0 +1,32 @@
+/* crc32hash.c - derived from linux/lib/crc32.c, GNU GPL v2 */
+/* Usage example:
+$ ./crc32hash "Dual Speed"
+*/
+
+#include <string.h>
+#include <stdio.h>
+#include <ctype.h>
+#include <stdlib.h>
+
+static unsigned int crc32(unsigned char const *p, unsigned int len)
+{
+ int i;
+ unsigned int crc = 0;
+ while (len--) {
+ crc ^= *p++;
+ for (i = 0; i < 8; i++)
+ crc = (crc >> 1) ^ ((crc & 1) ? 0xedb88320 : 0);
+ }
+ return crc;
+}
+
+int main(int argc, char **argv) {
+ unsigned int result;
+ if (argc != 2) {
+ printf("no string passed as argument\n");
+ return -1;
+ }
+ result = crc32((unsigned char const *)argv[1], strlen(argv[1]));
+ printf("0x%x\n", result);
+ return 0;
+}
--
2.7.4
[toc] | [next] | [standalone]
| From | Greg KH <gregkh@linuxfoundation.org> |
|---|---|
| Date | 2016-09-22 07:20 +0200 |
| Subject | Re: [PATCH v2 3/3] tools: move pcmcia crc32hash tool from Documentation |
| Message-ID | <sk4Ap-2ay-1@gated-at.bofh.it> |
| In reply to | #1488492 |
On Wed, Sep 21, 2016 at 06:51:13PM -0600, Shuah Khan wrote: > Move pcmcia crc32hash tool from Documentation to tools/pcmcia and > remove it from Documentation Makefile. Update location information > for this tool. Create a new Makefile to build pcmcia. It can be built > from top level directory or from pcmcia directory: > > Run make -C tools/pcmcia or cd tools/pcmcia; make > > Signed-off-by: Shuah Khan <shuahkh@osg.samsung.com> > --- > Documentation/Makefile | 3 +-- > Documentation/pcmcia/.gitignore | 1 - > Documentation/pcmcia/Makefile | 7 ------- > Documentation/pcmcia/crc32hash.c | 32 -------------------------------- > Documentation/pcmcia/devicetable.txt | 4 ++-- > MAINTAINERS | 1 + > tools/pcmcia/.gitignore | 1 + > tools/pcmcia/Makefile | 9 +++++++++ > tools/pcmcia/crc32hash.c | 32 ++++++++++++++++++++++++++++++++ > 9 files changed, 46 insertions(+), 44 deletions(-) > delete mode 100644 Documentation/pcmcia/.gitignore > delete mode 100644 Documentation/pcmcia/Makefile > delete mode 100644 Documentation/pcmcia/crc32hash.c > create mode 100644 tools/pcmcia/.gitignore > create mode 100644 tools/pcmcia/Makefile > create mode 100644 tools/pcmcia/crc32hash.c Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
[toc] | [prev] | [next] | [standalone]
| From | Dominik Brodowski <linux@dominikbrodowski.net> |
|---|---|
| Date | 2016-09-22 09:40 +0200 |
| Subject | Re: [PATCH v2 3/3] tools: move pcmcia crc32hash tool from Documentation |
| Message-ID | <sk6LT-3pX-5@gated-at.bofh.it> |
| In reply to | #1488492 |
[Multipart message — attachments visible in raw view] — view raw
On Wed, Sep 21, 2016 at 06:51:13PM -0600, Shuah Khan wrote: > Move pcmcia crc32hash tool from Documentation to tools/pcmcia and > remove it from Documentation Makefile. Update location information > for this tool. Create a new Makefile to build pcmcia. It can be built > from top level directory or from pcmcia directory: > > Run make -C tools/pcmcia or cd tools/pcmcia; make > > Signed-off-by: Shuah Khan <shuahkh@osg.samsung.com> Acked-by: Dominik Brodowski <linux@dominikbrodowski.net>
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web