Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1487773 > unrolled thread
| Started by | Shawn Lin <shawn.lin@rock-chips.com> |
|---|---|
| First post | 2016-09-21 04:50 +0200 |
| Last post | 2016-09-22 06:30 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH] mmc: dw_mmc: minor cleanup for dw_mci_adjust_fifoth Shawn Lin <shawn.lin@rock-chips.com> - 2016-09-21 04:50 +0200
Re: [PATCH] mmc: dw_mmc: minor cleanup for dw_mci_adjust_fifoth Jaehoon Chung <jh80.chung@samsung.com> - 2016-09-22 06:30 +0200
| From | Shawn Lin <shawn.lin@rock-chips.com> |
|---|---|
| Date | 2016-09-21 04:50 +0200 |
| Subject | [PATCH] mmc: dw_mmc: minor cleanup for dw_mci_adjust_fifoth |
| Message-ID | <sjFLH-3b0-7@gated-at.bofh.it> |
msize and rx_wmark are properly initialized, we dont't
need to assign them again.
Signed-off-by: Shawn Lin <shawn.lin@rock-chips.com>
---
drivers/mmc/host/dw_mmc.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/mmc/host/dw_mmc.c b/drivers/mmc/host/dw_mmc.c
index 22dacae..d838428 100644
--- a/drivers/mmc/host/dw_mmc.c
+++ b/drivers/mmc/host/dw_mmc.c
@@ -876,11 +876,8 @@ static void dw_mci_adjust_fifoth(struct dw_mci *host, struct mmc_data *data)
* MSIZE is '1',
* if blksz is not a multiple of the FIFO width
*/
- if (blksz % fifo_width) {
- msize = 0;
- rx_wmark = 1;
+ if (blksz % fifo_width)
goto done;
- }
do {
if (!((blksz_depth % mszs[idx]) ||
--
2.3.7
[toc] | [next] | [standalone]
| From | Jaehoon Chung <jh80.chung@samsung.com> |
|---|---|
| Date | 2016-09-22 06:30 +0200 |
| Message-ID | <sk3O2-1Eg-17@gated-at.bofh.it> |
| In reply to | #1487773 |
On 09/21/2016 11:40 AM, Shawn Lin wrote:
> msize and rx_wmark are properly initialized, we dont't
> need to assign them again.
Applied on my tree. Thanks!
Best Regards,
Jaehoon Chung
>
> Signed-off-by: Shawn Lin <shawn.lin@rock-chips.com>
> ---
>
> drivers/mmc/host/dw_mmc.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/mmc/host/dw_mmc.c b/drivers/mmc/host/dw_mmc.c
> index 22dacae..d838428 100644
> --- a/drivers/mmc/host/dw_mmc.c
> +++ b/drivers/mmc/host/dw_mmc.c
> @@ -876,11 +876,8 @@ static void dw_mci_adjust_fifoth(struct dw_mci *host, struct mmc_data *data)
> * MSIZE is '1',
> * if blksz is not a multiple of the FIFO width
> */
> - if (blksz % fifo_width) {
> - msize = 0;
> - rx_wmark = 1;
> + if (blksz % fifo_width)
> goto done;
> - }
>
> do {
> if (!((blksz_depth % mszs[idx]) ||
>
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web