Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1487153 > unrolled thread

[PATCH v2 6/6] MIPS: Deprecate VPE Loader

Started byMatt Redfearn <matt.redfearn@imgtec.com>
First post2016-09-20 10:50 +0200
Last post2016-09-20 16:00 +0200
Articles 4 — 3 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  [PATCH v2 6/6] MIPS: Deprecate VPE Loader Matt Redfearn <matt.redfearn@imgtec.com> - 2016-09-20 10:50 +0200
    Re: [PATCH v2 6/6] MIPS: Deprecate VPE Loader Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2016-09-20 12:30 +0200
    Re: [PATCH v2 6/6] MIPS: Deprecate VPE Loader Ralf Baechle <ralf@linux-mips.org> - 2016-09-20 15:20 +0200
      Re: [PATCH v2 6/6] MIPS: Deprecate VPE Loader Matt Redfearn <matt.redfearn@imgtec.com> - 2016-09-20 16:00 +0200

#1487153 — [PATCH v2 6/6] MIPS: Deprecate VPE Loader

FromMatt Redfearn <matt.redfearn@imgtec.com>
Date2016-09-20 10:50 +0200
Subject[PATCH v2 6/6] MIPS: Deprecate VPE Loader
Message-ID<sjoUy-Bu-11@gated-at.bofh.it>
The MIPS remote processor driver (CONFIG_MIPS_RPROC) provides a more
standard mechanism for using one or more VPs as coprocessors running
separate firmware.

Here we deprecate this mechanism before it is removed.

Signed-off-by: Matt Redfearn <matt.redfearn@imgtec.com>
---

Changes in v2: None

 arch/mips/Kconfig | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/arch/mips/Kconfig b/arch/mips/Kconfig
index 2094cbcea0d4..071fc4585265 100644
--- a/arch/mips/Kconfig
+++ b/arch/mips/Kconfig
@@ -2263,7 +2263,7 @@ comment "MIPS R2-to-R6 emulator is only available for UP kernels"
 	depends on SMP && CPU_MIPSR6
 
 config MIPS_VPE_LOADER
-	bool "VPE loader support."
+	bool "VPE loader support. (DEPRECATED)"
 	depends on SYS_SUPPORTS_MULTITHREADING && MODULES
 	select CPU_MIPSR2_IRQ_VI
 	select CPU_MIPSR2_IRQ_EI
@@ -2272,6 +2272,9 @@ config MIPS_VPE_LOADER
 	  Includes a loader for loading an elf relocatable object
 	  onto another VPE and running it.
 
+	  Unless you have a specific need, you should use CONFIG_MIPS_RPROC
+          instead of this.
+
 config MIPS_VPE_LOADER_CMP
 	bool
 	default "y"
-- 
2.7.4

[toc] | [next] | [standalone]


#1487214

FromSergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Date2016-09-20 12:30 +0200
Message-ID<sjqtk-1J4-25@gated-at.bofh.it>
In reply to#1487153
Hello.

On 9/20/2016 11:47 AM, Matt Redfearn wrote:

> The MIPS remote processor driver (CONFIG_MIPS_RPROC) provides a more
> standard mechanism for using one or more VPs as coprocessors running
> separate firmware.
>
> Here we deprecate this mechanism before it is removed.
>
> Signed-off-by: Matt Redfearn <matt.redfearn@imgtec.com>
> ---
>
> Changes in v2: None
>
>  arch/mips/Kconfig | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/arch/mips/Kconfig b/arch/mips/Kconfig
> index 2094cbcea0d4..071fc4585265 100644
> --- a/arch/mips/Kconfig
> +++ b/arch/mips/Kconfig
> @@ -2263,7 +2263,7 @@ comment "MIPS R2-to-R6 emulator is only available for UP kernels"
>  	depends on SMP && CPU_MIPSR6
>
>  config MIPS_VPE_LOADER
> -	bool "VPE loader support."
> +	bool "VPE loader support. (DEPRECATED)"

    I think the period should be after (DEPRECATED), if at all.

[...]

MBR,Sergei

[toc] | [prev] | [next] | [standalone]


#1487333

FromRalf Baechle <ralf@linux-mips.org>
Date2016-09-20 15:20 +0200
Message-ID<sjt7P-3qP-9@gated-at.bofh.it>
In reply to#1487153
On Tue, Sep 20, 2016 at 09:47:29AM +0100, Matt Redfearn wrote:

> The MIPS remote processor driver (CONFIG_MIPS_RPROC) provides a more
> standard mechanism for using one or more VPs as coprocessors running
> separate firmware.
> 
> Here we deprecate this mechanism before it is removed.

The world will be a better place once this is removed.

I receive the occasional minor cleanup or robopatch (coccinelle or similar)
for the VPE loader but I have no indication this is actually being used
by anybody, so is thee any reason why not to delete it right away?

  Ralf

[toc] | [prev] | [next] | [standalone]


#1487357

FromMatt Redfearn <matt.redfearn@imgtec.com>
Date2016-09-20 16:00 +0200
Message-ID<sjtKx-3DJ-9@gated-at.bofh.it>
In reply to#1487333
Hi Ralf,


On 20/09/16 14:19, Ralf Baechle wrote:
> On Tue, Sep 20, 2016 at 09:47:29AM +0100, Matt Redfearn wrote:
>
>> The MIPS remote processor driver (CONFIG_MIPS_RPROC) provides a more
>> standard mechanism for using one or more VPs as coprocessors running
>> separate firmware.
>>
>> Here we deprecate this mechanism before it is removed.
> The world will be a better place once this is removed.

Indeed :-)

>
> I receive the occasional minor cleanup or robopatch (coccinelle or similar)
> for the VPE loader but I have no indication this is actually being used
> by anybody, so is thee any reason why not to delete it right away?

I'd like to get the remote processor implementation in, then delete the 
VPE loader in the next kernel revision, if that's ok with you. Once it 
is removed, we should also be able to remove the CMP SMP implementation, 
and other bits of infrastructure that'll no longer be needed.

Thanks,
Matt

>
>    Ralf

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web