Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1485804 > unrolled thread
| Started by | Baoyou Xie <baoyou.xie@linaro.org> |
|---|---|
| First post | 2016-09-18 16:00 +0200 |
| Last post | 2016-09-20 10:30 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH] drm/exynos: mark exynos_dp_crtc_clock_enable() static Baoyou Xie <baoyou.xie@linaro.org> - 2016-09-18 16:00 +0200
Re: [PATCH] drm/exynos: mark exynos_dp_crtc_clock_enable() static Andrzej Hajda <a.hajda@samsung.com> - 2016-09-20 10:30 +0200
| From | Baoyou Xie <baoyou.xie@linaro.org> |
|---|---|
| Date | 2016-09-18 16:00 +0200 |
| Subject | [PATCH] drm/exynos: mark exynos_dp_crtc_clock_enable() static |
| Message-ID | <siKNs-lH-3@gated-at.bofh.it> |
We get 1 warning when building kernel with W=1:
drivers/gpu/drm/exynos/exynos_dp.c:46:5: warning: no previous prototype for 'exynos_dp_crtc_clock_enable' [-Wmissing-prototypes]
In fact, this function is only used in the file in which it is
declared and don't need a declaration, but can be made static.
So this patch marks it 'static'.
Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>
---
drivers/gpu/drm/exynos/exynos_dp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/exynos/exynos_dp.c b/drivers/gpu/drm/exynos/exynos_dp.c
index 4f08505..528229f 100644
--- a/drivers/gpu/drm/exynos/exynos_dp.c
+++ b/drivers/gpu/drm/exynos/exynos_dp.c
@@ -43,7 +43,7 @@ struct exynos_dp_device {
struct analogix_dp_plat_data plat_data;
};
-int exynos_dp_crtc_clock_enable(struct analogix_dp_plat_data *plat_data,
+static int exynos_dp_crtc_clock_enable(struct analogix_dp_plat_data *plat_data,
bool enable)
{
struct exynos_dp_device *dp = to_dp(plat_data);
--
2.7.4
[toc] | [next] | [standalone]
| From | Andrzej Hajda <a.hajda@samsung.com> |
|---|---|
| Date | 2016-09-20 10:30 +0200 |
| Message-ID | <sjoBb-uQ-13@gated-at.bofh.it> |
| In reply to | #1485804 |
On 18.09.2016 15:58, Baoyou Xie wrote: > We get 1 warning when building kernel with W=1: > drivers/gpu/drm/exynos/exynos_dp.c:46:5: warning: no previous prototype for 'exynos_dp_crtc_clock_enable' [-Wmissing-prototypes] > > In fact, this function is only used in the file in which it is > declared and don't need a declaration, but can be made static. > So this patch marks it 'static'. > > Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org> Reviewed-by: Andrzej Hajda <a.hajda@samsung.com> -- Regards Andrzej
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web