Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1487234 > unrolled thread

[PATCH] clk: nxp: clk-lpc32xx: Unmap region obtained by of_iomap

Started byArvind Yadav <arvind.yadav.cs@gmail.com>
First post2016-09-20 13:00 +0200
Last post2016-09-21 23:30 +0200
Articles 4 — 4 participants

Back to article view | Back to linux.kernel


Contents

  [PATCH] clk: nxp: clk-lpc32xx: Unmap region obtained by of_iomap Arvind Yadav <arvind.yadav.cs@gmail.com> - 2016-09-20 13:00 +0200
    Re: [PATCH] clk: nxp: clk-lpc32xx: Unmap region obtained by of_iomap Vladimir Zapolskiy <vz@mleia.com> - 2016-09-21 12:20 +0200
      Re: [PATCH] clk: nxp: clk-lpc32xx: Unmap region obtained by  of_iomap "Sylvain Lemieux (gmail)" <slemieux.tyco@gmail.com> - 2016-09-21 19:50 +0200
    Re: [PATCH] clk: nxp: clk-lpc32xx: Unmap region obtained by of_iomap Stephen Boyd <sboyd@codeaurora.org> - 2016-09-21 23:30 +0200

#1487234 — [PATCH] clk: nxp: clk-lpc32xx: Unmap region obtained by of_iomap

FromArvind Yadav <arvind.yadav.cs@gmail.com>
Date2016-09-20 13:00 +0200
Subject[PATCH] clk: nxp: clk-lpc32xx: Unmap region obtained by of_iomap
Message-ID<sjqWl-1To-11@gated-at.bofh.it>
From: Arvind Yadav <arvind.yadav.cs@gmail.com>

Free memory mapping, if lpc32xx_clk_init is not successful.

Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
 drivers/clk/nxp/clk-lpc32xx.c |    1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/clk/nxp/clk-lpc32xx.c b/drivers/clk/nxp/clk-lpc32xx.c
index 90d740a..34c9735 100644
--- a/drivers/clk/nxp/clk-lpc32xx.c
+++ b/drivers/clk/nxp/clk-lpc32xx.c
@@ -1513,6 +1513,7 @@ static void __init lpc32xx_clk_init(struct device_node *np)
 	if (IS_ERR(clk_regmap)) {
 		pr_err("failed to regmap system control block: %ld\n",
 			PTR_ERR(clk_regmap));
+		iounmap(base);
 		return;
 	}
 
-- 
1.7.9.5

[toc] | [next] | [standalone]


#1488008

FromVladimir Zapolskiy <vz@mleia.com>
Date2016-09-21 12:20 +0200
Message-ID<sjMNc-7My-21@gated-at.bofh.it>
In reply to#1487234
On 20.09.2016 13:54, Arvind Yadav wrote:
> From: Arvind Yadav <arvind.yadav.cs@gmail.com>
> 
> Free memory mapping, if lpc32xx_clk_init is not successful.
> 
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
> ---
>  drivers/clk/nxp/clk-lpc32xx.c |    1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/clk/nxp/clk-lpc32xx.c b/drivers/clk/nxp/clk-lpc32xx.c
> index 90d740a..34c9735 100644
> --- a/drivers/clk/nxp/clk-lpc32xx.c
> +++ b/drivers/clk/nxp/clk-lpc32xx.c
> @@ -1513,6 +1513,7 @@ static void __init lpc32xx_clk_init(struct device_node *np)
>  	if (IS_ERR(clk_regmap)) {
>  		pr_err("failed to regmap system control block: %ld\n",
>  			PTR_ERR(clk_regmap));
> +		iounmap(base);
>  		return;
>  	}
>  
> 

Acked-by: Vladimir Zapolskiy <vz@mleia.com>

Thank you for the patch.

--
With best wishes,
Vladimir

[toc] | [prev] | [next] | [standalone]


#1488305 — Re: [PATCH] clk: nxp: clk-lpc32xx: Unmap region obtained by of_iomap

From"Sylvain Lemieux (gmail)" <slemieux.tyco@gmail.com>
Date2016-09-21 19:50 +0200
SubjectRe: [PATCH] clk: nxp: clk-lpc32xx: Unmap region obtained by of_iomap
Message-ID<sjTOG-3vE-9@gated-at.bofh.it>
In reply to#1488008
On Wed, 2016-09-21 at 13:17 +0300, Vladimir Zapolskiy wrote:
> On 20.09.2016 13:54, Arvind Yadav wrote:
> > From: Arvind Yadav <arvind.yadav.cs@gmail.com>
> > 
> > Free memory mapping, if lpc32xx_clk_init is not successful.
> > 
> > Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
> > ---
> >  drivers/clk/nxp/clk-lpc32xx.c |    1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/drivers/clk/nxp/clk-lpc32xx.c b/drivers/clk/nxp/clk-lpc32xx.c
> > index 90d740a..34c9735 100644
> > --- a/drivers/clk/nxp/clk-lpc32xx.c
> > +++ b/drivers/clk/nxp/clk-lpc32xx.c
> > @@ -1513,6 +1513,7 @@ static void __init lpc32xx_clk_init(struct device_node *np)
> >  	if (IS_ERR(clk_regmap)) {
> >  		pr_err("failed to regmap system control block: %ld\n",
> >  			PTR_ERR(clk_regmap));
> > +		iounmap(base);
> >  		return;
> >  	}
> >  
> > 
> 
> Acked-by: Vladimir Zapolskiy <vz@mleia.com>
> 
> Thank you for the patch.
> 
Acked-by: Sylvain Lemieux <slemieux.tyco@gmail.com>

> --
> With best wishes,
> Vladimir
> 
> 

[toc] | [prev] | [next] | [standalone]


#1488428

FromStephen Boyd <sboyd@codeaurora.org>
Date2016-09-21 23:30 +0200
Message-ID<sjXfz-5O8-15@gated-at.bofh.it>
In reply to#1487234
On 09/20, Arvind Yadav wrote:
> From: Arvind Yadav <arvind.yadav.cs@gmail.com>
> 
> Free memory mapping, if lpc32xx_clk_init is not successful.
> 
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
> ---

Applied to clk-next

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web