Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1487810 > unrolled thread

[PATCH] drm/tilcdc: add missing header dependencies

Back to article view | Back to linux.kernel

Contents

  [PATCH] drm/tilcdc: add missing header dependencies Baoyou Xie <baoyou.xie@linaro.org> - 2016-09-21 07:20 +0200
    Re: [PATCH] drm/tilcdc: add missing header dependencies Jyri Sarha <jsarha@ti.com> - 2016-09-22 18:00 +0200

#1487810 — [PATCH] drm/tilcdc: add missing header dependencies

We get 4 warnings when building kernel with W=1:
drivers/gpu/drm/tilcdc/tilcdc_tfp410.c:397:12: warning: no previous prototype for 'tilcdc_tfp410_init' [-Wmissing-prototypes]
drivers/gpu/drm/tilcdc/tilcdc_tfp410.c:402:13: warning: no previous prototype for 'tilcdc_tfp410_fini' [-Wmissing-prototypes]
drivers/gpu/drm/tilcdc/tilcdc_panel.c:448:12: warning: no previous prototype for 'tilcdc_panel_init' [-Wmissing-prototypes]
drivers/gpu/drm/tilcdc/tilcdc_panel.c:453:13: warning: no previous prototype for 'tilcdc_panel_fini' [-Wmissing-prototypes]

In fact, these functions are declared in
drivers/gpu/drm/tilcdc/tilcdc_tfp410.h,
drivers/gpu/drm/tilcdc/tilcdc_panel.h,
so this patch adds missing header dependencies.

Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>
---
 drivers/gpu/drm/tilcdc/tilcdc_panel.c  | 1 +
 drivers/gpu/drm/tilcdc/tilcdc_tfp410.c | 1 +
 2 files changed, 2 insertions(+)

diff --git a/drivers/gpu/drm/tilcdc/tilcdc_panel.c b/drivers/gpu/drm/tilcdc/tilcdc_panel.c
index 4ac1d25..186cf23 100644
--- a/drivers/gpu/drm/tilcdc/tilcdc_panel.c
+++ b/drivers/gpu/drm/tilcdc/tilcdc_panel.c
@@ -25,6 +25,7 @@
 #include <drm/drm_atomic_helper.h>
 
 #include "tilcdc_drv.h"
+#include "tilcdc_panel.h"
 
 struct panel_module {
 	struct tilcdc_module base;
diff --git a/drivers/gpu/drm/tilcdc/tilcdc_tfp410.c b/drivers/gpu/drm/tilcdc/tilcdc_tfp410.c
index 741c7b5..8692671 100644
--- a/drivers/gpu/drm/tilcdc/tilcdc_tfp410.c
+++ b/drivers/gpu/drm/tilcdc/tilcdc_tfp410.c
@@ -23,6 +23,7 @@
 #include <drm/drm_atomic_helper.h>
 
 #include "tilcdc_drv.h"
+#include "tilcdc_tfp410.h"
 
 struct tfp410_module {
 	struct tilcdc_module base;
-- 
2.7.4

[toc] | [next] | [standalone]

#1489054

Thanks,
But I have got this already:

https://lists.freedesktop.org/archives/dri-devel/2016-September/117900.html

I will send a pull request soon.

Best regards,
Jyri

On 09/21/16 08:12, Baoyou Xie wrote:
> We get 4 warnings when building kernel with W=1:
> drivers/gpu/drm/tilcdc/tilcdc_tfp410.c:397:12: warning: no previous prototype for 'tilcdc_tfp410_init' [-Wmissing-prototypes]
> drivers/gpu/drm/tilcdc/tilcdc_tfp410.c:402:13: warning: no previous prototype for 'tilcdc_tfp410_fini' [-Wmissing-prototypes]
> drivers/gpu/drm/tilcdc/tilcdc_panel.c:448:12: warning: no previous prototype for 'tilcdc_panel_init' [-Wmissing-prototypes]
> drivers/gpu/drm/tilcdc/tilcdc_panel.c:453:13: warning: no previous prototype for 'tilcdc_panel_fini' [-Wmissing-prototypes]
> 
> In fact, these functions are declared in
> drivers/gpu/drm/tilcdc/tilcdc_tfp410.h,
> drivers/gpu/drm/tilcdc/tilcdc_panel.h,
> so this patch adds missing header dependencies.
> 
> Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>
> ---
>  drivers/gpu/drm/tilcdc/tilcdc_panel.c  | 1 +
>  drivers/gpu/drm/tilcdc/tilcdc_tfp410.c | 1 +
>  2 files changed, 2 insertions(+)
> 
> diff --git a/drivers/gpu/drm/tilcdc/tilcdc_panel.c b/drivers/gpu/drm/tilcdc/tilcdc_panel.c
> index 4ac1d25..186cf23 100644
> --- a/drivers/gpu/drm/tilcdc/tilcdc_panel.c
> +++ b/drivers/gpu/drm/tilcdc/tilcdc_panel.c
> @@ -25,6 +25,7 @@
>  #include <drm/drm_atomic_helper.h>
>  
>  #include "tilcdc_drv.h"
> +#include "tilcdc_panel.h"
>  
>  struct panel_module {
>  	struct tilcdc_module base;
> diff --git a/drivers/gpu/drm/tilcdc/tilcdc_tfp410.c b/drivers/gpu/drm/tilcdc/tilcdc_tfp410.c
> index 741c7b5..8692671 100644
> --- a/drivers/gpu/drm/tilcdc/tilcdc_tfp410.c
> +++ b/drivers/gpu/drm/tilcdc/tilcdc_tfp410.c
> @@ -23,6 +23,7 @@
>  #include <drm/drm_atomic_helper.h>
>  
>  #include "tilcdc_drv.h"
> +#include "tilcdc_tfp410.h"
>  
>  struct tfp410_module {
>  	struct tilcdc_module base;
> 

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web