Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1481506 > unrolled thread

[PATCH] ARCv2: intc: Use kflag if STATUS32.IE must be reset

Back to article view | Back to linux.kernel

Contents

  [PATCH] ARCv2: intc: Use kflag if STATUS32.IE must be reset Yuriy Kolerov <yuriy.kolerov@synopsys.com> - 2016-09-12 18:00 +0200
    Re: [PATCH] ARCv2: intc: Use kflag if STATUS32.IE must be reset Vineet Gupta <Vineet.Gupta1@synopsys.com> - 2016-09-21 00:00 +0200

#1481506 — [PATCH] ARCv2: intc: Use kflag if STATUS32.IE must be reset

In the end of "arc_init_IRQ" STATUS32.IE flag is going to be affected by
"flag" instruction but "flag" never touches IE flag on ARCv2. So "kflag"
instruction must be used instead of "flag".

Signed-off-by: Yuriy Kolerov <yuriy.kolerov@synopsys.com>
---
 arch/arc/kernel/intc-arcv2.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arc/kernel/intc-arcv2.c b/arch/arc/kernel/intc-arcv2.c
index 6c24faf..62b59409 100644
--- a/arch/arc/kernel/intc-arcv2.c
+++ b/arch/arc/kernel/intc-arcv2.c
@@ -74,7 +74,7 @@ void arc_init_IRQ(void)
 	tmp = read_aux_reg(0xa);
 	tmp |= STATUS_AD_MASK | (irq_prio << 1);
 	tmp &= ~STATUS_IE_MASK;
-	asm volatile("flag %0	\n"::"r"(tmp));
+	asm volatile("kflag %0	\n"::"r"(tmp));
 }
 
 static void arcv2_irq_mask(struct irq_data *data)
-- 
2.7.4

[toc] | [next] | [standalone]

#1487676

On 09/12/2016 08:55 AM, Yuriy Kolerov wrote:
> In the end of "arc_init_IRQ" STATUS32.IE flag is going to be affected by
> "flag" instruction but "flag" never touches IE flag on ARCv2. So "kflag"
> instruction must be used instead of "flag".
> 
> Signed-off-by: Yuriy Kolerov <yuriy.kolerov@synopsys.com>

Applied to for-next for 4.9 + stable backport.

Thx,
-Vineet

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web