Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1486351 > unrolled thread
| Started by | Jacek Anaszewski <j.anaszewski@samsung.com> |
|---|---|
| First post | 2016-09-19 13:00 +0200 |
| Last post | 2016-09-20 09:10 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH v3] leds: triggers: Check return value of kobject_uevent_env() Jacek Anaszewski <j.anaszewski@samsung.com> - 2016-09-19 13:00 +0200
Re: [PATCH v3] leds: triggers: Check return value of kobject_uevent_env() Greg KH <greg@kroah.com> - 2016-09-20 09:10 +0200
| From | Jacek Anaszewski <j.anaszewski@samsung.com> |
|---|---|
| Date | 2016-09-19 13:00 +0200 |
| Subject | [PATCH v3] leds: triggers: Check return value of kobject_uevent_env() |
| Message-ID | <sj4sN-4oK-1@gated-at.bofh.it> |
Log error message if kobject_uevent_env() fails in led_trigger_set().
Signed-off-by: Jacek Anaszewski <j.anaszewski@samsung.com>
---
Changes from v1:
- switched to using dev_err() instead of pr_err()
Changes from v2:
- switched to using __func__ instead of explicit function name,
to simplify code maintenance
drivers/leds/led-triggers.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/leds/led-triggers.c b/drivers/leds/led-triggers.c
index c7a38d4..431123b 100644
--- a/drivers/leds/led-triggers.c
+++ b/drivers/leds/led-triggers.c
@@ -141,7 +141,9 @@ void led_trigger_set(struct led_classdev *led_cdev, struct led_trigger *trig)
if (event) {
envp[0] = event;
envp[1] = NULL;
- kobject_uevent_env(&led_cdev->dev->kobj, KOBJ_CHANGE, envp);
+ if (kobject_uevent_env(&led_cdev->dev->kobj, KOBJ_CHANGE, envp))
+ dev_err(led_cdev->dev,
+ "%s: Error sending uevent\n", __func__);
kfree(event);
}
}
--
1.9.1
[toc] | [next] | [standalone]
| From | Greg KH <greg@kroah.com> |
|---|---|
| Date | 2016-09-20 09:10 +0200 |
| Subject | Re: [PATCH v3] leds: triggers: Check return value of kobject_uevent_env() |
| Message-ID | <sjnlM-8eo-7@gated-at.bofh.it> |
| In reply to | #1486351 |
On Mon, Sep 19, 2016 at 12:52:24PM +0200, Jacek Anaszewski wrote:
> Log error message if kobject_uevent_env() fails in led_trigger_set().
>
> Signed-off-by: Jacek Anaszewski <j.anaszewski@samsung.com>
> ---
> Changes from v1:
> - switched to using dev_err() instead of pr_err()
> Changes from v2:
> - switched to using __func__ instead of explicit function name,
> to simplify code maintenance
>
> drivers/leds/led-triggers.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/leds/led-triggers.c b/drivers/leds/led-triggers.c
> index c7a38d4..431123b 100644
> --- a/drivers/leds/led-triggers.c
> +++ b/drivers/leds/led-triggers.c
> @@ -141,7 +141,9 @@ void led_trigger_set(struct led_classdev *led_cdev, struct led_trigger *trig)
> if (event) {
> envp[0] = event;
> envp[1] = NULL;
> - kobject_uevent_env(&led_cdev->dev->kobj, KOBJ_CHANGE, envp);
> + if (kobject_uevent_env(&led_cdev->dev->kobj, KOBJ_CHANGE, envp))
> + dev_err(led_cdev->dev,
> + "%s: Error sending uevent\n", __func__);
> kfree(event);
> }
> }
> --
> 1.9.1
Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web