Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1485542 > unrolled thread

[PATCH 00/24] ste_dma40: Fine-tuning for several function implementations

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  [PATCH 00/24] ste_dma40: Fine-tuning for several function  implementations SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-17 17:10 +0200
    [PATCH 01/24] ste_dma40: Use kmalloc_array() in d40_lcla_allocate() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-17 17:10 +0200
    [PATCH 02/24] ste_dma40: Return directly after a failed  kmalloc_array() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-17 17:10 +0200
    [PATCH 03/24] ste_dma40: Rename a jump label in d40_lcla_allocate() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-17 17:20 +0200
    [PATCH 06/24] ste_dma40: Replace four kzalloc() calls by kcalloc() in  d40_hw_detect_init() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-17 17:20 +0200
    [PATCH 08/24] ste_dma40: Less checks in d40_hw_detect_init() after  error detection SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-17 17:20 +0200
    [PATCH 05/24] ste_dma40: Improve a size determination in  d40_of_probe() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-17 17:20 +0200
    [PATCH 07/24] ste_dma40: Use kmalloc_array() in d40_hw_detect_init() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-17 17:20 +0200
    [PATCH 04/24] ste_dma40: Move an assignment in d40_lcla_allocate() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-17 17:20 +0200
    [PATCH 09/24] ste_dma40: Delete unnecessary variable initialisations  in d40_hw_detect_init() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-17 17:20 +0200
    [PATCH 10/24] ste_dma40: Adjust the position of a jump label in  d40_probe() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-17 17:20 +0200
    [PATCH 12/24] ste_dma40: Rename jump labels in d40_dmaengine_init() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-17 17:30 +0200
    [PATCH 17/24] ste_dma40: Move an assignment in d40_prep_desc() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-17 17:30 +0200
    [PATCH 14/24] ste_dma40: One check less in d40_prep_sg() after error  detection SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-17 17:30 +0200
    [PATCH 16/24] ste_dma40: Rename a jump label in d40_prep_desc() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-17 17:30 +0200
    [PATCH 11/24] ste_dma40: Rename a jump label in d40_probe() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-17 17:30 +0200
    [PATCH 13/24] ste_dma40: Rename a jump label in  d40_alloc_chan_resources() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-17 17:30 +0200
    [PATCH 15/24] ste_dma40: Move two assignments in d40_prep_sg() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-17 17:30 +0200
    [PATCH 21/24] ste_dma40: Rename jump labels in d40_alloc_mask_set() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-17 17:40 +0200
    [PATCH 18/24] ste_dma40: Rename a jump label in d40_is_paused() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-17 17:40 +0200
    [PATCH 22/24] ste_dma40: Rename a jump label in dma_tasklet() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-17 17:40 +0200
    [PATCH 20/24] ste_dma40: Rename a jump label in d40_alloc_mask_free() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-17 17:40 +0200
    [PATCH 24/24] ste_dma40: Rename a jump label in d40_log_lli_to_lcxa() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-17 17:40 +0200
    [PATCH 19/24] ste_dma40: Rename a jump label in d40_free_dma() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-17 17:40 +0200
    [PATCH 23/24] ste_dma40: Rename a jump label in  __d40_execute_command_phy() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-17 17:40 +0200
    Re: [PATCH 00/24] ste_dma40: Fine-tuning for several function implementations Linus Walleij <linus.walleij@linaro.org> - 2016-09-23 11:50 +0200

Page 2 of 2 — ← Prev page 1 [2]

#1485563 — [PATCH 22/24] ste_dma40: Rename a jump label in dma_tasklet()

From: Markus Elfring <elfring@users.sourceforge.net>
Date: Sat, 17 Sep 2016 16:23:43 +0200

Adjust a jump label according to the current Linux coding style convention.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
 drivers/dma/ste_dma40.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/dma/ste_dma40.c b/drivers/dma/ste_dma40.c
index 4a2f39b..0082ae0 100644
--- a/drivers/dma/ste_dma40.c
+++ b/drivers/dma/ste_dma40.c
@@ -1606,7 +1606,7 @@ static void dma_tasklet(unsigned long data)
 		/* Check if we have reached here for cyclic job */
 		d40d = d40_first_active_get(d40c);
 		if (d40d == NULL || !d40d->cyclic)
-			goto err;
+			goto check_pending_tx;
 	}
 
 	if (!d40d->cyclic)
@@ -1648,8 +1648,7 @@ static void dma_tasklet(unsigned long data)
 		dmaengine_desc_callback_invoke(&cb, NULL);
 
 	return;
-
-err:
+ check_pending_tx:
 	/* Rescue manouver if receiving double interrupts */
 	if (d40c->pending_tx > 0)
 		d40c->pending_tx--;
-- 
2.10.0

[toc] | [prev] | [next] | [standalone]

#1485564 — [PATCH 20/24] ste_dma40: Rename a jump label in d40_alloc_mask_free()

From: Markus Elfring <elfring@users.sourceforge.net>
Date: Sat, 17 Sep 2016 16:10:41 +0200

Adjust a jump label according to the current Linux coding style convention.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
 drivers/dma/ste_dma40.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/dma/ste_dma40.c b/drivers/dma/ste_dma40.c
index 917b24a..fbe87a2 100644
--- a/drivers/dma/ste_dma40.c
+++ b/drivers/dma/ste_dma40.c
@@ -1829,7 +1829,7 @@ static bool d40_alloc_mask_free(struct d40_phy_res *phy, bool is_src,
 		phy->allocated_dst = D40_ALLOC_FREE;
 		phy->allocated_src = D40_ALLOC_FREE;
 		is_free = true;
-		goto out;
+		goto unlock;
 	}
 
 	/* Logical channel */
@@ -1845,8 +1845,7 @@ static bool d40_alloc_mask_free(struct d40_phy_res *phy, bool is_src,
 
 	is_free = ((phy->allocated_src | phy->allocated_dst) ==
 		   D40_ALLOC_FREE);
-
-out:
+ unlock:
 	spin_unlock_irqrestore(&phy->lock, flags);
 
 	return is_free;
-- 
2.10.0

[toc] | [prev] | [next] | [standalone]

#1485565 — [PATCH 24/24] ste_dma40: Rename a jump label in d40_log_lli_to_lcxa()

From: Markus Elfring <elfring@users.sourceforge.net>
Date: Sat, 17 Sep 2016 16:39:06 +0200

Adjust a jump label according to the current Linux coding style convention.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
 drivers/dma/ste_dma40.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/dma/ste_dma40.c b/drivers/dma/ste_dma40.c
index 01fe3a2..dcb26c6 100644
--- a/drivers/dma/ste_dma40.c
+++ b/drivers/dma/ste_dma40.c
@@ -874,7 +874,7 @@ static void d40_log_lli_to_lcxa(struct d40_chan *chan, struct d40_desc *desc)
 	}
 
 	if (curr_lcla < 0)
-		goto out;
+		goto set_current;
 
 	for (; lli_current < lli_len; lli_current++) {
 		unsigned int lcla_offset = chan->phy_chan->num * 1024 +
@@ -925,8 +925,7 @@ static void d40_log_lli_to_lcxa(struct d40_chan *chan, struct d40_desc *desc)
 			break;
 		}
 	}
-
-out:
+ set_current:
 	desc->lli_current = lli_current;
 }
 
-- 
2.10.0

[toc] | [prev] | [next] | [standalone]

#1485566 — [PATCH 19/24] ste_dma40: Rename a jump label in d40_free_dma()

From: Markus Elfring <elfring@users.sourceforge.net>
Date: Sat, 17 Sep 2016 16:04:46 +0200

Adjust a jump label according to the current Linux coding style convention.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
 drivers/dma/ste_dma40.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/dma/ste_dma40.c b/drivers/dma/ste_dma40.c
index d99241c..917b24a 100644
--- a/drivers/dma/ste_dma40.c
+++ b/drivers/dma/ste_dma40.c
@@ -2045,7 +2045,7 @@ static int d40_free_dma(struct d40_chan *d40c)
 	res = d40_channel_execute_command(d40c, D40_DMA_STOP);
 	if (res) {
 		chan_err(d40c, "stop failed\n");
-		goto out;
+		goto mark_last_busy;
 	}
 
 	d40_alloc_mask_free(phy, is_src, chan_is_logical(d40c) ? event : 0);
@@ -2063,8 +2063,7 @@ static int d40_free_dma(struct d40_chan *d40c)
 	d40c->busy = false;
 	d40c->phy_chan = NULL;
 	d40c->configured = false;
-out:
-
+ mark_last_busy:
 	pm_runtime_mark_last_busy(d40c->base->dev);
 	pm_runtime_put_autosuspend(d40c->base->dev);
 	return res;
-- 
2.10.0

[toc] | [prev] | [next] | [standalone]

#1485568 — [PATCH 23/24] ste_dma40: Rename a jump label in __d40_execute_command_phy()

From: Markus Elfring <elfring@users.sourceforge.net>
Date: Sat, 17 Sep 2016 16:28:54 +0200

Adjust a jump label according to the current Linux coding style convention.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
 drivers/dma/ste_dma40.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/dma/ste_dma40.c b/drivers/dma/ste_dma40.c
index 0082ae0..01fe3a2 100644
--- a/drivers/dma/ste_dma40.c
+++ b/drivers/dma/ste_dma40.c
@@ -1083,7 +1083,7 @@ static int __d40_execute_command_phy(struct d40_chan *d40c,
 			D40_CHAN_POS(d40c->phy_chan->num);
 
 		if (status == D40_DMA_SUSPENDED || status == D40_DMA_STOP)
-			goto done;
+			goto unlock;
 	}
 
 	wmask = 0xffffffff & ~(D40_CHAN_POS_MASK(d40c->phy_chan->num));
@@ -1119,7 +1119,7 @@ static int __d40_execute_command_phy(struct d40_chan *d40c,
 		}
 
 	}
-done:
+ unlock:
 	spin_unlock_irqrestore(&d40c->base->execmd_lock, flags);
 	return ret;
 }
-- 
2.10.0

[toc] | [prev] | [next] | [standalone]

#1489907 — Re: [PATCH 00/24] ste_dma40: Fine-tuning for several function implementations

On Sat, Sep 17, 2016 at 5:05 PM, SF Markus Elfring
<elfring@users.sourceforge.net> wrote:

> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Sat, 17 Sep 2016 16:56:56 +0200
>
> Several update suggestions were taken into account
> from static source code analysis.

All look very nice!

Reviewed-by: Linus Walleij <linus.walleij@linaro.org>

Vinod, please apply them all!

Yours,
Linus Walleij

[toc] | [prev] | [standalone]

Page 2 of 2 — ← Prev page 1 [2]

Back to top | Article view | linux.kernel

csiph-web