Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1483837 > unrolled thread
| Started by | Wei Yongjun <weiyj.lk@gmail.com> |
|---|---|
| First post | 2016-09-15 05:30 +0200 |
| Last post | 2016-09-18 21:10 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH -next] drm/sun4i: backend: remove redundant dev_err call in sun4i_backend_bind() Wei Yongjun <weiyj.lk@gmail.com> - 2016-09-15 05:30 +0200
Re: [PATCH -next] drm/sun4i: backend: remove redundant dev_err call in sun4i_backend_bind() Maxime Ripard <maxime.ripard@free-electrons.com> - 2016-09-18 21:10 +0200
| From | Wei Yongjun <weiyj.lk@gmail.com> |
|---|---|
| Date | 2016-09-15 05:30 +0200 |
| Subject | [PATCH -next] drm/sun4i: backend: remove redundant dev_err call in sun4i_backend_bind() |
| Message-ID | <shvx7-1uW-5@gated-at.bofh.it> |
From: Wei Yongjun <weiyongjun1@huawei.com>
There is a error message within devm_ioremap_resource
already, so remove the dev_err call to avoid redundant
error message.
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
drivers/gpu/drm/sun4i/sun4i_backend.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/sun4i/sun4i_backend.c b/drivers/gpu/drm/sun4i/sun4i_backend.c
index 91a7022..fcd4e91 100644
--- a/drivers/gpu/drm/sun4i/sun4i_backend.c
+++ b/drivers/gpu/drm/sun4i/sun4i_backend.c
@@ -288,10 +288,8 @@ static int sun4i_backend_bind(struct device *dev, struct device *master,
res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
regs = devm_ioremap_resource(dev, res);
- if (IS_ERR(regs)) {
- dev_err(dev, "Couldn't map the backend registers\n");
+ if (IS_ERR(regs))
return PTR_ERR(regs);
- }
backend->regs = devm_regmap_init_mmio(dev, regs,
&sun4i_backend_regmap_config);
[toc] | [next] | [standalone]
| From | Maxime Ripard <maxime.ripard@free-electrons.com> |
|---|---|
| Date | 2016-09-18 21:10 +0200 |
| Subject | Re: [PATCH -next] drm/sun4i: backend: remove redundant dev_err call in sun4i_backend_bind() |
| Message-ID | <siPDr-3BJ-5@gated-at.bofh.it> |
| In reply to | #1483837 |
[Multipart message — attachments visible in raw view] — view raw
On Thu, Sep 15, 2016 at 03:25:58AM +0000, Wei Yongjun wrote: > From: Wei Yongjun <weiyongjun1@huawei.com> > > There is a error message within devm_ioremap_resource > already, so remove the dev_err call to avoid redundant > error message. > > Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com> Queued, thanks! Maxime -- Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web