Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1485813 > unrolled thread

[PATCH] ARM: tegra: nyan: Enable GPU node and related supply

Started byPaul Kocialkowski <contact@paulk.fr>
First post2016-09-18 16:20 +0200
Last post2016-09-21 10:00 +0200
Articles 4 — 2 participants

Back to article view | Back to linux.kernel


Contents

  [PATCH] ARM: tegra: nyan: Enable GPU node and related supply Paul Kocialkowski <contact@paulk.fr> - 2016-09-18 16:20 +0200
    Re: [PATCH] ARM: tegra: nyan: Enable GPU node and related supply Jon Hunter <jonathanh@nvidia.com> - 2016-09-20 14:30 +0200
      Re: [PATCH] ARM: tegra: nyan: Enable GPU node and related supply Paul Kocialkowski <contact@paulk.fr> - 2016-09-20 20:20 +0200
        Re: [PATCH] ARM: tegra: nyan: Enable GPU node and related supply Jon Hunter <jonathanh@nvidia.com> - 2016-09-21 10:00 +0200

#1485813 — [PATCH] ARM: tegra: nyan: Enable GPU node and related supply

FromPaul Kocialkowski <contact@paulk.fr>
Date2016-09-18 16:20 +0200
Subject[PATCH] ARM: tegra: nyan: Enable GPU node and related supply
Message-ID<siL6N-IX-35@gated-at.bofh.it>
This enables the GPU node for tegra124 nyan boards, which is required to
get graphics acceleration with nouveau on these devices.

Signed-off-by: Paul Kocialkowski <contact@paulk.fr>
---
 arch/arm/boot/dts/tegra124-nyan.dtsi | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/tegra124-nyan.dtsi b/arch/arm/boot/dts/tegra124-nyan.dtsi
index dab9509..225ca77 100644
--- a/arch/arm/boot/dts/tegra124-nyan.dtsi
+++ b/arch/arm/boot/dts/tegra124-nyan.dtsi
@@ -42,6 +42,12 @@
 		};
 	};
 
+	gpu@0,57000000 {
+		status = "okay";
+
+		vdd-supply = <&vdd_gpu>;
+	};
+
 	serial@70006000 {
 		/* Debug connector on the bottom of the board near SD card. */
 		status = "okay";
@@ -214,7 +220,7 @@
 					regulator-always-on;
 				};
 
-				sd6 {
+				vdd_gpu: sd6 {
 					regulator-name = "+VDD_GPU_AP";
 					regulator-min-microvolt = <650000>;
 					regulator-max-microvolt = <1200000>;
-- 
2.9.3

[toc] | [next] | [standalone]


#1487288

FromJon Hunter <jonathanh@nvidia.com>
Date2016-09-20 14:30 +0200
Message-ID<sjsls-2V3-17@gated-at.bofh.it>
In reply to#1485813
On 18/09/16 15:13, Paul Kocialkowski wrote:
> This enables the GPU node for tegra124 nyan boards, which is required to
> get graphics acceleration with nouveau on these devices.
> 
> Signed-off-by: Paul Kocialkowski <contact@paulk.fr>
> ---
>  arch/arm/boot/dts/tegra124-nyan.dtsi | 8 +++++++-
>  1 file changed, 7 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/arm/boot/dts/tegra124-nyan.dtsi b/arch/arm/boot/dts/tegra124-nyan.dtsi
> index dab9509..225ca77 100644
> --- a/arch/arm/boot/dts/tegra124-nyan.dtsi
> +++ b/arch/arm/boot/dts/tegra124-nyan.dtsi
> @@ -42,6 +42,12 @@
>  		};
>  	};
>  
> +	gpu@0,57000000 {
> +		status = "okay";
> +
> +		vdd-supply = <&vdd_gpu>;
> +	};
> +
>  	serial@70006000 {
>  		/* Debug connector on the bottom of the board near SD card. */
>  		status = "okay";
> @@ -214,7 +220,7 @@
>  					regulator-always-on;
>  				};
>  
> -				sd6 {
> +				vdd_gpu: sd6 {
>  					regulator-name = "+VDD_GPU_AP";
>  					regulator-min-microvolt = <650000>;
>  					regulator-max-microvolt = <1200000>;
> 

Looks good to me. I see the following error when booting but looking at the
code appears to be benign. Thierry, Alex, is this normal/okay?

[    5.715181] nouveau 57000000.gpu: NVIDIA GK20A (0ea000a1)                                                                                            
[    5.720625] nouveau 57000000.gpu: imem: using IOMMU                                                                                                  
[    5.803694] nouveau 57000000.gpu: DRM: VRAM: 0 MiB                                                                                                   
[    5.808501] nouveau 57000000.gpu: DRM: GART: 1048576 MiB                                                                                             
[    5.816000] nouveau 57000000.gpu: DRM: failed to create ce channel, -22                                                                              
[    5.924140] nouveau 57000000.gpu: DRM: MM: using GRCE for buffer copies  

Cheers
Jon

-- 
nvpublic

[toc] | [prev] | [next] | [standalone]


#1487561

FromPaul Kocialkowski <contact@paulk.fr>
Date2016-09-20 20:20 +0200
Message-ID<sjxO9-6z2-15@gated-at.bofh.it>
In reply to#1487288

[Multipart message — attachments visible in raw view] — view raw

Le mardi 20 septembre 2016 à 13:24 +0100, Jon Hunter a écrit :
> On 18/09/16 15:13, Paul Kocialkowski wrote:
> > 
> > This enables the GPU node for tegra124 nyan boards, which is required to
> > get graphics acceleration with nouveau on these devices.
> > 
> > Signed-off-by: Paul Kocialkowski <contact@paulk.fr>
> > ---
> >  arch/arm/boot/dts/tegra124-nyan.dtsi | 8 +++++++-
> >  1 file changed, 7 insertions(+), 1 deletion(-)
> > 
> > diff --git a/arch/arm/boot/dts/tegra124-nyan.dtsi
> > b/arch/arm/boot/dts/tegra124-nyan.dtsi
> > index dab9509..225ca77 100644
> > --- a/arch/arm/boot/dts/tegra124-nyan.dtsi
> > +++ b/arch/arm/boot/dts/tegra124-nyan.dtsi
> > @@ -42,6 +42,12 @@
> >  		};
> >  	};
> >  
> > +	gpu@0,57000000 {
> > +		status = "okay";
> > +
> > +		vdd-supply = <&vdd_gpu>;
> > +	};
> > +
> >  	serial@70006000 {
> >  		/* Debug connector on the bottom of the board near SD card.
> > */
> >  		status = "okay";
> > @@ -214,7 +220,7 @@
> >  					regulator-always-on;
> >  				};
> >  
> > -				sd6 {
> > +				vdd_gpu: sd6 {
> >  					regulator-name = "+VDD_GPU_AP";
> >  					regulator-min-microvolt = <650000>;
> >  					regulator-max-microvolt =
> > <1200000>;
> > 
> 
> Looks good to me. I see the following error when booting but looking at the
> code appears to be benign. Thierry, Alex, is this normal/okay?

I have the same messages and asked Alexandre about them the other day. He told
me that it looks normal.

> [    5.715181] nouveau 57000000.gpu: NVIDIA GK20A
> (0ea000a1)                                                                    
>                         
> [    5.720625] nouveau 57000000.gpu: imem: using
> IOMMU                                                                         
>                          
> [    5.803694] nouveau 57000000.gpu: DRM: VRAM: 0
> MiB                                                                           
>                         
> [    5.808501] nouveau 57000000.gpu: DRM: GART: 1048576
> MiB                                                                           
>                   
> [    5.816000] nouveau 57000000.gpu: DRM: failed to create ce channel,
> -22                                                                           
>    
> [    5.924140] nouveau 57000000.gpu: DRM: MM: using GRCE for buffer copies  
> 
> Cheers
> Jon
> 
-- 
Paul Kocialkowski, developer of low-level free software for embedded devices

Website: https://www.paulk.fr/
Coding blog: https://code.paulk.fr/
Git repositories: https://git.paulk.fr/ https://git.code.paulk.fr/

[toc] | [prev] | [next] | [standalone]


#1487879

FromJon Hunter <jonathanh@nvidia.com>
Date2016-09-21 10:00 +0200
Message-ID<sjKBH-6bG-9@gated-at.bofh.it>
In reply to#1487561
On 20/09/16 19:17, Paul Kocialkowski wrote:
> * PGP Signed by an unknown key
> 
> Le mardi 20 septembre 2016 à 13:24 +0100, Jon Hunter a écrit :
>> On 18/09/16 15:13, Paul Kocialkowski wrote:
>>>
>>> This enables the GPU node for tegra124 nyan boards, which is required to
>>> get graphics acceleration with nouveau on these devices.
>>>
>>> Signed-off-by: Paul Kocialkowski <contact@paulk.fr>
>>> ---
>>>  arch/arm/boot/dts/tegra124-nyan.dtsi | 8 +++++++-
>>>  1 file changed, 7 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/arch/arm/boot/dts/tegra124-nyan.dtsi
>>> b/arch/arm/boot/dts/tegra124-nyan.dtsi
>>> index dab9509..225ca77 100644
>>> --- a/arch/arm/boot/dts/tegra124-nyan.dtsi
>>> +++ b/arch/arm/boot/dts/tegra124-nyan.dtsi
>>> @@ -42,6 +42,12 @@
>>>  		};
>>>  	};
>>>  
>>> +	gpu@0,57000000 {
>>> +		status = "okay";
>>> +
>>> +		vdd-supply = <&vdd_gpu>;
>>> +	};
>>> +
>>>  	serial@70006000 {
>>>  		/* Debug connector on the bottom of the board near SD card.
>>> */
>>>  		status = "okay";
>>> @@ -214,7 +220,7 @@
>>>  					regulator-always-on;
>>>  				};
>>>  
>>> -				sd6 {
>>> +				vdd_gpu: sd6 {
>>>  					regulator-name = "+VDD_GPU_AP";
>>>  					regulator-min-microvolt = <650000>;
>>>  					regulator-max-microvolt =
>>> <1200000>;
>>>
>>
>> Looks good to me. I see the following error when booting but looking at the
>> code appears to be benign. Thierry, Alex, is this normal/okay?
> 
> I have the same messages and asked Alexandre about them the other day. He told
> me that it looks normal.

Ok great. Hopefully, Alex can ACK then.

Cheers
Jon

-- 
nvpublic

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web