Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1485202 > unrolled thread
| Started by | Colin King <colin.king@canonical.com> |
|---|---|
| First post | 2016-09-16 19:40 +0200 |
| Last post | 2016-09-16 23:50 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH] ASoC: samsung: add missing \n to end of pr_err messages Colin King <colin.king@canonical.com> - 2016-09-16 19:40 +0200
Re: [PATCH] ASoC: samsung: add missing \n to end of pr_err messages Krzysztof Kozlowski <krzk@kernel.org> - 2016-09-16 23:50 +0200
| From | Colin King <colin.king@canonical.com> |
|---|---|
| Date | 2016-09-16 19:40 +0200 |
| Subject | [PATCH] ASoC: samsung: add missing \n to end of pr_err messages |
| Message-ID | <si5hf-7NI-15@gated-at.bofh.it> |
From: Colin Ian King <colin.king@canonical.com>
Trival fix, some pr_err messages are missing a \n, so add it.
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
sound/soc/samsung/ac97.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/sound/soc/samsung/ac97.c b/sound/soc/samsung/ac97.c
index 5eafb66..97d6700 100644
--- a/sound/soc/samsung/ac97.c
+++ b/sound/soc/samsung/ac97.c
@@ -74,7 +74,7 @@ static void s3c_ac97_activate(struct snd_ac97 *ac97)
writel(ac_glbctrl, s3c_ac97.regs + S3C_AC97_GLBCTRL);
if (!wait_for_completion_timeout(&s3c_ac97.done, HZ))
- pr_err("AC97: Unable to activate!");
+ pr_err("AC97: Unable to activate!\n");
}
static unsigned short s3c_ac97_read(struct snd_ac97 *ac97,
@@ -100,7 +100,7 @@ static unsigned short s3c_ac97_read(struct snd_ac97 *ac97,
writel(ac_glbctrl, s3c_ac97.regs + S3C_AC97_GLBCTRL);
if (!wait_for_completion_timeout(&s3c_ac97.done, HZ))
- pr_err("AC97: Unable to read!");
+ pr_err("AC97: Unable to read!\n");
stat = readl(s3c_ac97.regs + S3C_AC97_STAT);
addr = (stat >> 16) & 0x7f;
@@ -137,7 +137,7 @@ static void s3c_ac97_write(struct snd_ac97 *ac97, unsigned short reg,
writel(ac_glbctrl, s3c_ac97.regs + S3C_AC97_GLBCTRL);
if (!wait_for_completion_timeout(&s3c_ac97.done, HZ))
- pr_err("AC97: Unable to write!");
+ pr_err("AC97: Unable to write!\n");
ac_codec_cmd = readl(s3c_ac97.regs + S3C_AC97_CODEC_CMD);
ac_codec_cmd |= S3C_AC97_CODEC_CMD_READ;
--
2.9.3
[toc] | [next] | [standalone]
| From | Krzysztof Kozlowski <krzk@kernel.org> |
|---|---|
| Date | 2016-09-16 23:50 +0200 |
| Message-ID | <si9bb-1VW-9@gated-at.bofh.it> |
| In reply to | #1485202 |
On Fri, Sep 16, 2016 at 06:30:53PM +0100, Colin King wrote: > From: Colin Ian King <colin.king@canonical.com> > > Trival fix, some pr_err messages are missing a \n, so add it. > > Signed-off-by: Colin Ian King <colin.king@canonical.com> > --- > sound/soc/samsung/ac97.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) Hi, Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org> Also probably converting everything to dev_* would make sense as well but it is not trivial. Best regards, Krzysztof
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web