Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1485066 > unrolled thread

[PATCH 0/7] openrisc: Misc fixes from backlog

Back to article view | Back to linux.kernel

Contents

  [PATCH 0/7] openrisc: Misc fixes from backlog Stafford Horne <shorne@gmail.com> - 2016-09-16 16:50 +0200
    [PATCH 6/7] openrisc: add SMP and NR_CPUS Kconfig options Stafford Horne <shorne@gmail.com> - 2016-09-16 16:50 +0200
      Re: [PATCH 6/7] openrisc: add SMP and NR_CPUS Kconfig options Jonas Bonn <jonas@southpole.se> - 2016-09-19 16:40 +0200
        Re: [PATCH 6/7] openrisc: add SMP and NR_CPUS Kconfig options Stafford Horne <shorne@gmail.com> - 2016-09-19 17:00 +0200
    [PATCH 3/7] openrisc: restore call-saved regs on sigreturn Stafford Horne <shorne@gmail.com> - 2016-09-16 16:50 +0200
      Re: [PATCH 3/7] openrisc: restore call-saved regs on sigreturn Jonas Bonn <jonas@southpole.se> - 2016-09-19 16:50 +0200
        Re: [PATCH 3/7] openrisc: restore call-saved regs on sigreturn Stafford Horne <shorne@gmail.com> - 2016-09-19 17:00 +0200
    [PATCH 7/7] openrisc: remove the redundant of_platform_populate Stafford Horne <shorne@gmail.com> - 2016-09-16 16:50 +0200
      Re: [PATCH 7/7] openrisc: remove the redundant of_platform_populate Jonas Bonn <jonas@southpole.se> - 2016-09-19 16:40 +0200
        Re: [PATCH 7/7] openrisc: remove the redundant  of_platform_populate Stafford Horne <shorne@gmail.com> - 2016-09-19 17:00 +0200
        Re: [PATCH 7/7] openrisc: remove the redundant of_platform_populate Rob Herring <robh@kernel.org> - 2016-09-19 18:20 +0200
    [PATCH 5/7] openrisc: Support both old (or32) and new (or1k) toolchain Stafford Horne <shorne@gmail.com> - 2016-09-16 16:50 +0200
      Re: [PATCH 5/7] openrisc: Support both old (or32) and new (or1k)  toolchain Guenter Roeck <linux@roeck-us.net> - 2016-09-18 17:30 +0200
        Re: [PATCH 5/7] openrisc: Support both old (or32) and new (or1k)  toolchain Stafford Horne <shorne@gmail.com> - 2016-09-19 08:10 +0200
          Re: [PATCH 5/7] openrisc: Support both old (or32) and new (or1k)  toolchain Guenter Roeck <linux@roeck-us.net> - 2016-09-19 09:20 +0200
            Re: [PATCH 5/7] openrisc: Support both old (or32) and new (or1k)  toolchain Stafford Horne <shorne@gmail.com> - 2016-09-19 11:20 +0200
              Re: [PATCH 5/7] openrisc: Support both old (or32) and new (or1k)  toolchain Guenter Roeck <linux@roeck-us.net> - 2016-09-19 15:20 +0200
                Re: [PATCH 5/7] openrisc: Support both old (or32) and new (or1k)  toolchain Stafford Horne <shorne@gmail.com> - 2016-09-19 16:10 +0200
                  Re: [PATCH 5/7] openrisc: Support both old (or32) and new (or1k)  toolchain Jonas Bonn <jonas@southpole.se> - 2016-09-19 16:40 +0200
                    Re: [PATCH 5/7] openrisc: Support both old (or32) and new (or1k)  toolchain Guenter Roeck <linux@roeck-us.net> - 2016-09-19 17:00 +0200
                    Re: [PATCH 5/7] openrisc: Support both old (or32) and new (or1k)  toolchain Stafford Horne <shorne@gmail.com> - 2016-09-19 17:20 +0200
                  Re: [PATCH 5/7] openrisc: Support both old (or32) and new (or1k)  toolchain Guenter Roeck <linux@roeck-us.net> - 2016-09-19 16:50 +0200
                    Re: [PATCH 5/7] openrisc: Support both old (or32) and new (or1k)  toolchain Stafford Horne <shorne@gmail.com> - 2016-09-20 12:10 +0200
    [PATCH 1/7] Apply transparent_union attribute to union semun Stafford Horne <shorne@gmail.com> - 2016-09-16 16:50 +0200
      Re: [PATCH 1/7] Apply transparent_union attribute to union semun kbuild test robot <lkp@intel.com> - 2016-09-16 18:00 +0200
      Re: [PATCH 1/7] Apply transparent_union attribute to union semun kbuild test robot <lkp@intel.com> - 2016-09-17 01:40 +0200
        Re: [PATCH 1/7] Apply transparent_union attribute to union semun Stafford Horne <shorne@gmail.com> - 2016-09-17 02:10 +0200
      Re: [PATCH 1/7] Apply transparent_union attribute to union semun Stafford Horne <shorne@gmail.com> - 2016-09-19 16:50 +0200
      Re: [PATCH 1/7] Apply transparent_union attribute to union semun Jonas Bonn <jonas@southpole.se> - 2016-09-19 16:50 +0200
    Re: [PATCH 0/7] openrisc: Misc fixes from backlog Stafford Horne <shorne@gmail.com> - 2016-09-16 17:00 +0200

Page 1 of 2  [1] 2  Next page →

#1485066 — [PATCH 0/7] openrisc: Misc fixes from backlog

Hello,

This patch is a small set of fixes from the openrisc backlog. These
changes fix several issues with the openrisc build on modern tool chains
and address other issues which have cropped up as the kernel as it is
being used on newer hardware.

Please consider for merge.

On-the-other-hand

The openrisc project has been missing a kernel maintainer
for some time now. Currently listed in MAINTAINERS is Jonas
and a website that no longer exists.


Some mail threads from Jonas
https://lkml.org/lkml/2015/5/13/469 - mail from Jonas mentioning 
                                      he is no longer able to maintain 
https://lkml.org/lkml/2015/6/11/426 - mail from Jonas mentioning stefan 
                                      is to be the new maintainer

Ideally stefan kristiansson would become the maintainer but he 
does not have a PGP key signed by kernel maintainers.  Also, he
does not seem to have much time recently.

We would like some help on how to proceed, options:
 - Someone take these patches into a branch that will be pulled
   by linus? I can work to maintain the patch queue for openrisc.
 - I can work to get a my PGP key signed and send git pull requests
   to linus?

Regards,
  Stafford


Christian Svensson (1):
  openrisc: Add thread-local storage (TLS) support

Guenter Roeck (1):
  openrisc: Support both old (or32) and new (or1k) toolchain

Jonas Bonn (2):
  Apply transparent_union attribute to union semun
  openrisc: restore call-saved regs on sigreturn

Rob Herring (1):
  openrisc: remove the redundant of_platform_populate

Stefan Kristiansson (2):
  openrisc: fix PTRS_PER_PGD define
  openrisc: add SMP and NR_CPUS Kconfig options

 arch/openrisc/Kconfig               | 14 ++++++++++++++
 arch/openrisc/include/asm/pgtable.h |  2 +-
 arch/openrisc/kernel/entry.S        | 10 +++++++++-
 arch/openrisc/kernel/process.c      | 13 +++++++++++++
 arch/openrisc/kernel/setup.c        | 10 ----------
 arch/openrisc/kernel/vmlinux.lds.S  |  8 +++++++-
 arch/openrisc/mm/init.c             |  2 +-
 include/uapi/linux/sem.h            |  2 +-
 8 files changed, 46 insertions(+), 15 deletions(-)

-- 
2.7.4

[toc] | [next] | [standalone]

#1485067 — [PATCH 6/7] openrisc: add SMP and NR_CPUS Kconfig options

From: Stefan Kristiansson <stefan.kristiansson@saunalahti.fi>

Signed-off-by: Stefan Kristiansson <stefan.kristiansson@saunalahti.fi>
Signed-off-by: Stafford Horne <shorne@gmail.com>
---
 arch/openrisc/Kconfig | 14 ++++++++++++++
 1 file changed, 14 insertions(+)

diff --git a/arch/openrisc/Kconfig b/arch/openrisc/Kconfig
index 489e7f9..2bcf8c3 100644
--- a/arch/openrisc/Kconfig
+++ b/arch/openrisc/Kconfig
@@ -98,6 +98,20 @@ config OPENRISC_HAVE_INST_DIV
 	  Select this if your implementation has a hardware divide instruction
 endmenu
 
+config NR_CPUS
+	int "Maximum number of CPUs (2-32)"
+	range 2 32
+	depends on SMP
+	default "2"
+
+config SMP
+	bool "Symmetric Multi-Processing support"
+	help
+	  This enables support for systems with more than one CPU. If you have
+	  a system with only one CPU, say N. If you have a system with more
+	  than one CPU, say Y.
+
+	  If you don't know what to do here, say N.
 
 source kernel/Kconfig.hz
 source kernel/Kconfig.preempt
-- 
2.7.4

[toc] | [prev] | [next] | [standalone]

#1486548 — Re: [PATCH 6/7] openrisc: add SMP and NR_CPUS Kconfig options

On 09/16/2016 04:43 PM, Stafford Horne wrote:
> From: Stefan Kristiansson <stefan.kristiansson@saunalahti.fi>

OpenRISC was not an SMP architecture last I looked... did the relevant 
spec updates get made?  If not, NAK.

The issue is, the OpenRISC architecture shouldn't be a moving target 
defined by what the kernel supports... there's a spec that the kernel 
conforms to.  This is important for the (few) real users of the 
architecture.

/Jonas

> Signed-off-by: Stefan Kristiansson <stefan.kristiansson@saunalahti.fi>
> Signed-off-by: Stafford Horne <shorne@gmail.com>
> ---
>   arch/openrisc/Kconfig | 14 ++++++++++++++
>   1 file changed, 14 insertions(+)
>
> diff --git a/arch/openrisc/Kconfig b/arch/openrisc/Kconfig
> index 489e7f9..2bcf8c3 100644
> --- a/arch/openrisc/Kconfig
> +++ b/arch/openrisc/Kconfig
> @@ -98,6 +98,20 @@ config OPENRISC_HAVE_INST_DIV
>   	  Select this if your implementation has a hardware divide instruction
>   endmenu
>   
> +config NR_CPUS
> +	int "Maximum number of CPUs (2-32)"
> +	range 2 32
> +	depends on SMP
> +	default "2"
> +
> +config SMP
> +	bool "Symmetric Multi-Processing support"
> +	help
> +	  This enables support for systems with more than one CPU. If you have
> +	  a system with only one CPU, say N. If you have a system with more
> +	  than one CPU, say Y.
> +
> +	  If you don't know what to do here, say N.
>   
>   source kernel/Kconfig.hz
>   source kernel/Kconfig.preempt

[toc] | [prev] | [next] | [standalone]

#1486572 — Re: [PATCH 6/7] openrisc: add SMP and NR_CPUS Kconfig options

On Mon, 19 Sep 2016, Jonas Bonn wrote:

> On 09/16/2016 04:43 PM, Stafford Horne wrote:
>>  From: Stefan Kristiansson <stefan.kristiansson@saunalahti.fi>
>
> OpenRISC was not an SMP architecture last I looked... did the relevant spec 
> updates get made?  If not, NAK.
>
> The issue is, the OpenRISC architecture shouldn't be a moving target defined 
> by what the kernel supports... there's a spec that the kernel conforms to. 
> This is important for the (few) real users of the architecture.

Hi Jonas,
I actually just added these patches to get the kernel to build without 
warnings as it seems the build system now depends on NR_CPUS and SMP.

However, I think think they should be exposed as options. I will rework 
this patch or look at my build config so these are not required to be 
exposed as options.

As you mention SMP is not in the spec, but Stefan has put together an SMP 
hardware model and ported the kernel to it. Which is where this patch came 
from.

-Stafford

>>  Signed-off-by: Stefan Kristiansson <stefan.kristiansson@saunalahti.fi>
>>  Signed-off-by: Stafford Horne <shorne@gmail.com>
>>  ---
>>    arch/openrisc/Kconfig | 14 ++++++++++++++
>>    1 file changed, 14 insertions(+)
>>
>>  diff --git a/arch/openrisc/Kconfig b/arch/openrisc/Kconfig
>>  index 489e7f9..2bcf8c3 100644
>>  --- a/arch/openrisc/Kconfig
>>  +++ b/arch/openrisc/Kconfig
>>  @@ -98,6 +98,20 @@ config OPENRISC_HAVE_INST_DIV
>>    	  Select this if your implementation has a hardware divide
>>    instruction
>>    endmenu
>>
>>  +config NR_CPUS
>>  +	int "Maximum number of CPUs (2-32)"
>>  +	range 2 32
>>  +	depends on SMP
>>  +	default "2"
>>  +
>>  +config SMP
>>  +	bool "Symmetric Multi-Processing support"
>>  +	help
>>  +	  This enables support for systems with more than one CPU. If you
>>  have
>>  +	  a system with only one CPU, say N. If you have a system with more
>>  +	  than one CPU, say Y.
>>  +
>>  +	  If you don't know what to do here, say N.
>>
>>    source kernel/Kconfig.hz
>>    source kernel/Kconfig.preempt
>
>

[toc] | [prev] | [next] | [standalone]

#1485071 — [PATCH 3/7] openrisc: restore call-saved regs on sigreturn

From: Jonas Bonn <jonas@southpole.se>

Return to userspace via _resume_userspace instead of via syscall return
path for the rt_sigreturn syscall.

I'll rework this comment more later, but this patch needs testing.

Old comment from previous patch:

The sigreturn syscall is more like a context switch than a function call;
it entails a return from one context (the signal handler) to another
(the process in question).  For a context switch like this there are
effectively no call-saved regs that remain constant across the transition.

This patch restores the call-saved regs from pt_regs before returning from
the syscall, effectively restoring the context that the process had before
being interrupted by the signal handler.  Restoring the call-saved regs
in this way allows us to return to userspace via the usual syscall fast
path.

Reported-by: Sebastian Macke <sebastian@macke.de>
Signed-off-by: Jonas Bonn <jonas@southpole.se>
Signed-off-by: Stafford Horne <shorne@gmail.com>
---
 arch/openrisc/kernel/entry.S | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)

diff --git a/arch/openrisc/kernel/entry.S b/arch/openrisc/kernel/entry.S
index fec8bf9..572d223 100644
--- a/arch/openrisc/kernel/entry.S
+++ b/arch/openrisc/kernel/entry.S
@@ -1101,8 +1101,16 @@ ENTRY(__sys_fork)
 	 l.addi	r3,r1,0
 
 ENTRY(sys_rt_sigreturn)
-	l.j	_sys_rt_sigreturn
+	l.jal	_sys_rt_sigreturn
 	 l.addi	r3,r1,0
+	l.sfne	r30,r0
+	l.bnf	_no_syscall_trace
+	 l.nop
+	l.jal	do_syscall_trace_leave
+	 l.addi	r3,r1,0
+_no_syscall_trace:
+	l.j	_resume_userspace
+	 l.nop
 
 /* This is a catch-all syscall for atomic instructions for the OpenRISC 1000.
  * The functions takes a variable number of parameters depending on which
-- 
2.7.4

[toc] | [prev] | [next] | [standalone]

#1486560 — Re: [PATCH 3/7] openrisc: restore call-saved regs on sigreturn

On 09/16/2016 04:43 PM, Stafford Horne wrote:
> From: Jonas Bonn <jonas@southpole.se>
>
> Return to userspace via _resume_userspace instead of via syscall return
> path for the rt_sigreturn syscall.
>
> I'll rework this comment more later, but this patch needs testing.

This whole patch was reworked later... what happened to that work? I 
recall it being posted for testing without feedback...

In any case, the patch comment needs cleaning up.

/Jonas

>
> Old comment from previous patch:
>
> The sigreturn syscall is more like a context switch than a function call;
> it entails a return from one context (the signal handler) to another
> (the process in question).  For a context switch like this there are
> effectively no call-saved regs that remain constant across the transition.
>
> This patch restores the call-saved regs from pt_regs before returning from
> the syscall, effectively restoring the context that the process had before
> being interrupted by the signal handler.  Restoring the call-saved regs
> in this way allows us to return to userspace via the usual syscall fast
> path.
>
> Reported-by: Sebastian Macke <sebastian@macke.de>
> Signed-off-by: Jonas Bonn <jonas@southpole.se>
> Signed-off-by: Stafford Horne <shorne@gmail.com>
> ---
>   arch/openrisc/kernel/entry.S | 10 +++++++++-
>   1 file changed, 9 insertions(+), 1 deletion(-)
>
> diff --git a/arch/openrisc/kernel/entry.S b/arch/openrisc/kernel/entry.S
> index fec8bf9..572d223 100644
> --- a/arch/openrisc/kernel/entry.S
> +++ b/arch/openrisc/kernel/entry.S
> @@ -1101,8 +1101,16 @@ ENTRY(__sys_fork)
>   	 l.addi	r3,r1,0
>   
>   ENTRY(sys_rt_sigreturn)
> -	l.j	_sys_rt_sigreturn
> +	l.jal	_sys_rt_sigreturn
>   	 l.addi	r3,r1,0
> +	l.sfne	r30,r0
> +	l.bnf	_no_syscall_trace
> +	 l.nop
> +	l.jal	do_syscall_trace_leave
> +	 l.addi	r3,r1,0
> +_no_syscall_trace:
> +	l.j	_resume_userspace
> +	 l.nop
>   
>   /* This is a catch-all syscall for atomic instructions for the OpenRISC 1000.
>    * The functions takes a variable number of parameters depending on which

[toc] | [prev] | [next] | [standalone]

#1486576 — Re: [PATCH 3/7] openrisc: restore call-saved regs on sigreturn

On Mon, 19 Sep 2016, Jonas Bonn wrote:

> On 09/16/2016 04:43 PM, Stafford Horne wrote:
>>  From: Jonas Bonn <jonas@southpole.se>
>>
>>  Return to userspace via _resume_userspace instead of via syscall return
>>  path for the rt_sigreturn syscall.
>>
>>  I'll rework this comment more later, but this patch needs testing.
>
> This whole patch was reworked later... what happened to that work? I recall 
> it being posted for testing without feedback...
>
> In any case, the patch comment needs cleaning up.

Hi Jonas,
When working through the changelogs to pull out these patches I didnt find 
anything more recent.  However, I did only notice the commit message 
needed cleanup after posting the patch set.  It was on my todo list to 
clean it up.

I will have another look for a later patch, I didnt find at first. But 
thanks for the info.

-Stafford

>>
>>  Old comment from previous patch:
>>
>>  The sigreturn syscall is more like a context switch than a function call;
>>  it entails a return from one context (the signal handler) to another
>>  (the process in question).  For a context switch like this there are
>>  effectively no call-saved regs that remain constant across the transition.
>>
>>  This patch restores the call-saved regs from pt_regs before returning from
>>  the syscall, effectively restoring the context that the process had before
>>  being interrupted by the signal handler.  Restoring the call-saved regs
>>  in this way allows us to return to userspace via the usual syscall fast
>>  path.
>>
>>  Reported-by: Sebastian Macke <sebastian@macke.de>
>>  Signed-off-by: Jonas Bonn <jonas@southpole.se>
>>  Signed-off-by: Stafford Horne <shorne@gmail.com>
>>  ---
>>    arch/openrisc/kernel/entry.S | 10 +++++++++-
>>    1 file changed, 9 insertions(+), 1 deletion(-)
>>
>>  diff --git a/arch/openrisc/kernel/entry.S b/arch/openrisc/kernel/entry.S
>>  index fec8bf9..572d223 100644
>>  --- a/arch/openrisc/kernel/entry.S
>>  +++ b/arch/openrisc/kernel/entry.S
>>  @@ -1101,8 +1101,16 @@ ENTRY(__sys_fork)
>>      l.addi	r3,r1,0
>>
>>    ENTRY(sys_rt_sigreturn)
>>  -	l.j	_sys_rt_sigreturn
>>  +	l.jal	_sys_rt_sigreturn
>>    	 l.addi	r3,r1,0
>>  +	l.sfne	r30,r0
>>  +	l.bnf	_no_syscall_trace
>>  +	 l.nop
>>  +	l.jal	do_syscall_trace_leave
>>  +	 l.addi	r3,r1,0
>>  +_no_syscall_trace:
>>  +	l.j	_resume_userspace
>>  +	 l.nop
>>
>>    /* This is a catch-all syscall for atomic instructions for the OpenRISC
>>    1000.
>>     * The functions takes a variable number of parameters depending on
>>     which
>
>

[toc] | [prev] | [next] | [standalone]

#1485073 — [PATCH 7/7] openrisc: remove the redundant of_platform_populate

From: Rob Herring <robh@kernel.org>

The of_platform_populate call in the openrisc arch code is now redundant
as the DT core provides a default call. Openrisc has a NULL match table
which means only top level nodes with compatible strings will have
devices creates. The default version will also descend nodes in the
match table such as "simple-bus" which should be fine as openrisc
doesn't have any of these (though it is preferred that memory-mapped
peripherals be grouped under a bus node(s)).

Signed-off-by: Rob Herring <robh@kernel.org>
Cc: Jonas Bonn <jonas@southpole.se>
Signed-off-by: Stafford Horne <shorne@gmail.com>
---
 arch/openrisc/kernel/setup.c | 10 ----------
 1 file changed, 10 deletions(-)

diff --git a/arch/openrisc/kernel/setup.c b/arch/openrisc/kernel/setup.c
index b4ed8b3..d2f78cf 100644
--- a/arch/openrisc/kernel/setup.c
+++ b/arch/openrisc/kernel/setup.c
@@ -38,7 +38,6 @@
 #include <linux/of.h>
 #include <linux/memblock.h>
 #include <linux/device.h>
-#include <linux/of_platform.h>
 
 #include <asm/sections.h>
 #include <asm/segment.h>
@@ -219,15 +218,6 @@ void __init or32_early_setup(void *fdt)
 	early_init_devtree(fdt);
 }
 
-static int __init openrisc_device_probe(void)
-{
-	of_platform_populate(NULL, NULL, NULL, NULL);
-
-	return 0;
-}
-
-device_initcall(openrisc_device_probe);
-
 static inline unsigned long extract_value_bits(unsigned long reg,
 					       short bit_nr, short width)
 {
-- 
2.7.4

[toc] | [prev] | [next] | [standalone]

#1486542 — Re: [PATCH 7/7] openrisc: remove the redundant of_platform_populate

On 09/16/2016 04:43 PM, Stafford Horne wrote:
> From: Rob Herring <robh@kernel.org>
>
> The of_platform_populate call in the openrisc arch code is now redundant
> as the DT core provides a default call. Openrisc has a NULL match table
> which means only top level nodes with compatible strings will have
> devices creates. The default version will also descend nodes in the
> match table such as "simple-bus" which should be fine as openrisc
> doesn't have any of these (though it is preferred that memory-mapped
> peripherals be grouped under a bus node(s)).
>
> Signed-off-by: Rob Herring <robh@kernel.org>
> Cc: Jonas Bonn <jonas@southpole.se>
> Signed-off-by: Stafford Horne <shorne@gmail.com>

Yes, this is fine, but trivial/generic stuff like this doesn't really 
need to go via the OpenRISC repo, anyway.

/Jonas

> ---
>   arch/openrisc/kernel/setup.c | 10 ----------
>   1 file changed, 10 deletions(-)
>
> diff --git a/arch/openrisc/kernel/setup.c b/arch/openrisc/kernel/setup.c
> index b4ed8b3..d2f78cf 100644
> --- a/arch/openrisc/kernel/setup.c
> +++ b/arch/openrisc/kernel/setup.c
> @@ -38,7 +38,6 @@
>   #include <linux/of.h>
>   #include <linux/memblock.h>
>   #include <linux/device.h>
> -#include <linux/of_platform.h>
>   
>   #include <asm/sections.h>
>   #include <asm/segment.h>
> @@ -219,15 +218,6 @@ void __init or32_early_setup(void *fdt)
>   	early_init_devtree(fdt);
>   }
>   
> -static int __init openrisc_device_probe(void)
> -{
> -	of_platform_populate(NULL, NULL, NULL, NULL);
> -
> -	return 0;
> -}
> -
> -device_initcall(openrisc_device_probe);
> -
>   static inline unsigned long extract_value_bits(unsigned long reg,
>   					       short bit_nr, short width)
>   {

[toc] | [prev] | [next] | [standalone]

#1486574 — Re: [PATCH 7/7] openrisc: remove the redundant of_platform_populate

On Mon, 19 Sep 2016, Jonas Bonn wrote:

> On 09/16/2016 04:43 PM, Stafford Horne wrote:
>>  From: Rob Herring <robh@kernel.org>
>>
>>  The of_platform_populate call in the openrisc arch code is now redundant
>>  as the DT core provides a default call. Openrisc has a NULL match table
>>  which means only top level nodes with compatible strings will have
>>  devices creates. The default version will also descend nodes in the
>>  match table such as "simple-bus" which should be fine as openrisc
>>  doesn't have any of these (though it is preferred that memory-mapped
>>  peripherals be grouped under a bus node(s)).
>>
>>  Signed-off-by: Rob Herring <robh@kernel.org>
>>  Cc: Jonas Bonn <jonas@southpole.se>
>>  Signed-off-by: Stafford Horne <shorne@gmail.com>
>
> Yes, this is fine, but trivial/generic stuff like this doesn't really need to 
> go via the OpenRISC repo, anyway.

That's right, however I didnt see anyone pick it up so I included it here.

>>  ---
>>    arch/openrisc/kernel/setup.c | 10 ----------
>>    1 file changed, 10 deletions(-)
>>
>>  diff --git a/arch/openrisc/kernel/setup.c b/arch/openrisc/kernel/setup.c
>>  index b4ed8b3..d2f78cf 100644
>>  --- a/arch/openrisc/kernel/setup.c
>>  +++ b/arch/openrisc/kernel/setup.c
>>  @@ -38,7 +38,6 @@
>>    #include <linux/of.h>
>>    #include <linux/memblock.h>
>>    #include <linux/device.h>
>>  -#include <linux/of_platform.h>
>>
>>    #include <asm/sections.h>
>>    #include <asm/segment.h>
>>  @@ -219,15 +218,6 @@ void __init or32_early_setup(void *fdt)
>>    	early_init_devtree(fdt);
>>    }
>>
>>  -static int __init openrisc_device_probe(void)
>>  -{
>>  -	of_platform_populate(NULL, NULL, NULL, NULL);
>>  -
>>  -	return 0;
>>  -}
>>  -
>>  -device_initcall(openrisc_device_probe);
>>  -
>>    static inline unsigned long extract_value_bits(unsigned long reg,
>>    					       short bit_nr, short width)
>>    {
>
>

[toc] | [prev] | [next] | [standalone]

#1486642 — Re: [PATCH 7/7] openrisc: remove the redundant of_platform_populate

On Mon, Sep 19, 2016 at 9:32 AM, Jonas Bonn <jonas@southpole.se> wrote:
> On 09/16/2016 04:43 PM, Stafford Horne wrote:
>>
>> From: Rob Herring <robh@kernel.org>
>>
>> The of_platform_populate call in the openrisc arch code is now redundant
>> as the DT core provides a default call. Openrisc has a NULL match table
>> which means only top level nodes with compatible strings will have
>> devices creates. The default version will also descend nodes in the
>> match table such as "simple-bus" which should be fine as openrisc
>> doesn't have any of these (though it is preferred that memory-mapped
>> peripherals be grouped under a bus node(s)).
>>
>> Signed-off-by: Rob Herring <robh@kernel.org>
>> Cc: Jonas Bonn <jonas@southpole.se>
>> Signed-off-by: Stafford Horne <shorne@gmail.com>
>
>
> Yes, this is fine, but trivial/generic stuff like this doesn't really need
> to go via the OpenRISC repo, anyway.

Then which tree do you think it should go thru? I could have applied
it, but it doesn't depend on anything else. So it should go via the
correct maintainer's tree.

Rob

[toc] | [prev] | [next] | [standalone]

#1485074 — [PATCH 5/7] openrisc: Support both old (or32) and new (or1k) toolchain

From: Guenter Roeck <linux@roeck-us.net>

The output file format for or1k has changed from "elf32-or32"
to "elf32-or1k". Select the correct output format automatically
to be able to compile the kernel with both toolchain variants.

Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Stafford Horne <shorne@gmail.com>
---
 arch/openrisc/kernel/vmlinux.lds.S | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/arch/openrisc/kernel/vmlinux.lds.S b/arch/openrisc/kernel/vmlinux.lds.S
index d936de4..4a72d5d 100644
--- a/arch/openrisc/kernel/vmlinux.lds.S
+++ b/arch/openrisc/kernel/vmlinux.lds.S
@@ -30,7 +30,13 @@
 #include <asm/cache.h>
 #include <asm-generic/vmlinux.lds.h>
 
-OUTPUT_FORMAT("elf32-or32", "elf32-or32", "elf32-or32")
+#ifdef __OR1K__
+#define __OUTPUT_FORMAT        "elf32-or1k"
+#else
+#define __OUTPUT_FORMAT        "elf32-or32"
+#endif
+
+OUTPUT_FORMAT(__OUTPUT_FORMAT, __OUTPUT_FORMAT, __OUTPUT_FORMAT)
 jiffies = jiffies_64 + 4;
 
 SECTIONS
-- 
2.7.4

[toc] | [prev] | [next] | [standalone]

#1485839 — Re: [PATCH 5/7] openrisc: Support both old (or32) and new (or1k) toolchain

On 09/16/2016 07:43 AM, Stafford Horne wrote:
> From: Guenter Roeck <linux@roeck-us.net>
>
> The output file format for or1k has changed from "elf32-or32"
> to "elf32-or1k". Select the correct output format automatically
> to be able to compile the kernel with both toolchain variants.
>
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
> Signed-off-by: Stafford Horne <shorne@gmail.com>

I tested your entire series with my qemu setup. Works for me, so for the series:

Tested-by: Guenter Roeck <linux@roeck-us.net>

If you plan to handle openrisc going forward, it would be great if you could
consider updating MAINTAINERS. The web site and git repository have been unreachable
for a long time.

Thanks,
Guenter

> ---
>  arch/openrisc/kernel/vmlinux.lds.S | 8 +++++++-
>  1 file changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/arch/openrisc/kernel/vmlinux.lds.S b/arch/openrisc/kernel/vmlinux.lds.S
> index d936de4..4a72d5d 100644
> --- a/arch/openrisc/kernel/vmlinux.lds.S
> +++ b/arch/openrisc/kernel/vmlinux.lds.S
> @@ -30,7 +30,13 @@
>  #include <asm/cache.h>
>  #include <asm-generic/vmlinux.lds.h>
>
> -OUTPUT_FORMAT("elf32-or32", "elf32-or32", "elf32-or32")
> +#ifdef __OR1K__
> +#define __OUTPUT_FORMAT        "elf32-or1k"
> +#else
> +#define __OUTPUT_FORMAT        "elf32-or32"
> +#endif
> +
> +OUTPUT_FORMAT(__OUTPUT_FORMAT, __OUTPUT_FORMAT, __OUTPUT_FORMAT)
>  jiffies = jiffies_64 + 4;
>
>  SECTIONS
>

[toc] | [prev] | [next] | [standalone]

#1486165 — Re: [PATCH 5/7] openrisc: Support both old (or32) and new (or1k) toolchain

On Sun, 18 Sep 2016, Guenter Roeck wrote:

> Tested-by: Guenter Roeck <linux@roeck-us.net>
>
> If you plan to handle openrisc going forward, it would be great if you could
> consider updating MAINTAINERS. The web site and git repository have been 
> unreachable
> for a long time.

Thank you,
Updating maintainers was kind of on my plans, but I figured I need to 
prove that I kind of know what I am doing.

Thanks for the testing, I have tested as well on my de0 nano FPGA board 
running the cpu in "hardware".

I will make some updates are post a V2.

-Stafford

[toc] | [prev] | [next] | [standalone]

#1486189 — Re: [PATCH 5/7] openrisc: Support both old (or32) and new (or1k) toolchain

On 09/18/2016 11:02 PM, Stafford Horne wrote:
>
>
> On Sun, 18 Sep 2016, Guenter Roeck wrote:
>
>> Tested-by: Guenter Roeck <linux@roeck-us.net>
>>
>> If you plan to handle openrisc going forward, it would be great if you could
>> consider updating MAINTAINERS. The web site and git repository have been unreachable
>> for a long time.
>
> Thank you,
> Updating maintainers was kind of on my plans, but I figured I need to prove that I kind of know what I am doing.
>

The alternative would be to mark it as Orphaned. Which, for all practical purpose,
would be the correct state right now.

Guenter

[toc] | [prev] | [next] | [standalone]

#1486277 — Re: [PATCH 5/7] openrisc: Support both old (or32) and new (or1k) toolchain

On Mon, 19 Sep 2016, Guenter Roeck wrote:

> On 09/18/2016 11:02 PM, Stafford Horne wrote:
>> 
>>
>>  On Sun, 18 Sep 2016, Guenter Roeck wrote:
>> 
>> >  Tested-by: Guenter Roeck <linux@roeck-us.net>
>> > 
>> >  If you plan to handle openrisc going forward, it would be great if you 
>> >  could
>> >  consider updating MAINTAINERS. The web site and git repository have been 
>> >  unreachable
>> >  for a long time.
>>
>>  Thank you,
>>  Updating maintainers was kind of on my plans, but I figured I need to
>>  prove that I kind of know what I am doing.
>> 
>
> The alternative would be to mark it as Orphaned. Which, for all practical 
> purpose,
> would be the correct state right now.

+CC The openrisc list

Understood, 
I don't think we would want that to happen.

[toc] | [prev] | [next] | [standalone]

#1486472 — Re: [PATCH 5/7] openrisc: Support both old (or32) and new (or1k) toolchain

On 09/19/2016 02:11 AM, Stafford Horne wrote:
>
>
> On Mon, 19 Sep 2016, Guenter Roeck wrote:
>
>> On 09/18/2016 11:02 PM, Stafford Horne wrote:
>>>
>>>
>>>  On Sun, 18 Sep 2016, Guenter Roeck wrote:
>>>
>>> >  Tested-by: Guenter Roeck <linux@roeck-us.net>
>>> > >  If you plan to handle openrisc going forward, it would be great if you >  could
>>> >  consider updating MAINTAINERS. The web site and git repository have been >  unreachable
>>> >  for a long time.
>>>
>>>  Thank you,
>>>  Updating maintainers was kind of on my plans, but I figured I need to
>>>  prove that I kind of know what I am doing.
>>>
>>
>> The alternative would be to mark it as Orphaned. Which, for all practical purpose,
>> would be the correct state right now.
>
> +CC The openrisc list
>
> Understood, I don't think we would want that to happen.
>
Look at the entry today:

OPENRISC ARCHITECTURE
M:      Jonas Bonn <jonas@southpole.se>
W:      http://openrisc.net
S:      Maintained
T:      git git://openrisc.net/~jonas/linux
F:      arch/openrisc/

At the very least, W: and T: are incorrect and need to be updated or removed.
Plus, apparently there is a L:, and "T: https://github.com/openrisc/linux"
might be appropriate.

Guenter

[toc] | [prev] | [next] | [standalone]

#1486534 — Re: [PATCH 5/7] openrisc: Support both old (or32) and new (or1k) toolchain

On Mon, 19 Sep 2016, Guenter Roeck wrote:

> On 09/19/2016 02:11 AM, Stafford Horne wrote:
>> 
>>
>>  On Mon, 19 Sep 2016, Guenter Roeck wrote:
>> 
>> >  On 09/18/2016 11:02 PM, Stafford Horne wrote:
>> > > 
>> > > 
>> > >   On Sun, 18 Sep 2016, Guenter Roeck wrote:
>> > > 
>> > > >   Tested-by: Guenter Roeck <linux@roeck-us.net>
>> > > > >   If you plan to handle openrisc going forward, it would be great 
>> > > > >   if you >  could
>> > > >   consider updating MAINTAINERS. The web site and git repository have 
>> > > >   been >  unreachable
>> > > >   for a long time.
>> > > 
>> > >   Thank you,
>> > >   Updating maintainers was kind of on my plans, but I figured I need to
>> > >   prove that I kind of know what I am doing.
>> > > 
>> > 
>> >  The alternative would be to mark it as Orphaned. Which, for all 
>> >  practical purpose,
>> >  would be the correct state right now.
>>
>>  +CC The openrisc list
>>
>>  Understood, I don't think we would want that to happen.
>> 
> Look at the entry today:
>
> OPENRISC ARCHITECTURE
> M:      Jonas Bonn <jonas@southpole.se>
> W:      http://openrisc.net
> S:      Maintained
> T:      git git://openrisc.net/~jonas/linux
> F:      arch/openrisc/
>
> At the very least, W: and T: are incorrect and need to be updated or removed.
> Plus, apparently there is a L:, and "T: https://github.com/openrisc/linux"
> might be appropriate.
>

Thanks,
I am aware of this, we have since setup a new website, mailing list and as 
you have found, git repo. Stefan has been nominated as the maintainer by 
Jonas on a previous mail thread.

The issue (as we see it) is that neither Stefan or I have signed PGP keys 
by anyone in the web of trust.

I sent this patch set with a cover lett trying to explain of the 
situation trying to get some help.  Your reponses are very helpful.

Do you think I should just send "git pull" reuqests to Linus with a self 
signed pgp key and eplaination to see how it goes?

-Stafford

FYI
I have a change as following in my backlog, as follows:

---
@@ -8691,10 +8063,12 @@ F:      drivers/of/overlay.c
  F:     drivers/of/resolver.c

  OPENRISC ARCHITECTURE
-M:	Jonas Bonn <jonas@southpole.se>
-W:	http://openrisc.net
+M:	Stefan Kristiansson <stefan.kristiansson@saunalahti.fi>
+M:	Stafford Horne <shorne@gmail.com>
+W:	http://openrisc.io
+L:	openrisc@lists.librecores.org
+T:	https://github.com/openrisc/linux.git
  S:	Maintained
-T:	git git://openrisc.net/~jonas/linux
  F:	arch/openrisc/

  OPENVSWITCH

--

[toc] | [prev] | [next] | [standalone]

#1486543 — Re: [PATCH 5/7] openrisc: Support both old (or32) and new (or1k) toolchain

On 09/19/2016 04:04 PM, Stafford Horne wrote:
>
>
> On Mon, 19 Sep 2016, Guenter Roeck wrote:
>
>> On 09/19/2016 02:11 AM, Stafford Horne wrote:
>>>
>>>
>>>  On Mon, 19 Sep 2016, Guenter Roeck wrote:
>>>
>>> >  On 09/18/2016 11:02 PM, Stafford Horne wrote:
>>> > > > > > >   On Sun, 18 Sep 2016, Guenter Roeck wrote:
>>> > > > > >   Tested-by: Guenter Roeck <linux@roeck-us.net>
>>> > > > >   If you plan to handle openrisc going forward, it would be 
>>> great > > > >   if you > could
>>> > > >   consider updating MAINTAINERS. The web site and git 
>>> repository have > > >   been > unreachable
>>> > > >   for a long time.
>>> > > > >   Thank you,
>>> > >   Updating maintainers was kind of on my plans, but I figured I 
>>> need to
>>> > >   prove that I kind of know what I am doing.
>>> > > > >  The alternative would be to mark it as Orphaned. Which, for 
>>> all >  practical purpose,
>>> >  would be the correct state right now.
>>>
>>>  +CC The openrisc list
>>>
>>>  Understood, I don't think we would want that to happen.
>>>
>> Look at the entry today:
>>
>> OPENRISC ARCHITECTURE
>> M:      Jonas Bonn <jonas@southpole.se>
>> W:      http://openrisc.net
>> S:      Maintained
>> T:      git git://openrisc.net/~jonas/linux
>> F:      arch/openrisc/
>>
>> At the very least, W: and T: are incorrect and need to be updated or 
>> removed.
>> Plus, apparently there is a L:, and "T: 
>> https://github.com/openrisc/linux"
>> might be appropriate.
>>
>
> Thanks,
> I am aware of this, we have since setup a new website, mailing list 
> and as you have found, git repo. Stefan has been nominated as the 
> maintainer by Jonas on a previous mail thread.
>
> The issue (as we see it) is that neither Stefan or I have signed PGP 
> keys by anyone in the web of trust.
>
> I sent this patch set with a cover lett trying to explain of the 
> situation trying to get some help.  Your reponses are very helpful.
>
> Do you think I should just send "git pull" reuqests to Linus with a 
> self signed pgp key and eplaination to see how it goes?

The bigger question I would have at this point is the value of the code 
remaining upstream...  Five years ago, there was a promise to try to get 
the toolchain upstream within a year or two; to this day, I don't know 
that much progress has been made there so this architecture still 
requires a hodge-podge of tools from various sources to build.

Given the toolchain maintainer's general reluctance to move things 
upstream, I'd almost be inclined to just remove the OpenRISC arch from 
the kernel altogether.  Are there any other arch's that can't be built 
with an upstream GCC at this point?

/Jonas

>
> -Stafford
>
> FYI
> I have a change as following in my backlog, as follows:
>
> ---
> @@ -8691,10 +8063,12 @@ F:      drivers/of/overlay.c
>  F:     drivers/of/resolver.c
>
>  OPENRISC ARCHITECTURE
> -M:    Jonas Bonn <jonas@southpole.se>
> -W:    http://openrisc.net
> +M:    Stefan Kristiansson <stefan.kristiansson@saunalahti.fi>
> +M:    Stafford Horne <shorne@gmail.com>
> +W:    http://openrisc.io
> +L:    openrisc@lists.librecores.org
> +T:    https://github.com/openrisc/linux.git
>  S:    Maintained
> -T:    git git://openrisc.net/~jonas/linux
>  F:    arch/openrisc/
>
>  OPENVSWITCH
>
> -- 

[toc] | [prev] | [next] | [standalone]

#1486573 — Re: [PATCH 5/7] openrisc: Support both old (or32) and new (or1k) toolchain

On 09/19/2016 07:35 AM, Jonas Bonn wrote:
> On 09/19/2016 04:04 PM, Stafford Horne wrote:
>>
>>
>> On Mon, 19 Sep 2016, Guenter Roeck wrote:
>>
>>> On 09/19/2016 02:11 AM, Stafford Horne wrote:
>>>>
>>>>
>>>>  On Mon, 19 Sep 2016, Guenter Roeck wrote:
>>>>
>>>> >  On 09/18/2016 11:02 PM, Stafford Horne wrote:
>>>> > > > > > >   On Sun, 18 Sep 2016, Guenter Roeck wrote:
>>>> > > > > >   Tested-by: Guenter Roeck <linux@roeck-us.net>
>>>> > > > >   If you plan to handle openrisc going forward, it would be great > > > >   if you > could
>>>> > > >   consider updating MAINTAINERS. The web site and git repository have > > >   been > unreachable
>>>> > > >   for a long time.
>>>> > > > >   Thank you,
>>>> > >   Updating maintainers was kind of on my plans, but I figured I need to
>>>> > >   prove that I kind of know what I am doing.
>>>> > > > >  The alternative would be to mark it as Orphaned. Which, for all >  practical purpose,
>>>> >  would be the correct state right now.
>>>>
>>>>  +CC The openrisc list
>>>>
>>>>  Understood, I don't think we would want that to happen.
>>>>
>>> Look at the entry today:
>>>
>>> OPENRISC ARCHITECTURE
>>> M:      Jonas Bonn <jonas@southpole.se>
>>> W:      http://openrisc.net
>>> S:      Maintained
>>> T:      git git://openrisc.net/~jonas/linux
>>> F:      arch/openrisc/
>>>
>>> At the very least, W: and T: are incorrect and need to be updated or removed.
>>> Plus, apparently there is a L:, and "T: https://github.com/openrisc/linux"
>>> might be appropriate.
>>>
>>
>> Thanks,
>> I am aware of this, we have since setup a new website, mailing list and as you have found, git repo. Stefan has been nominated as the maintainer by Jonas on a previous mail thread.
>>
>> The issue (as we see it) is that neither Stefan or I have signed PGP keys by anyone in the web of trust.
>>
>> I sent this patch set with a cover lett trying to explain of the situation trying to get some help.  Your reponses are very helpful.
>>
>> Do you think I should just send "git pull" reuqests to Linus with a self signed pgp key and eplaination to see how it goes?
>
> The bigger question I would have at this point is the value of the code remaining upstream...  Five years ago, there was a promise to try to get the toolchain upstream within a year or two; to this day, I don't know that much progress has been made there so this architecture still requires a hodge-podge of tools from various sources to build.
>
> Given the toolchain maintainer's general reluctance to move things upstream, I'd almost be inclined to just remove the OpenRISC arch from the kernel altogether.  Are there any other arch's that can't be built with an upstream GCC at this point?
>

Yes, several. Definitely avr32. Several others don't build with the upstream gcc,
but no one really cares enough to fix it.

Guenter

> /Jonas
>
>>
>> -Stafford
>>
>> FYI
>> I have a change as following in my backlog, as follows:
>>
>> ---
>> @@ -8691,10 +8063,12 @@ F:      drivers/of/overlay.c
>>  F:     drivers/of/resolver.c
>>
>>  OPENRISC ARCHITECTURE
>> -M:    Jonas Bonn <jonas@southpole.se>
>> -W:    http://openrisc.net
>> +M:    Stefan Kristiansson <stefan.kristiansson@saunalahti.fi>
>> +M:    Stafford Horne <shorne@gmail.com>
>> +W:    http://openrisc.io
>> +L:    openrisc@lists.librecores.org
>> +T:    https://github.com/openrisc/linux.git
>>  S:    Maintained
>> -T:    git git://openrisc.net/~jonas/linux
>>  F:    arch/openrisc/
>>
>>  OPENVSWITCH
>>
>> --
>
>

[toc] | [prev] | [next] | [standalone]

Page 1 of 2  [1] 2  Next page →

Back to top | Article view | linux.kernel

csiph-web