Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1484735 > unrolled thread

Re: [PATCH v6 2/3] ARM: dts: add TOPEET itop elite based board

Started byKrzysztof Kozlowski <krzk@kernel.org>
First post2016-09-16 09:30 +0200
Last post2016-09-18 11:50 +0200
Articles 5 — 3 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH v6 2/3] ARM: dts: add TOPEET itop elite based board Krzysztof Kozlowski <krzk@kernel.org> - 2016-09-16 09:30 +0200
    Re: [PATCH v6 2/3] ARM: dts: add TOPEET itop elite based board ayaka <ayaka@soulik.info> - 2016-09-16 16:10 +0200
      Re: [PATCH v6 2/3] ARM: dts: add TOPEET itop elite based board Krzysztof Kozlowski <krzk@kernel.org> - 2016-09-16 19:30 +0200
        Re: [PATCH v6 2/3] ARM: dts: add TOPEET itop elite based board Javier Martinez Canillas <javier@osg.samsung.com> - 2016-09-16 20:10 +0200
          Re: [PATCH v6 2/3] ARM: dts: add TOPEET itop elite based board ayaka <ayaka@soulik.info> - 2016-09-18 11:50 +0200

#1484735 — Re: [PATCH v6 2/3] ARM: dts: add TOPEET itop elite based board

FromKrzysztof Kozlowski <krzk@kernel.org>
Date2016-09-16 09:30 +0200
SubjectRe: [PATCH v6 2/3] ARM: dts: add TOPEET itop elite based board
Message-ID<shVKW-1xC-17@gated-at.bofh.it>
On 09/07/2016 11:58 PM, Randy Li wrote:
> The TOPEET itop exynos 4412 have three versions base board. The
> Elite version is the cheap one without too much peripheral devices
> on it.
> 
> Currently supported are serial console, wired networking(USB),
> USB OTG in peripheral mode, USB host, SD storage, GPIO buttons,
> PWM beeper, ADC and LEDs. The WM8960 analog audio codec is also
> enabled.
> 
> The FIMC is not used for camera currently, I enabled it just for a
> colorspace convertor.
> 
> Signed-off-by: Randy Li <ayaka@soulik.info>
> ---
>  .../bindings/arm/samsung/samsung-boards.txt        |   3 +
>  arch/arm/boot/dts/Makefile                         |   1 +
>  arch/arm/boot/dts/exynos4412-itop-elite.dts        | 239 +++++++++++++++++++++
>  3 files changed, 243 insertions(+)
>  create mode 100644 arch/arm/boot/dts/exynos4412-itop-elite.dts
> 
> diff --git a/Documentation/devicetree/bindings/arm/samsung/samsung-boards.txt b/Documentation/devicetree/bindings/arm/samsung/samsung-boards.txt
> index 0ea7f14..c7159ac 100644
> --- a/Documentation/devicetree/bindings/arm/samsung/samsung-boards.txt
> +++ b/Documentation/devicetree/bindings/arm/samsung/samsung-boards.txt
> @@ -22,6 +22,9 @@ Required root node properties:
>    * FriendlyARM
>  	- "friendlyarm,tiny4412"  - for Exynos4412-based FriendlyARM
>  				    TINY4412 board.
> +  * TOPEET
> +	- "topeet,itop4412-elite" - for Exynos4412-based TOPEET
> +                                    Elite base board.                             
>  
>    * Google
>  	- "google,pi"		- for Exynos5800-based Google Peach Pi
> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
> index 207f96f..0b39d00 100644
> --- a/arch/arm/boot/dts/Makefile
> +++ b/arch/arm/boot/dts/Makefile
> @@ -130,6 +130,7 @@ dtb-$(CONFIG_ARCH_EXYNOS4) += \
>  	exynos4210-smdkv310.dtb \
>  	exynos4210-trats.dtb \
>  	exynos4210-universal_c210.dtb \
> +	exynos4412-itop-elite.dtb \
>  	exynos4412-odroidu3.dtb \
>  	exynos4412-odroidx.dtb \
>  	exynos4412-odroidx2.dtb \
> diff --git a/arch/arm/boot/dts/exynos4412-itop-elite.dts b/arch/arm/boot/dts/exynos4412-itop-elite.dts
> new file mode 100644
> index 0000000..dd83689
> --- /dev/null
> +++ b/arch/arm/boot/dts/exynos4412-itop-elite.dts
> @@ -0,0 +1,239 @@
> +/*
> + * TOPEET's Exynos4412 based itop board device tree source
> + *
> + * Copyright (c) 2016 SUMOMO Computer Association
> + *			https://www.sumomo.mobi
> + *			Randy Li <ayaka@soulik.info>
> + *			
> + * Device tree source file for TOPEET iTop Exynos 4412 core board 
> + * which is based on Samsung's Exynos4412 SoC.
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License version 2 as
> + * published by the Free Software Foundation.
> +*/
> +
> +/dts-v1/;
> +#include <dt-bindings/sound/samsung-i2s.h>
> +#include "exynos4412-itop-scp-core.dtsi"
> +
> +/ {
> +	model = "TOPEET iTop 4412 Elite board based on Exynos4412";
> +	compatible = "topeet,itop4412-elite", "samsung,exynos4412", "samsung,exynos4";
> +
> +	chosen {
> +		bootargs = "root=/dev/mmcblk0p2 rw rootfstype=ext4 rootwait";
> +		stdout-path = "serial2:115200n8";
> +	};
> +	
> +	leds {
> +		compatible = "gpio-leds";
> +		
> +		led2 {
> +			label = "red:system";
> +			gpios = <&gpx1 0 GPIO_ACTIVE_HIGH>;
> +			default-state = "off";
> +			linux,default-trigger = "heartbeat";
> +		};
> +
> +		led3 {
> +			label = "red:user";
> +			gpios = <&gpk1 1 GPIO_ACTIVE_HIGH>;
> +			default-state = "off";
> +		};
> +	};
> +
> +	gpio-keys {
> +		compatible = "gpio-keys";
> +		
> +		home {
> +			label = "GPIO Key Home";
> +			linux,code = <KEY_HOME>;
> +			gpios = <&gpx1 1 GPIO_ACTIVE_LOW>;
> +		};
> +
> +		back {
> +			label = "GPIO Key Back";
> +			linux,code = <KEY_BACK>;
> +			gpios = <&gpx1 2 GPIO_ACTIVE_LOW>;
> +		};
> +
> +		sleep {
> +			label = "GPIO Key Sleep";
> +			linux,code = <KEY_POWER>;
> +			gpios = <&gpx3 3 GPIO_ACTIVE_LOW>;
> +		};
> +
> +		vol-up {
> +			label = "GPIO Key Vol+";
> +			linux,code = <KEY_UP>;
> +			gpios = <&gpx2 1 GPIO_ACTIVE_LOW>;
> +		};
> +
> +		vol-down {
> +			label = "GPIO Key Vol-";
> +			linux,code = <KEY_DOWN>;
> +			gpios = <&gpx2 0 GPIO_ACTIVE_LOW>;
> +		};
> +	};
> +
> +	sound {
> +		compatible = "simple-audio-card";
> +		simple-audio-card,name = "wm-sound";
> +
> +		assigned-clocks = <&clock_audss EXYNOS_MOUT_AUDSS>,
> +				<&clock_audss EXYNOS_MOUT_I2S>,
> +				<&clock_audss EXYNOS_DOUT_SRP>,
> +				<&clock_audss EXYNOS_DOUT_AUD_BUS>;
> +		assigned-clock-parents = <&clock CLK_FOUT_EPLL>,
> +				<&clock_audss EXYNOS_MOUT_AUDSS>;
> +		assigned-clock-rates = <0>,
> +				<0>,
> +				<112896000>,
> +				<11289600>;
> +
> +		simple-audio-card,format = "i2s";
> +		simple-audio-card,bitclock-master = <&link0_codec>;
> +		simple-audio-card,frame-master = <&link0_codec>;
> +
> +		simple-audio-card,widgets =
> +			"Microphone", "Mic Jack",
> +			"Line", "Line In",
> +			"Line", "Line Out",
> +			"Speaker", "Speaker",
> +			"Headphone", "Headphone Jack";
> +		simple-audio-card,routing =
> +			"Headphone Jack", "HP_L",
> +			"Headphone Jack", "HP_R",
> +			"Speaker", "SPK_LP",
> +			"Speaker", "SPK_LN",
> +			"Speaker", "SPK_RP",
> +			"Speaker", "SPK_RN",
> +			"LINPUT1", "Mic Jack",
> +			"LINPUT3", "Mic Jack",
> +			"RINPUT1", "Mic Jack",
> +			"RINPUT2", "Mic Jack";
> +
> +		simple-audio-card,cpu {
> +			sound-dai = <&i2s0 0>;
> +		};
> +
> +		link0_codec: simple-audio-card,codec {
> +			sound-dai = <&codec>;
> +			clocks = <&i2s0 CLK_I2S_CDCLK>;
> +			system-clock-frequency = <11289600>;
> +		};
> +	};
> +	
> +	beep {
> +		compatible = "pwm-beeper";
> +		pwms = <&pwm 0 4000000 PWM_POLARITY_INVERTED>;

I have serious doubts that you run this code... if it does not even
compile. Sorry, I cannot accept code that does not compile and was not
tested.

Please, test your DTS on top of current Linux tree, which would be one of:
1. Linus' master branch: v4.8-rc6,
2. one of my branches (for-next, next/dt etc),
3. recent linux-next.

Best regards,
Krzysztof

[toc] | [next] | [standalone]

#1485011

Fromayaka <ayaka@soulik.info>
Date2016-09-16 16:10 +0200
Message-ID<si202-5IX-15@gated-at.bofh.it>
In reply to#1484735

On 09/16/2016 03:23 PM, Krzysztof Kozlowski wrote:
> On 09/07/2016 11:58 PM, Randy Li wrote:
>> The TOPEET itop exynos 4412 have three versions base board. The
>> Elite version is the cheap one without too much peripheral devices
>> on it.
>>
>> Currently supported are serial console, wired networking(USB),
>> USB OTG in peripheral mode, USB host, SD storage, GPIO buttons,
>> PWM beeper, ADC and LEDs. The WM8960 analog audio codec is also
>> enabled.
>>
>> The FIMC is not used for camera currently, I enabled it just for a
>> colorspace convertor.
>>
>> Signed-off-by: Randy Li <ayaka@soulik.info>
>> ---
>>   .../bindings/arm/samsung/samsung-boards.txt        |   3 +
>>   arch/arm/boot/dts/Makefile                         |   1 +
>>   arch/arm/boot/dts/exynos4412-itop-elite.dts        | 239 +++++++++++++++++++++
>>   3 files changed, 243 insertions(+)
>>   create mode 100644 arch/arm/boot/dts/exynos4412-itop-elite.dts
>>
>> diff --git a/Documentation/devicetree/bindings/arm/samsung/samsung-boards.txt b/Documentation/devicetree/bindings/arm/samsung/samsung-boards.txt
>> index 0ea7f14..c7159ac 100644
>> --- a/Documentation/devicetree/bindings/arm/samsung/samsung-boards.txt
>> +++ b/Documentation/devicetree/bindings/arm/samsung/samsung-boards.txt
>> @@ -22,6 +22,9 @@ Required root node properties:
>>     * FriendlyARM
>>   	- "friendlyarm,tiny4412"  - for Exynos4412-based FriendlyARM
>>   				    TINY4412 board.
>> +  * TOPEET
>> +	- "topeet,itop4412-elite" - for Exynos4412-based TOPEET
>> +                                    Elite base board.
>>   
>>     * Google
>>   	- "google,pi"		- for Exynos5800-based Google Peach Pi
>> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
>> index 207f96f..0b39d00 100644
>> --- a/arch/arm/boot/dts/Makefile
>> +++ b/arch/arm/boot/dts/Makefile
>> @@ -130,6 +130,7 @@ dtb-$(CONFIG_ARCH_EXYNOS4) += \
>>   	exynos4210-smdkv310.dtb \
>>   	exynos4210-trats.dtb \
>>   	exynos4210-universal_c210.dtb \
>> +	exynos4412-itop-elite.dtb \
>>   	exynos4412-odroidu3.dtb \
>>   	exynos4412-odroidx.dtb \
>>   	exynos4412-odroidx2.dtb \
>> diff --git a/arch/arm/boot/dts/exynos4412-itop-elite.dts b/arch/arm/boot/dts/exynos4412-itop-elite.dts
>> new file mode 100644
>> index 0000000..dd83689
>> --- /dev/null
>> +++ b/arch/arm/boot/dts/exynos4412-itop-elite.dts
>> @@ -0,0 +1,239 @@
>> +/*
>> + * TOPEET's Exynos4412 based itop board device tree source
>> + *
>> + * Copyright (c) 2016 SUMOMO Computer Association
>> + *			https://www.sumomo.mobi
>> + *			Randy Li <ayaka@soulik.info>
>> + *			
>> + * Device tree source file for TOPEET iTop Exynos 4412 core board
>> + * which is based on Samsung's Exynos4412 SoC.
>> + *
>> + * This program is free software; you can redistribute it and/or modify
>> + * it under the terms of the GNU General Public License version 2 as
>> + * published by the Free Software Foundation.
>> +*/
>> +
>> +/dts-v1/;
>> +#include <dt-bindings/sound/samsung-i2s.h>
>> +#include "exynos4412-itop-scp-core.dtsi"
>> +
>> +/ {
>> +	model = "TOPEET iTop 4412 Elite board based on Exynos4412";
>> +	compatible = "topeet,itop4412-elite", "samsung,exynos4412", "samsung,exynos4";
>> +
>> +	chosen {
>> +		bootargs = "root=/dev/mmcblk0p2 rw rootfstype=ext4 rootwait";
>> +		stdout-path = "serial2:115200n8";
>> +	};
>> +	
>> +	leds {
>> +		compatible = "gpio-leds";
>> +		
>> +		led2 {
>> +			label = "red:system";
>> +			gpios = <&gpx1 0 GPIO_ACTIVE_HIGH>;
>> +			default-state = "off";
>> +			linux,default-trigger = "heartbeat";
>> +		};
>> +
>> +		led3 {
>> +			label = "red:user";
>> +			gpios = <&gpk1 1 GPIO_ACTIVE_HIGH>;
>> +			default-state = "off";
>> +		};
>> +	};
>> +
>> +	gpio-keys {
>> +		compatible = "gpio-keys";
>> +		
>> +		home {
>> +			label = "GPIO Key Home";
>> +			linux,code = <KEY_HOME>;
>> +			gpios = <&gpx1 1 GPIO_ACTIVE_LOW>;
>> +		};
>> +
>> +		back {
>> +			label = "GPIO Key Back";
>> +			linux,code = <KEY_BACK>;
>> +			gpios = <&gpx1 2 GPIO_ACTIVE_LOW>;
>> +		};
>> +
>> +		sleep {
>> +			label = "GPIO Key Sleep";
>> +			linux,code = <KEY_POWER>;
>> +			gpios = <&gpx3 3 GPIO_ACTIVE_LOW>;
>> +		};
>> +
>> +		vol-up {
>> +			label = "GPIO Key Vol+";
>> +			linux,code = <KEY_UP>;
>> +			gpios = <&gpx2 1 GPIO_ACTIVE_LOW>;
>> +		};
>> +
>> +		vol-down {
>> +			label = "GPIO Key Vol-";
>> +			linux,code = <KEY_DOWN>;
>> +			gpios = <&gpx2 0 GPIO_ACTIVE_LOW>;
>> +		};
>> +	};
>> +
>> +	sound {
>> +		compatible = "simple-audio-card";
>> +		simple-audio-card,name = "wm-sound";
>> +
>> +		assigned-clocks = <&clock_audss EXYNOS_MOUT_AUDSS>,
>> +				<&clock_audss EXYNOS_MOUT_I2S>,
>> +				<&clock_audss EXYNOS_DOUT_SRP>,
>> +				<&clock_audss EXYNOS_DOUT_AUD_BUS>;
>> +		assigned-clock-parents = <&clock CLK_FOUT_EPLL>,
>> +				<&clock_audss EXYNOS_MOUT_AUDSS>;
>> +		assigned-clock-rates = <0>,
>> +				<0>,
>> +				<112896000>,
>> +				<11289600>;
>> +
>> +		simple-audio-card,format = "i2s";
>> +		simple-audio-card,bitclock-master = <&link0_codec>;
>> +		simple-audio-card,frame-master = <&link0_codec>;
>> +
>> +		simple-audio-card,widgets =
>> +			"Microphone", "Mic Jack",
>> +			"Line", "Line In",
>> +			"Line", "Line Out",
>> +			"Speaker", "Speaker",
>> +			"Headphone", "Headphone Jack";
>> +		simple-audio-card,routing =
>> +			"Headphone Jack", "HP_L",
>> +			"Headphone Jack", "HP_R",
>> +			"Speaker", "SPK_LP",
>> +			"Speaker", "SPK_LN",
>> +			"Speaker", "SPK_RP",
>> +			"Speaker", "SPK_RN",
>> +			"LINPUT1", "Mic Jack",
>> +			"LINPUT3", "Mic Jack",
>> +			"RINPUT1", "Mic Jack",
>> +			"RINPUT2", "Mic Jack";
>> +
>> +		simple-audio-card,cpu {
>> +			sound-dai = <&i2s0 0>;
>> +		};
>> +
>> +		link0_codec: simple-audio-card,codec {
>> +			sound-dai = <&codec>;
>> +			clocks = <&i2s0 CLK_I2S_CDCLK>;
>> +			system-clock-frequency = <11289600>;
>> +		};
>> +	};
>> +	
>> +	beep {
>> +		compatible = "pwm-beeper";
>> +		pwms = <&pwm 0 4000000 PWM_POLARITY_INVERTED>;
> I have serious doubts that you run this code... if it does not even
> compile. Sorry, I cannot accept code that does not compile and was not
> tested.
>
> Please, test your DTS on top of current Linux tree, which would be one of:
> 1. Linus' master branch: v4.8-rc6,
> 2. one of my branches (for-next, next/dt etc),
When I sent those patches, I tested in "Add linux-next specific files 
for 20160907"
> 3. recent linux-next.
>
> Best regards,
> Krzysztof

[toc] | [prev] | [next] | [standalone]

#1485193

FromKrzysztof Kozlowski <krzk@kernel.org>
Date2016-09-16 19:30 +0200
Message-ID<si57z-7Km-1@gated-at.bofh.it>
In reply to#1485011
On Fri, Sep 16, 2016 at 10:04:29PM +0800, ayaka wrote:
> On 09/16/2016 03:23 PM, Krzysztof Kozlowski wrote:
> >On 09/07/2016 11:58 PM, Randy Li wrote:
> >>The TOPEET itop exynos 4412 have three versions base board. The
> >>Elite version is the cheap one without too much peripheral devices
> >>on it.
> >>
> >>Currently supported are serial console, wired networking(USB),
> >>USB OTG in peripheral mode, USB host, SD storage, GPIO buttons,
> >>PWM beeper, ADC and LEDs. The WM8960 analog audio codec is also
> >>enabled.
> >>
> >>The FIMC is not used for camera currently, I enabled it just for a
> >>colorspace convertor.
> >>
> >>Signed-off-by: Randy Li <ayaka@soulik.info>
> >>---
> >>  .../bindings/arm/samsung/samsung-boards.txt        |   3 +
> >>  arch/arm/boot/dts/Makefile                         |   1 +
> >>  arch/arm/boot/dts/exynos4412-itop-elite.dts        | 239 +++++++++++++++++++++
> >>  3 files changed, 243 insertions(+)
> >>  create mode 100644 arch/arm/boot/dts/exynos4412-itop-elite.dts
> >>
> >>diff --git a/Documentation/devicetree/bindings/arm/samsung/samsung-boards.txt b/Documentation/devicetree/bindings/arm/samsung/samsung-boards.txt
> >>index 0ea7f14..c7159ac 100644
> >>--- a/Documentation/devicetree/bindings/arm/samsung/samsung-boards.txt
> >>+++ b/Documentation/devicetree/bindings/arm/samsung/samsung-boards.txt
> >>@@ -22,6 +22,9 @@ Required root node properties:
> >>    * FriendlyARM
> >>  	- "friendlyarm,tiny4412"  - for Exynos4412-based FriendlyARM
> >>  				    TINY4412 board.
> >>+  * TOPEET
> >>+	- "topeet,itop4412-elite" - for Exynos4412-based TOPEET
> >>+                                    Elite base board.
> >>    * Google
> >>  	- "google,pi"		- for Exynos5800-based Google Peach Pi
> >>diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
> >>index 207f96f..0b39d00 100644
> >>--- a/arch/arm/boot/dts/Makefile
> >>+++ b/arch/arm/boot/dts/Makefile
> >>@@ -130,6 +130,7 @@ dtb-$(CONFIG_ARCH_EXYNOS4) += \
> >>  	exynos4210-smdkv310.dtb \
> >>  	exynos4210-trats.dtb \
> >>  	exynos4210-universal_c210.dtb \
> >>+	exynos4412-itop-elite.dtb \
> >>  	exynos4412-odroidu3.dtb \
> >>  	exynos4412-odroidx.dtb \
> >>  	exynos4412-odroidx2.dtb \
> >>diff --git a/arch/arm/boot/dts/exynos4412-itop-elite.dts b/arch/arm/boot/dts/exynos4412-itop-elite.dts
> >>new file mode 100644
> >>index 0000000..dd83689
> >>--- /dev/null
> >>+++ b/arch/arm/boot/dts/exynos4412-itop-elite.dts
> >>@@ -0,0 +1,239 @@
> >>+/*
> >>+ * TOPEET's Exynos4412 based itop board device tree source
> >>+ *
> >>+ * Copyright (c) 2016 SUMOMO Computer Association
> >>+ *			https://www.sumomo.mobi
> >>+ *			Randy Li <ayaka@soulik.info>
> >>+ *			
> >>+ * Device tree source file for TOPEET iTop Exynos 4412 core board
> >>+ * which is based on Samsung's Exynos4412 SoC.
> >>+ *
> >>+ * This program is free software; you can redistribute it and/or modify
> >>+ * it under the terms of the GNU General Public License version 2 as
> >>+ * published by the Free Software Foundation.
> >>+*/
> >>+
> >>+/dts-v1/;
> >>+#include <dt-bindings/sound/samsung-i2s.h>
> >>+#include "exynos4412-itop-scp-core.dtsi"
> >>+
> >>+/ {
> >>+	model = "TOPEET iTop 4412 Elite board based on Exynos4412";
> >>+	compatible = "topeet,itop4412-elite", "samsung,exynos4412", "samsung,exynos4";
> >>+
> >>+	chosen {
> >>+		bootargs = "root=/dev/mmcblk0p2 rw rootfstype=ext4 rootwait";
> >>+		stdout-path = "serial2:115200n8";
> >>+	};
> >>+	
> >>+	leds {
> >>+		compatible = "gpio-leds";
> >>+		
> >>+		led2 {
> >>+			label = "red:system";
> >>+			gpios = <&gpx1 0 GPIO_ACTIVE_HIGH>;
> >>+			default-state = "off";
> >>+			linux,default-trigger = "heartbeat";
> >>+		};
> >>+
> >>+		led3 {
> >>+			label = "red:user";
> >>+			gpios = <&gpk1 1 GPIO_ACTIVE_HIGH>;
> >>+			default-state = "off";
> >>+		};
> >>+	};
> >>+
> >>+	gpio-keys {
> >>+		compatible = "gpio-keys";
> >>+		
> >>+		home {
> >>+			label = "GPIO Key Home";
> >>+			linux,code = <KEY_HOME>;
> >>+			gpios = <&gpx1 1 GPIO_ACTIVE_LOW>;
> >>+		};
> >>+
> >>+		back {
> >>+			label = "GPIO Key Back";
> >>+			linux,code = <KEY_BACK>;
> >>+			gpios = <&gpx1 2 GPIO_ACTIVE_LOW>;
> >>+		};
> >>+
> >>+		sleep {
> >>+			label = "GPIO Key Sleep";
> >>+			linux,code = <KEY_POWER>;
> >>+			gpios = <&gpx3 3 GPIO_ACTIVE_LOW>;
> >>+		};
> >>+
> >>+		vol-up {
> >>+			label = "GPIO Key Vol+";
> >>+			linux,code = <KEY_UP>;
> >>+			gpios = <&gpx2 1 GPIO_ACTIVE_LOW>;
> >>+		};
> >>+
> >>+		vol-down {
> >>+			label = "GPIO Key Vol-";
> >>+			linux,code = <KEY_DOWN>;
> >>+			gpios = <&gpx2 0 GPIO_ACTIVE_LOW>;
> >>+		};
> >>+	};
> >>+
> >>+	sound {
> >>+		compatible = "simple-audio-card";
> >>+		simple-audio-card,name = "wm-sound";
> >>+
> >>+		assigned-clocks = <&clock_audss EXYNOS_MOUT_AUDSS>,
> >>+				<&clock_audss EXYNOS_MOUT_I2S>,
> >>+				<&clock_audss EXYNOS_DOUT_SRP>,
> >>+				<&clock_audss EXYNOS_DOUT_AUD_BUS>;
> >>+		assigned-clock-parents = <&clock CLK_FOUT_EPLL>,
> >>+				<&clock_audss EXYNOS_MOUT_AUDSS>;
> >>+		assigned-clock-rates = <0>,
> >>+				<0>,
> >>+				<112896000>,
> >>+				<11289600>;
> >>+
> >>+		simple-audio-card,format = "i2s";
> >>+		simple-audio-card,bitclock-master = <&link0_codec>;
> >>+		simple-audio-card,frame-master = <&link0_codec>;
> >>+
> >>+		simple-audio-card,widgets =
> >>+			"Microphone", "Mic Jack",
> >>+			"Line", "Line In",
> >>+			"Line", "Line Out",
> >>+			"Speaker", "Speaker",
> >>+			"Headphone", "Headphone Jack";
> >>+		simple-audio-card,routing =
> >>+			"Headphone Jack", "HP_L",
> >>+			"Headphone Jack", "HP_R",
> >>+			"Speaker", "SPK_LP",
> >>+			"Speaker", "SPK_LN",
> >>+			"Speaker", "SPK_RP",
> >>+			"Speaker", "SPK_RN",
> >>+			"LINPUT1", "Mic Jack",
> >>+			"LINPUT3", "Mic Jack",
> >>+			"RINPUT1", "Mic Jack",
> >>+			"RINPUT2", "Mic Jack";
> >>+
> >>+		simple-audio-card,cpu {
> >>+			sound-dai = <&i2s0 0>;
> >>+		};
> >>+
> >>+		link0_codec: simple-audio-card,codec {
> >>+			sound-dai = <&codec>;
> >>+			clocks = <&i2s0 CLK_I2S_CDCLK>;
> >>+			system-clock-frequency = <11289600>;
> >>+		};
> >>+	};
> >>+	
> >>+	beep {
> >>+		compatible = "pwm-beeper";
> >>+		pwms = <&pwm 0 4000000 PWM_POLARITY_INVERTED>;
> >I have serious doubts that you run this code... if it does not even
> >compile. Sorry, I cannot accept code that does not compile and was not
> >tested.
> >
> >Please, test your DTS on top of current Linux tree, which would be one of:
> >1. Linus' master branch: v4.8-rc6,
> >2. one of my branches (for-next, next/dt etc),
> When I sent those patches, I tested in "Add linux-next specific files for
> 20160907"

OK, good, but please tell me why kbuild reported that build error?

Best regards,
Krzysztof

[toc] | [prev] | [next] | [standalone]

#1485221

FromJavier Martinez Canillas <javier@osg.samsung.com>
Date2016-09-16 20:10 +0200
Message-ID<si5Kh-8eX-9@gated-at.bofh.it>
In reply to#1485193
Hello Randy,

On 09/16/2016 01:21 PM, Krzysztof Kozlowski wrote:

[snip]

>>>> +	
>>>> +	beep {
>>>> +		compatible = "pwm-beeper";
>>>> +		pwms = <&pwm 0 4000000 PWM_POLARITY_INVERTED>;
>>> I have serious doubts that you run this code... if it does not even
>>> compile. Sorry, I cannot accept code that does not compile and was not
>>> tested.
>>>
>>> Please, test your DTS on top of current Linux tree, which would be one of:
>>> 1. Linus' master branch: v4.8-rc6,
>>> 2. one of my branches (for-next, next/dt etc),
>> When I sent those patches, I tested in "Add linux-next specific files for
>> 20160907"
>
> OK, good, but please tell me why kbuild reported that build error?
>

I agree with Krzysztof, it doesn't seem that you tested the exact version
that was posted. You will need the following change to make the DTS build
in latest linux-next:

diff --git a/arch/arm/boot/dts/exynos4412-itop-elite.dts b/arch/arm/boot/dts/exynos4412-itop-elite.dts
index dd83689892ff..8559f891a740 100644
--- a/arch/arm/boot/dts/exynos4412-itop-elite.dts
+++ b/arch/arm/boot/dts/exynos4412-itop-elite.dts
@@ -14,6 +14,7 @@
 */
 
 /dts-v1/;
+#include <dt-bindings/pwm/pwm.h>
 #include <dt-bindings/sound/samsung-i2s.h>
 #include "exynos4412-itop-scp-core.dtsi"

So please squash that change and resend.

Best regards,
-- 
Javier Martinez Canillas
Open Source Group
Samsung Research America

[toc] | [prev] | [next] | [standalone]

#1485752

Fromayaka <ayaka@soulik.info>
Date2016-09-18 11:50 +0200
Message-ID<siGTv-6sH-1@gated-at.bofh.it>
In reply to#1485221

On 09/17/2016 02:09 AM, Javier Martinez Canillas wrote:
> Hello Randy,
>
> On 09/16/2016 01:21 PM, Krzysztof Kozlowski wrote:
>
> [snip]
>
>>>>> +	
>>>>> +	beep {
>>>>> +		compatible = "pwm-beeper";
>>>>> +		pwms = <&pwm 0 4000000 PWM_POLARITY_INVERTED>;
>>>> I have serious doubts that you run this code... if it does not even
>>>> compile. Sorry, I cannot accept code that does not compile and was not
>>>> tested.
>>>>
>>>> Please, test your DTS on top of current Linux tree, which would be one of:
>>>> 1. Linus' master branch: v4.8-rc6,
>>>> 2. one of my branches (for-next, next/dt etc),
>>> When I sent those patches, I tested in "Add linux-next specific files for
>>> 20160907"
>> OK, good, but please tell me why kbuild reported that build error?
>>
> I agree with Krzysztof, it doesn't seem that you tested the exact version
I am sure I does.
> that was posted. You will need the following change to make the DTS build
> in latest linux-next:
I didn't post the patch is WIP, which would adding the LCD panel support 
to this board.
>
> diff --git a/arch/arm/boot/dts/exynos4412-itop-elite.dts b/arch/arm/boot/dts/exynos4412-itop-elite.dts
> index dd83689892ff..8559f891a740 100644
> --- a/arch/arm/boot/dts/exynos4412-itop-elite.dts
> +++ b/arch/arm/boot/dts/exynos4412-itop-elite.dts
> @@ -14,6 +14,7 @@
>   */
>   
>   /dts-v1/;
> +#include <dt-bindings/pwm/pwm.h>
>   #include <dt-bindings/sound/samsung-i2s.h>
>   #include "exynos4412-itop-scp-core.dtsi"
>
> So please squash that change and resend.
I would, but I meet a problem in memory with the latest next-20160916, 
it seems that it can't access the memory while it never happened before.
MMC read: dev # 1, block # 2048, count 14336 ...14336 blocks read: 
OK                                                     [58/426]
Boot with zImage

Starting kernel ...

Uncompressing Linux... done, booting the kernel.
[    0.000000] Booting Linux on physical CPU 0xa00
[    0.000000] Linux version 4.8.0-rc6-next-20160916-00004-gae92137 
(ayaka@ritsuko) (gcc version 6.1.0 (Buildroot 2016.05-00006-g0
792d0d-dirty) ) #83 SMP PREEMPT Sun Sep 18 17:29:56 CST 2016
[    0.000000] CPU: ARMv7 Processor [413fc090] revision 0 (ARMv7), 
cr=10c5387d
[    0.000000] CPU: PIPT / VIPT nonaliasing data cache, VIPT aliasing 
instruction cache
[    0.000000] OF: fdt:Machine model: TOPEET iTop 4412 Elite board based 
on Exynos4412
[    0.000000] bootconsole [earlycon0] enabled
[    0.000000] OF: reserved mem: failed to allocate memory for node 
'region_mfc_right'
[    0.000000] OF: reserved mem: failed to allocate memory for node 
'region_mfc_left'
[    0.000000] cma: Failed to reserve 32 MiB
[    0.000000] Memory policy: Data cache writealloc
[    0.000000] Kernel panic - not syncing: ERROR: Failed to allocate 
0x2000 bytes below 0x0.
[    0.000000]
[    0.000000] CPU: 0 PID: 0 Comm: swapper Not tainted 
4.8.0-rc6-next-20160916-00004-gae92137 #83
[    0.000000] Hardware name: SAMSUNG EXYNOS (Flattened Device Tree)
[    0.000000] [<c010e17c>] (unwind_backtrace) from [<c010af78>] 
(show_stack+0x10/0x14)
[    0.000000] [<c010af78>] (show_stack) from [<c03080e4>] 
(dump_stack+0x70/0x8c)
[    0.000000] [<c03080e4>] (dump_stack) from [<c019e580>] 
(panic+0xc4/0x244)
[    0.000000] [<c019e580>] (panic) from [<c0810e3c>] 
(memblock_alloc_base+0x2c/0x38)
[    0.000000] [<c0810e3c>] (memblock_alloc_base) from [<c0806aec>] 
(early_alloc_aligned+0xc/0x2c)
[    0.000000] [<c0806aec>] (early_alloc_aligned) from [<c08074c8>] 
(paging_init+0x548/0xa70)
[    0.000000] [<c08074c8>] (paging_init) from [<c0803dc8>] 
(setup_arch+0x50c/0xa28)
[    0.000000] [<c0803dc8>] (setup_arch) from [<c080091c>] 
(start_kernel+0x50/0x384)
[    0.000000] [<c080091c>] (start_kernel) from [<4000807c>] (0x4000807c)
[    0.000000] ---[ end Kernel panic - not syncing: ERROR: Failed to 
allocate 0x2000 bytes below 0x0.
[    0.000000

>
> Best regards,

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web