Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1482960 > unrolled thread

[PATCH v1 2/3] ARM: dts: imx6q-apalis-ixora: Remove use of pwm-leds

Started bySanchayan Maity <maitysanchayan@gmail.com>
First post2016-09-14 08:50 +0200
Last post2016-09-16 19:20 +0200
Articles 4 — 3 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  [PATCH v1 2/3] ARM: dts: imx6q-apalis-ixora: Remove use of pwm-leds Sanchayan Maity <maitysanchayan@gmail.com> - 2016-09-14 08:50 +0200
    Re: [PATCH v1 2/3] ARM: dts: imx6q-apalis-ixora: Remove use of  pwm-leds Stefan Agner <stefan@agner.ch> - 2016-09-14 18:10 +0200
      Re: [PATCH v1 2/3] ARM: dts: imx6q-apalis-ixora: Remove use of  pwm-leds Marcel Ziswiler <marcel.ziswiler@toradex.com> - 2016-09-14 22:10 +0200
    Re: [PATCH v1 2/3] ARM: dts: imx6q-apalis-ixora: Remove use of  pwm-leds Marcel Ziswiler <marcel.ziswiler@toradex.com> - 2016-09-16 19:20 +0200

#1482960 — [PATCH v1 2/3] ARM: dts: imx6q-apalis-ixora: Remove use of pwm-leds

FromSanchayan Maity <maitysanchayan@gmail.com>
Date2016-09-14 08:50 +0200
Subject[PATCH v1 2/3] ARM: dts: imx6q-apalis-ixora: Remove use of pwm-leds
Message-ID<shcb8-5My-9@gated-at.bofh.it>
Remove use of pwm-leds and use the standard /sys/class/pwm
interface from PWM subsystem.

Signed-off-by: Sanchayan Maity <maitysanchayan@gmail.com>
---
 arch/arm/boot/dts/imx6q-apalis-ixora.dts | 22 ----------------------
 1 file changed, 22 deletions(-)

diff --git a/arch/arm/boot/dts/imx6q-apalis-ixora.dts b/arch/arm/boot/dts/imx6q-apalis-ixora.dts
index d99979e..70a3da0 100644
--- a/arch/arm/boot/dts/imx6q-apalis-ixora.dts
+++ b/arch/arm/boot/dts/imx6q-apalis-ixora.dts
@@ -146,28 +146,6 @@
 			gpios = <&gpio2 2 GPIO_ACTIVE_HIGH>;
 		};
 	};
-
-	pwmleds {
-		compatible = "pwm-leds";
-
-		ledpwm1 {
-			label = "PWM1";
-			pwms = <&pwm1 0 50000>;
-			max-brightness = <255>;
-		};
-
-		ledpwm2 {
-			label = "PWM2";
-			pwms = <&pwm2 0 50000>;
-			max-brightness = <255>;
-		};
-
-		ledpwm3 {
-			label = "PWM3";
-			pwms = <&pwm3 0 50000>;
-			max-brightness = <255>;
-		};
-	};
 };
 
 &backlight {
-- 
2.9.3

[toc] | [next] | [standalone]


#1483453 — Re: [PATCH v1 2/3] ARM: dts: imx6q-apalis-ixora: Remove use of pwm-leds

FromStefan Agner <stefan@agner.ch>
Date2016-09-14 18:10 +0200
SubjectRe: [PATCH v1 2/3] ARM: dts: imx6q-apalis-ixora: Remove use of pwm-leds
Message-ID<shkV4-2Zu-9@gated-at.bofh.it>
In reply to#1482960
On 2016-09-13 23:35, Sanchayan Maity wrote:
> Remove use of pwm-leds and use the standard /sys/class/pwm
> interface from PWM subsystem.

Don't we have actual leds on the Ixora?

--
Stefan

> 
> Signed-off-by: Sanchayan Maity <maitysanchayan@gmail.com>
> ---
>  arch/arm/boot/dts/imx6q-apalis-ixora.dts | 22 ----------------------
>  1 file changed, 22 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/imx6q-apalis-ixora.dts
> b/arch/arm/boot/dts/imx6q-apalis-ixora.dts
> index d99979e..70a3da0 100644
> --- a/arch/arm/boot/dts/imx6q-apalis-ixora.dts
> +++ b/arch/arm/boot/dts/imx6q-apalis-ixora.dts
> @@ -146,28 +146,6 @@
>  			gpios = <&gpio2 2 GPIO_ACTIVE_HIGH>;
>  		};
>  	};
> -
> -	pwmleds {
> -		compatible = "pwm-leds";
> -
> -		ledpwm1 {
> -			label = "PWM1";
> -			pwms = <&pwm1 0 50000>;
> -			max-brightness = <255>;
> -		};
> -
> -		ledpwm2 {
> -			label = "PWM2";
> -			pwms = <&pwm2 0 50000>;
> -			max-brightness = <255>;
> -		};
> -
> -		ledpwm3 {
> -			label = "PWM3";
> -			pwms = <&pwm3 0 50000>;
> -			max-brightness = <255>;
> -		};
> -	};
>  };
>  
>  &backlight {

[toc] | [prev] | [next] | [standalone]


#1483619 — Re: [PATCH v1 2/3] ARM: dts: imx6q-apalis-ixora: Remove use of pwm-leds

FromMarcel Ziswiler <marcel.ziswiler@toradex.com>
Date2016-09-14 22:10 +0200
SubjectRe: [PATCH v1 2/3] ARM: dts: imx6q-apalis-ixora: Remove use of pwm-leds
Message-ID<shoFk-5qB-45@gated-at.bofh.it>
In reply to#1483453
On Wed, 2016-09-14 at 08:58 -0700, Stefan Agner wrote:
> On 2016-09-13 23:35, Sanchayan Maity wrote:
> > 
> > Remove use of pwm-leds and use the standard /sys/class/pwm
> > interface from PWM subsystem.
> Don't we have actual leds on the Ixora?

Yes, sure, but not really PWM ones:

https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/ar
ch/arm/boot/dts/imx6q-apalis-ixora.dts?id=refs/tags/v4.8-rc6#n124

[toc] | [prev] | [next] | [standalone]


#1485190 — Re: [PATCH v1 2/3] ARM: dts: imx6q-apalis-ixora: Remove use of pwm-leds

FromMarcel Ziswiler <marcel.ziswiler@toradex.com>
Date2016-09-16 19:20 +0200
SubjectRe: [PATCH v1 2/3] ARM: dts: imx6q-apalis-ixora: Remove use of pwm-leds
Message-ID<si4XU-7Hc-17@gated-at.bofh.it>
In reply to#1482960
On Wed, 2016-09-14 at 12:05 +0530, Sanchayan Maity wrote:
> Remove use of pwm-leds and use the standard /sys/class/pwm
> interface from PWM subsystem.
> 
> Signed-off-by: Sanchayan Maity <maitysanchayan@gmail.com>

Acked-by: Marcel Ziswiler <marcel.ziswiler@toradex.com>

> ---
>  arch/arm/boot/dts/imx6q-apalis-ixora.dts | 22 ----------------------
>  1 file changed, 22 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/imx6q-apalis-ixora.dts
> b/arch/arm/boot/dts/imx6q-apalis-ixora.dts
> index d99979e..70a3da0 100644
> --- a/arch/arm/boot/dts/imx6q-apalis-ixora.dts
> +++ b/arch/arm/boot/dts/imx6q-apalis-ixora.dts
> @@ -146,28 +146,6 @@
>  			gpios = <&gpio2 2 GPIO_ACTIVE_HIGH>;
>  		};
>  	};
> -
> -	pwmleds {
> -		compatible = "pwm-leds";
> -
> -		ledpwm1 {
> -			label = "PWM1";
> -			pwms = <&pwm1 0 50000>;
> -			max-brightness = <255>;
> -		};
> -
> -		ledpwm2 {
> -			label = "PWM2";
> -			pwms = <&pwm2 0 50000>;
> -			max-brightness = <255>;
> -		};
> -
> -		ledpwm3 {
> -			label = "PWM3";
> -			pwms = <&pwm3 0 50000>;
> -			max-brightness = <255>;
> -		};
> -	};
>  };
>  
>  &backlight {

Tested working fine analogous to what we documented for Vybrid:

http://developer.toradex.com/knowledge-base/pwm-(linux)#Colibri_VFxx

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web