Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1481227 > unrolled thread
| Started by | Colin King <colin.king@canonical.com> |
|---|---|
| First post | 2016-09-12 14:50 +0200 |
| Last post | 2016-09-14 19:20 +0200 |
| Articles | 4 — 4 participants |
Back to article view | Back to linux.kernel
[PATCH] scsi: megaraid_sas: add in missing white space in error message text Colin King <colin.king@canonical.com> - 2016-09-12 14:50 +0200
RE: [PATCH] scsi: megaraid_sas: add in missing white space in error message text Sumit Saxena <sumit.saxena@broadcom.com> - 2016-09-13 14:00 +0200
Re: [PATCH] scsi: megaraid_sas: add in missing white space in error message text Hannes Reinecke <hare@suse.de> - 2016-09-14 15:30 +0200
Re: [PATCH] scsi: megaraid_sas: add in missing white space in error message text "Martin K. Petersen" <martin.petersen@oracle.com> - 2016-09-14 19:20 +0200
| From | Colin King <colin.king@canonical.com> |
|---|---|
| Date | 2016-09-12 14:50 +0200 |
| Subject | [PATCH] scsi: megaraid_sas: add in missing white space in error message text |
| Message-ID | <sgyQq-3n9-23@gated-at.bofh.it> |
From: Colin Ian King <colin.king@canonical.com>
A dev_printk message spans two lines and the literal string is missing
a white space between words. Add the white space.
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/scsi/megaraid/megaraid_sas_base.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/megaraid/megaraid_sas_base.c b/drivers/scsi/megaraid/megaraid_sas_base.c
index 2d62d71..c236c4d 100644
--- a/drivers/scsi/megaraid/megaraid_sas_base.c
+++ b/drivers/scsi/megaraid/megaraid_sas_base.c
@@ -5782,7 +5782,7 @@ static int megasas_probe_one(struct pci_dev *pdev,
&instance->consumer_h);
if (!instance->producer || !instance->consumer) {
- dev_printk(KERN_DEBUG, &pdev->dev, "Failed to allocate"
+ dev_printk(KERN_DEBUG, &pdev->dev, "Failed to allocate "
"memory for producer, consumer\n");
goto fail_alloc_dma_buf;
}
--
2.9.3
[toc] | [next] | [standalone]
| From | Sumit Saxena <sumit.saxena@broadcom.com> |
|---|---|
| Date | 2016-09-13 14:00 +0200 |
| Subject | RE: [PATCH] scsi: megaraid_sas: add in missing white space in error message text |
| Message-ID | <sgUxz-1jF-1@gated-at.bofh.it> |
| In reply to | #1481227 |
>-----Original Message-----
>From: Colin King [mailto:colin.king@canonical.com]
>Sent: Monday, September 12, 2016 6:12 PM
>To: Kashyap Desai; Sumit Saxena; Uday Lingala; James E . J . Bottomley;
>Martin K
>. Petersen; megaraidlinux.pdl@avagotech.com; linux-scsi@vger.kernel.org
>Cc: linux-kernel@vger.kernel.org
>Subject: [PATCH] scsi: megaraid_sas: add in missing white space in error
>message
>text
>
>From: Colin Ian King <colin.king@canonical.com>
>
>A dev_printk message spans two lines and the literal string is missing a
>white
>space between words. Add the white space.
>
>Signed-off-by: Colin Ian King <colin.king@canonical.com>
>---
> drivers/scsi/megaraid/megaraid_sas_base.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/drivers/scsi/megaraid/megaraid_sas_base.c
>b/drivers/scsi/megaraid/megaraid_sas_base.c
>index 2d62d71..c236c4d 100644
>--- a/drivers/scsi/megaraid/megaraid_sas_base.c
>+++ b/drivers/scsi/megaraid/megaraid_sas_base.c
>@@ -5782,7 +5782,7 @@ static int megasas_probe_one(struct pci_dev *pdev,
> &instance->consumer_h);
>
> if (!instance->producer || !instance->consumer) {
>- dev_printk(KERN_DEBUG, &pdev->dev, "Failed to
>allocate"
>+ dev_printk(KERN_DEBUG, &pdev->dev, "Failed to
>allocate "
> "memory for producer, consumer\n");
> goto fail_alloc_dma_buf;
> }
Acked-by: Sumit Saxena <sumit.saxena@broadcom.com>
>--
>2.9.3
[toc] | [prev] | [next] | [standalone]
| From | Hannes Reinecke <hare@suse.de> |
|---|---|
| Date | 2016-09-14 15:30 +0200 |
| Subject | Re: [PATCH] scsi: megaraid_sas: add in missing white space in error message text |
| Message-ID | <shiqe-1oQ-21@gated-at.bofh.it> |
| In reply to | #1481227 |
On 09/12/2016 02:42 PM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> A dev_printk message spans two lines and the literal string is missing
> a white space between words. Add the white space.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/scsi/megaraid/megaraid_sas_base.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/megaraid/megaraid_sas_base.c b/drivers/scsi/megaraid/megaraid_sas_base.c
> index 2d62d71..c236c4d 100644
> --- a/drivers/scsi/megaraid/megaraid_sas_base.c
> +++ b/drivers/scsi/megaraid/megaraid_sas_base.c
> @@ -5782,7 +5782,7 @@ static int megasas_probe_one(struct pci_dev *pdev,
> &instance->consumer_h);
>
> if (!instance->producer || !instance->consumer) {
> - dev_printk(KERN_DEBUG, &pdev->dev, "Failed to allocate"
> + dev_printk(KERN_DEBUG, &pdev->dev, "Failed to allocate "
> "memory for producer, consumer\n");
> goto fail_alloc_dma_buf;
> }
>
Reviewed-by: Hannes Reinecke <hare@suse.com>
Cheers,
Hannes
--
Dr. Hannes Reinecke zSeries & Storage
hare@suse.de +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg)
[toc] | [prev] | [next] | [standalone]
| From | "Martin K. Petersen" <martin.petersen@oracle.com> |
|---|---|
| Date | 2016-09-14 19:20 +0200 |
| Message-ID | <shm0N-3Fk-9@gated-at.bofh.it> |
| In reply to | #1481227 |
>>>>> "Colin" == Colin King <colin.king@canonical.com> writes: Colin> From: Colin Ian King <colin.king@canonical.com> A dev_printk Colin> message spans two lines and the literal string is missing a white Colin> space between words. Add the white space. Applied to 4.9/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web