Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1483400 > unrolled thread

[PATCH v2 4/5] drm/qxl: squash lines for simple wrapper functions

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  [PATCH v2 4/5] drm/qxl: squash lines for simple wrapper functions Masahiro Yamada <yamada.masahiro@socionext.com> - 2016-09-14 16:50 +0200
    Re: [PATCH v2 4/5] drm/qxl: squash lines for simple wrapper functions Gustavo Padovan <gustavo.padovan@collabora.com> - 2016-09-15 14:40 +0200
    Re: [PATCH v2 4/5] drm/qxl: squash lines for simple wrapper functions Gustavo Padovan <gustavo@padovan.org> - 2016-09-15 15:50 +0200
      Re: [PATCH v2 4/5] drm/qxl: squash lines for simple wrapper functions Sean Paul <seanpaul@chromium.org> - 2016-09-15 16:50 +0200

#1483400 — [PATCH v2 4/5] drm/qxl: squash lines for simple wrapper functions

Remove unneeded variables and assignments.

Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
---

 drivers/gpu/drm/qxl/qxl_draw.c    | 7 ++-----
 drivers/gpu/drm/qxl/qxl_release.c | 7 ++-----
 2 files changed, 4 insertions(+), 10 deletions(-)

diff --git a/drivers/gpu/drm/qxl/qxl_draw.c b/drivers/gpu/drm/qxl/qxl_draw.c
index ffe8853..9b728ed 100644
--- a/drivers/gpu/drm/qxl/qxl_draw.c
+++ b/drivers/gpu/drm/qxl/qxl_draw.c
@@ -57,11 +57,8 @@ static struct qxl_rect *drawable_set_clipping(struct qxl_device *qdev,
 static int
 alloc_drawable(struct qxl_device *qdev, struct qxl_release **release)
 {
-	int ret;
-	ret = qxl_alloc_release_reserved(qdev, sizeof(struct qxl_drawable),
-					 QXL_RELEASE_DRAWABLE, release,
-					 NULL);
-	return ret;
+	return qxl_alloc_release_reserved(qdev, sizeof(struct qxl_drawable),
+					  QXL_RELEASE_DRAWABLE, release, NULL);
 }
 
 static void
diff --git a/drivers/gpu/drm/qxl/qxl_release.c b/drivers/gpu/drm/qxl/qxl_release.c
index f599cd0..cd83f05 100644
--- a/drivers/gpu/drm/qxl/qxl_release.c
+++ b/drivers/gpu/drm/qxl/qxl_release.c
@@ -203,12 +203,9 @@ static long qxl_fence_wait(struct fence *fence, bool intr, signed long timeout)
 static int qxl_release_bo_alloc(struct qxl_device *qdev,
 				struct qxl_bo **bo)
 {
-	int ret;
 	/* pin releases bo's they are too messy to evict */
-	ret = qxl_bo_create(qdev, PAGE_SIZE, false, true,
-			    QXL_GEM_DOMAIN_VRAM, NULL,
-			    bo);
-	return ret;
+	return qxl_bo_create(qdev, PAGE_SIZE, false, true,
+			     QXL_GEM_DOMAIN_VRAM, NULL, bo);
 }
 
 int qxl_release_list_add(struct qxl_release *release, struct qxl_bo *bo)
-- 
1.9.1

[toc] | [next] | [standalone]

#1484114

Hi Masahiro,

2016-09-14 Masahiro Yamada <yamada.masahiro@socionext.com>:

> Remove unneeded variables and assignments.
> 
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> ---
> 
>  drivers/gpu/drm/qxl/qxl_draw.c    | 7 ++-----
>  drivers/gpu/drm/qxl/qxl_release.c | 7 ++-----
>  2 files changed, 4 insertions(+), 10 deletions(-)

Reviewed-by: Gustavo Padovan <gustavo.padovan@collabora.co.uk>

Gustavo

[toc] | [prev] | [next] | [standalone]

#1484184

2016-09-14 Masahiro Yamada <yamada.masahiro@socionext.com>:

> Remove unneeded variables and assignments.
> 
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> ---
> 
>  drivers/gpu/drm/qxl/qxl_draw.c    | 7 ++-----
>  drivers/gpu/drm/qxl/qxl_release.c | 7 ++-----
>  2 files changed, 4 insertions(+), 10 deletions(-)

For patches 1 to 4:

Reviewed-by: Gustavo Padovan <gustavo.padovan@collabora.co.uk>

Gustavo

[toc] | [prev] | [next] | [standalone]

#1484259

On Thu, Sep 15, 2016 at 9:47 AM, Gustavo Padovan <gustavo@padovan.org> wrote:
> 2016-09-14 Masahiro Yamada <yamada.masahiro@socionext.com>:
>
>> Remove unneeded variables and assignments.
>>
>> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
>> ---
>>
>>  drivers/gpu/drm/qxl/qxl_draw.c    | 7 ++-----
>>  drivers/gpu/drm/qxl/qxl_release.c | 7 ++-----
>>  2 files changed, 4 insertions(+), 10 deletions(-)
>
> For patches 1 to 4:
>
> Reviewed-by: Gustavo Padovan <gustavo.padovan@collabora.co.uk>



Applied to drm-misc

Sean

>
> Gustavo
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web