Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1482825 > unrolled thread
| Started by | Tony Lindgren <tony@atomide.com> |
|---|---|
| First post | 2016-09-14 00:40 +0200 |
| Last post | 2016-09-14 16:40 +0200 |
| Articles | 3 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: drivers/usb/musb/tusb6010.c:142:21: error: 'USB_INDEX' undeclared Tony Lindgren <tony@atomide.com> - 2016-09-14 00:40 +0200
Re: drivers/usb/musb/tusb6010.c:142:21: error: 'USB_INDEX' undeclared Bin Liu <b-liu@ti.com> - 2016-09-14 15:20 +0200
Re: drivers/usb/musb/tusb6010.c:142:21: error: 'USB_INDEX' undeclared Tony Lindgren <tony@atomide.com> - 2016-09-14 16:40 +0200
| From | Tony Lindgren <tony@atomide.com> |
|---|---|
| Date | 2016-09-14 00:40 +0200 |
| Subject | Re: drivers/usb/musb/tusb6010.c:142:21: error: 'USB_INDEX' undeclared |
| Message-ID | <sh4wV-85g-17@gated-at.bofh.it> |
* Bin Liu <b-liu@ti.com> [160908 11:26]: > On Thu, Sep 08, 2016 at 10:45:21AM -0700, Tony Lindgren wrote: > > --- a/drivers/usb/musb/Kconfig > > +++ b/drivers/usb/musb/Kconfig > > @@ -87,7 +87,7 @@ config USB_MUSB_DA8XX > > config USB_MUSB_TUSB6010 > > tristate "TUSB6010" > > depends on HAS_IOMEM > > - depends on ARCH_OMAP2PLUS || COMPILE_TEST > > + depends on (ARCH_OMAP2PLUS || COMPILE_TEST) && !BLACKFIN > > Would this cause more issue later when trying to enable all glue drivers > in one build? Yes but see what CONFIG_BLACKFIN is doing with musb_regs.h.. It completely redefines all the registers with ifdef else. > The macros defined in tusb6010.h are only used in tusb6010.c, so how > about move '#include "tusb6010.h"' from musb_regs.h to tusb6010.c > instead? This gives flexibility to random config test, isn't it? I'd like to see that but we have this in musb_core.c: hw_ep->conf = mbase - 0x400 + TUSB_EP0_CONF; So the build would break there again on blackin with tusb6010.. Got any ideas on how to sort that out? Regards, Tony
[toc] | [next] | [standalone]
| From | Bin Liu <b-liu@ti.com> |
|---|---|
| Date | 2016-09-14 15:20 +0200 |
| Message-ID | <shigx-1lL-15@gated-at.bofh.it> |
| In reply to | #1482825 |
On Tue, Sep 13, 2016 at 03:35:05PM -0700, Tony Lindgren wrote: > * Bin Liu <b-liu@ti.com> [160908 11:26]: > > On Thu, Sep 08, 2016 at 10:45:21AM -0700, Tony Lindgren wrote: > > > --- a/drivers/usb/musb/Kconfig > > > +++ b/drivers/usb/musb/Kconfig > > > @@ -87,7 +87,7 @@ config USB_MUSB_DA8XX > > > config USB_MUSB_TUSB6010 > > > tristate "TUSB6010" > > > depends on HAS_IOMEM > > > - depends on ARCH_OMAP2PLUS || COMPILE_TEST > > > + depends on (ARCH_OMAP2PLUS || COMPILE_TEST) && !BLACKFIN > > > > Would this cause more issue later when trying to enable all glue drivers > > in one build? > > Yes but see what CONFIG_BLACKFIN is doing with musb_regs.h.. > It completely redefines all the registers with ifdef else. > > > The macros defined in tusb6010.h are only used in tusb6010.c, so how > > about move '#include "tusb6010.h"' from musb_regs.h to tusb6010.c > > instead? This gives flexibility to random config test, isn't it? > > I'd like to see that but we have this in musb_core.c: > > hw_ep->conf = mbase - 0x400 + TUSB_EP0_CONF; > > So the build would break there again on blackin with tusb6010.. > Got any ideas on how to sort that out? Thanks for catching it. It appears that the glues require more work to cleanup. I am taking your patch. Regards, -Bin. > > Regards, > > Tony
[toc] | [prev] | [next] | [standalone]
| From | Tony Lindgren <tony@atomide.com> |
|---|---|
| Date | 2016-09-14 16:40 +0200 |
| Message-ID | <shjvY-215-5@gated-at.bofh.it> |
| In reply to | #1483275 |
* Bin Liu <b-liu@ti.com> [160914 06:14]: > On Tue, Sep 13, 2016 at 03:35:05PM -0700, Tony Lindgren wrote: > > * Bin Liu <b-liu@ti.com> [160908 11:26]: > > > On Thu, Sep 08, 2016 at 10:45:21AM -0700, Tony Lindgren wrote: > > > > --- a/drivers/usb/musb/Kconfig > > > > +++ b/drivers/usb/musb/Kconfig > > > > @@ -87,7 +87,7 @@ config USB_MUSB_DA8XX > > > > config USB_MUSB_TUSB6010 > > > > tristate "TUSB6010" > > > > depends on HAS_IOMEM > > > > - depends on ARCH_OMAP2PLUS || COMPILE_TEST > > > > + depends on (ARCH_OMAP2PLUS || COMPILE_TEST) && !BLACKFIN > > > > > > Would this cause more issue later when trying to enable all glue drivers > > > in one build? > > > > Yes but see what CONFIG_BLACKFIN is doing with musb_regs.h.. > > It completely redefines all the registers with ifdef else. > > > > > The macros defined in tusb6010.h are only used in tusb6010.c, so how > > > about move '#include "tusb6010.h"' from musb_regs.h to tusb6010.c > > > instead? This gives flexibility to random config test, isn't it? > > > > I'd like to see that but we have this in musb_core.c: > > > > hw_ep->conf = mbase - 0x400 + TUSB_EP0_CONF; > > > > So the build would break there again on blackin with tusb6010.. > > Got any ideas on how to sort that out? > > Thanks for catching it. It appears that the glues require more work to > cleanup. I am taking your patch. OK thanks, yeah still more work needed for the glue layers for sure. Regards, Tony
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web