Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1482047 > unrolled thread

drivers: staging: vme: Fixed some code style warnings

Back to article view | Back to linux.kernel

Contents

  drivers: staging: vme: Fixed some code style warnings Andrew Kanner <andrew.kanner@gmail.com> - 2016-09-13 00:40 +0200
    Re: drivers: staging: vme: Fixed some code style warnings Markus Böhme <markus.boehme@mailbox.org> - 2016-09-14 15:00 +0200
      Re: drivers: staging: vme: Fixed some code style warnings Andrew Kanner <andrew.kanner@gmail.com> - 2016-09-14 18:40 +0200
        Re: drivers: staging: vme: Fixed some code style warnings Markus Böhme <markus.boehme@mailbox.org> - 2016-09-14 23:50 +0200

#1482047 — drivers: staging: vme: Fixed some code style warnings

Signed-off-by: Andrew Kanner <andrew.kanner@gmail.com>
---
 drivers/staging/vme/devices/vme_pio2_core.c | 12 ++++++------
 drivers/staging/vme/devices/vme_user.c      |  2 +-
 2 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/drivers/staging/vme/devices/vme_pio2_core.c b/drivers/staging/vme/devices/vme_pio2_core.c
index 28a4568..8e66a52 100644
--- a/drivers/staging/vme/devices/vme_pio2_core.c
+++ b/drivers/staging/vme/devices/vme_pio2_core.c
@@ -466,23 +466,23 @@ static void __exit pio2_exit(void)
 
 /* These are required for each board */
 MODULE_PARM_DESC(bus, "Enumeration of VMEbus to which the board is connected");
-module_param_array(bus, int, &bus_num, S_IRUGO);
+module_param_array(bus, int, &bus_num, 0444);
 
 MODULE_PARM_DESC(base, "Base VME address for PIO2 Registers");
-module_param_array(base, long, &base_num, S_IRUGO);
+module_param_array(base, long, &base_num, 0444);
 
 MODULE_PARM_DESC(vector, "VME IRQ Vector (Lower 4 bits masked)");
-module_param_array(vector, int, &vector_num, S_IRUGO);
+module_param_array(vector, int, &vector_num, 0444);
 
 MODULE_PARM_DESC(level, "VME IRQ Level");
-module_param_array(level, int, &level_num, S_IRUGO);
+module_param_array(level, int, &level_num, 0444);
 
 MODULE_PARM_DESC(variant, "Last 4 characters of PIO2 board variant");
-module_param_array(variant, charp, &variant_num, S_IRUGO);
+module_param_array(variant, charp, &variant_num, 0444);
 
 /* This is for debugging */
 MODULE_PARM_DESC(loopback, "Enable loopback mode on all cards");
-module_param(loopback, bool, S_IRUGO);
+module_param(loopback, bool, 0444);
 
 MODULE_DESCRIPTION("GE PIO2 6U VME I/O Driver");
 MODULE_AUTHOR("Martyn Welch <martyn.welch@ge.com");
diff --git a/drivers/staging/vme/devices/vme_user.c b/drivers/staging/vme/devices/vme_user.c
index b95883b..5dd430f 100644
--- a/drivers/staging/vme/devices/vme_user.c
+++ b/drivers/staging/vme/devices/vme_user.c
@@ -773,7 +773,7 @@ static void __exit vme_user_exit(void)
 }
 
 MODULE_PARM_DESC(bus, "Enumeration of VMEbus to which the driver is connected");
-module_param_array(bus, int, &bus_num, 0);
+module_param_array(bus, int, &bus_num, 0000);
 
 MODULE_DESCRIPTION("VME User Space Access Driver");
 MODULE_AUTHOR("Martyn Welch <martyn.welch@ge.com");
-- 
2.1.4

[toc] | [next] | [standalone]

#1483254

On 09/13/2016 12:31 AM, Andrew Kanner wrote:
> Signed-off-by: Andrew Kanner <andrew.kanner@gmail.com>
> ---
>  drivers/staging/vme/devices/vme_pio2_core.c | 12 ++++++------
>  drivers/staging/vme/devices/vme_user.c      |  2 +-
>  2 files changed, 7 insertions(+), 7 deletions(-)
> (snip)

Hello Andrew,

please be more specific in your subject line, e.g.
"drivers: staging: vme: Convert to octal notation for permission bits".

Also don't forget to add a commit message to your patch with a short
description what you are fixing and why. In your case it would be good
to mention that you are fixing a checkpatch warning, and to include the
warning message in your description. Then resend as V2.

Thanks,
Markus

[toc] | [prev] | [next] | [standalone]

#1483467

‎Thanks, I understood my fault, but haven't done this changes yet. I can't understand if I should reply to original message with v2 patch or send a new email with it?


  Исходное сообщение  
От: Markus Böhme
Отправлено: среда, 14 сентября 2016 г., 15:56
Кому: Andrew Kanner; gregkh@linuxfoundation.org
Копия: devel@driverdev.osuosl.org; manohar.vanga@gmail.com; egor.ulieiskii@gmail.com; linux-kernel@vger.kernel.org
Тема: Re: drivers: staging: vme: Fixed some code style warnings

On 09/13/2016 12:31 AM, Andrew Kanner wrote:
> Signed-off-by: Andrew Kanner <andrew.kanner@gmail.com>
> ---
> drivers/staging/vme/devices/vme_pio2_core.c | 12 ++++++------
> drivers/staging/vme/devices/vme_user.c | 2 +-
> 2 files changed, 7 insertions(+), 7 deletions(-)
> (snip)

Hello Andrew,

please be more specific in your subject line, e.g.
"drivers: staging: vme: Convert to octal notation for permission bits".

Also don't forget to add a commit message to your patch with a short
description what you are fixing and why. In your case it would be good
to mention that you are fixing a checkpatch warning, and to include the
warning message in your description. Then resend as V2.

Thanks,
Markus

[toc] | [prev] | [next] | [standalone]

#1483705

On 09/14/2016 06:31 PM, Andrew Kanner wrote:
> ‎Thanks, I understood my fault, but haven't done this changes yet. I
> can't understand if I should reply to original message with v2 patch or
> send a new email with it?

Just send the patch with your revised commit message as a new mail, and
be sure to mark it as v2.

In future mails, please avoid top-posting. It is frowned upon because it
makes it unnecessarily hard to follow a discussion.

Thanks,
Markus

> 
> 
>   Исходное сообщение  
> От: Markus Böhme
> Отправлено: среда, 14 сентября 2016 г., 15:56
> Кому: Andrew Kanner; gregkh@linuxfoundation.org
> Копия: devel@driverdev.osuosl.org; manohar.vanga@gmail.com; egor.ulieiskii@gmail.com; linux-kernel@vger.kernel.org
> Тема: Re: drivers: staging: vme: Fixed some code style warnings
> 
> On 09/13/2016 12:31 AM, Andrew Kanner wrote:
>> Signed-off-by: Andrew Kanner <andrew.kanner@gmail.com>
>> ---
>> drivers/staging/vme/devices/vme_pio2_core.c | 12 ++++++------
>> drivers/staging/vme/devices/vme_user.c | 2 +-
>> 2 files changed, 7 insertions(+), 7 deletions(-)
>> (snip)
> 
> Hello Andrew,
> 
> please be more specific in your subject line, e.g.
> "drivers: staging: vme: Convert to octal notation for permission bits".
> 
> Also don't forget to add a commit message to your patch with a short
> description what you are fixing and why. In your case it would be good
> to mention that you are fixing a checkpatch warning, and to include the
> warning message in your description. Then resend as V2.
> 
> Thanks,
> Markus
> 

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web