Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1484860 > unrolled thread
| Started by | Colin King <colin.king@canonical.com> |
|---|---|
| First post | 2016-09-16 12:20 +0200 |
| Last post | 2016-09-16 13:20 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH] ALSA: au88x0: Add missing \n to end of dev_err message Colin King <colin.king@canonical.com> - 2016-09-16 12:20 +0200
Re: [PATCH] ALSA: au88x0: Add missing \n to end of dev_err message Takashi Iwai <tiwai@suse.de> - 2016-09-16 13:20 +0200
| From | Colin King <colin.king@canonical.com> |
|---|---|
| Date | 2016-09-16 12:20 +0200 |
| Subject | [PATCH] ALSA: au88x0: Add missing \n to end of dev_err message |
| Message-ID | <shYps-3nl-33@gated-at.bofh.it> |
From: Colin Ian King <colin.king@canonical.com>
Trival fix, the dev_err message is missing a \n so add it.
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
sound/pci/au88x0/au88x0_core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/pci/au88x0/au88x0_core.c b/sound/pci/au88x0/au88x0_core.c
index d3125c1..e1af24f 100644
--- a/sound/pci/au88x0/au88x0_core.c
+++ b/sound/pci/au88x0/au88x0_core.c
@@ -1043,7 +1043,7 @@ static void vortex_fifo_init(vortex_t * vortex)
for (x = NR_ADB - 1; x >= 0; x--) {
hwwrite(vortex->mmio, addr, (FIFO_U0 | FIFO_U1));
if (hwread(vortex->mmio, addr) != (FIFO_U0 | FIFO_U1))
- dev_err(vortex->card->dev, "bad adb fifo reset!");
+ dev_err(vortex->card->dev, "bad adb fifo reset!\n");
vortex_fifo_clearadbdata(vortex, x, FIFO_SIZE);
addr -= 4;
}
--
2.9.3
[toc] | [next] | [standalone]
| From | Takashi Iwai <tiwai@suse.de> |
|---|---|
| Date | 2016-09-16 13:20 +0200 |
| Message-ID | <shZlw-3Xl-39@gated-at.bofh.it> |
| In reply to | #1484860 |
On Fri, 16 Sep 2016 12:09:25 +0200,
Colin King wrote:
>
> From: Colin Ian King <colin.king@canonical.com>
>
> Trival fix, the dev_err message is missing a \n so add it.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Applied, thanks.
Takashi
> ---
> sound/pci/au88x0/au88x0_core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sound/pci/au88x0/au88x0_core.c b/sound/pci/au88x0/au88x0_core.c
> index d3125c1..e1af24f 100644
> --- a/sound/pci/au88x0/au88x0_core.c
> +++ b/sound/pci/au88x0/au88x0_core.c
> @@ -1043,7 +1043,7 @@ static void vortex_fifo_init(vortex_t * vortex)
> for (x = NR_ADB - 1; x >= 0; x--) {
> hwwrite(vortex->mmio, addr, (FIFO_U0 | FIFO_U1));
> if (hwread(vortex->mmio, addr) != (FIFO_U0 | FIFO_U1))
> - dev_err(vortex->card->dev, "bad adb fifo reset!");
> + dev_err(vortex->card->dev, "bad adb fifo reset!\n");
> vortex_fifo_clearadbdata(vortex, x, FIFO_SIZE);
> addr -= 4;
> }
> --
> 2.9.3
>
>
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web