Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1483455 > unrolled thread

[PATCH 2/2] net/ibm/emac: add mutex to 'set multicast list'

Started byIvan Mikhaylov <ivan@de.ibm.com>
First post2016-09-14 18:10 +0200
Last post2016-09-16 10:30 +0200
Articles 2 — 2 participants

Back to article view | Back to linux.kernel


Contents

  [PATCH 2/2] net/ibm/emac: add mutex to 'set multicast list' Ivan Mikhaylov <ivan@de.ibm.com> - 2016-09-14 18:10 +0200
    Re: [PATCH 2/2] net/ibm/emac: add mutex to 'set multicast list' David Miller <davem@davemloft.net> - 2016-09-16 10:30 +0200

#1483455 — [PATCH 2/2] net/ibm/emac: add mutex to 'set multicast list'

FromIvan Mikhaylov <ivan@de.ibm.com>
Date2016-09-14 18:10 +0200
Subject[PATCH 2/2] net/ibm/emac: add mutex to 'set multicast list'
Message-ID<shkV4-2Zu-13@gated-at.bofh.it>
for preventing race conditions within ioctl calls.

Signed-off-by: Ivan Mikhaylov <ivan@de.ibm.com>
---
 drivers/net/ethernet/ibm/emac/core.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/net/ethernet/ibm/emac/core.c b/drivers/net/ethernet/ibm/emac/core.c
index 2dfc603..7af09cb 100644
--- a/drivers/net/ethernet/ibm/emac/core.c
+++ b/drivers/net/ethernet/ibm/emac/core.c
@@ -977,7 +977,10 @@ static void emac_set_multicast_list(struct net_device *ndev)
 		dev->mcast_pending = 1;
 		return;
 	}
+
+	mutex_lock(&dev->link_lock);
 	__emac_set_multicast_list(dev);
+	mutex_unlock(&dev->link_lock);
 }
 
 static int emac_set_mac_address(struct net_device *ndev, void *sa)
-- 
2.7.4 (Apple Git-66)

[toc] | [next] | [standalone]


#1484774

FromDavid Miller <davem@davemloft.net>
Date2016-09-16 10:30 +0200
Message-ID<shWGZ-2bE-7@gated-at.bofh.it>
In reply to#1483455
From: Ivan Mikhaylov <ivan@de.ibm.com>
Date: Wed, 14 Sep 2016 19:06:45 +0300

> for preventing race conditions within ioctl calls.
> 
> Signed-off-by: Ivan Mikhaylov <ivan@de.ibm.com>

Applied.

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web