Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1483489 > unrolled thread

Re: [PATCH] scsi: replace broken specification URL

Started by"Martin K. Petersen" <martin.petersen@oracle.com>
First post2016-09-14 19:10 +0200
Last post2016-09-16 03:00 +0200
Articles 6 — 3 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH] scsi: replace broken specification URL "Martin K. Petersen" <martin.petersen@oracle.com> - 2016-09-14 19:10 +0200
    Re: [PATCH] scsi: replace broken specification URL Michael Opdenacker <michael.opdenacker@free-electrons.com> - 2016-09-15 14:40 +0200
      [PATCH] scsi: replace broken specification URL Michael Opdenacker <michael.opdenacker@free-electrons.com> - 2016-09-15 15:10 +0200
        Re: [PATCH] scsi: replace broken specification URL "Martin K. Petersen" <martin.petersen@oracle.com> - 2016-09-15 16:10 +0200
          Re: [PATCH] scsi: replace broken specification URL Laurence Oberman <loberman@redhat.com> - 2016-09-16 03:10 +0200
        Re: [PATCH] scsi: replace broken specification URL Laurence Oberman <loberman@redhat.com> - 2016-09-16 03:00 +0200

#1483489 — Re: [PATCH] scsi: replace broken specification URL

From"Martin K. Petersen" <martin.petersen@oracle.com>
Date2016-09-14 19:10 +0200
SubjectRe: [PATCH] scsi: replace broken specification URL
Message-ID<shlR7-3Ce-21@gated-at.bofh.it>
>>>>> "Michael" == Michael Opdenacker <michael.opdenacker@free-electrons.com> writes:

Michael> So, should we only that the cam-r12b document can be found from
Michael> http://www.t10.org/t10docs.htm (registration required)?, and
Michael> tell that a copy can be found on
Michael> http://www.csit-sun.pub.ro/~cpop/Documentatie_SMP/Standarde_magistrale/SCSI/?

As inconvenient as the T10/ANSI restrictions are, we should not be
linking to illegitimate spec repositories.

-- 
Martin K. Petersen	Oracle Linux Engineering

[toc] | [next] | [standalone]

#1484120

FromMichael Opdenacker <michael.opdenacker@free-electrons.com>
Date2016-09-15 14:40 +0200
Message-ID<shE7o-72q-33@gated-at.bofh.it>
In reply to#1483489
Hi Martin,

On 14/09/2016 19:00, Martin K. Petersen wrote:
>
> Michael> So, should we only that the cam-r12b document can be found from
> Michael> http://www.t10.org/t10docs.htm (registration required)?, and
> Michael> tell that a copy can be found on
> Michael> http://www.csit-sun.pub.ro/~cpop/Documentatie_SMP/Standarde_magistrale/SCSI/?
>
> As inconvenient as the T10/ANSI restrictions are, we should not be
> linking to illegitimate spec repositories.

I agree with you. The documents do not allow copy without permission, so 
the copies we found are illegitimate indeed.

Now I know what patch to send, to get rid of the broken link :)

Thanks,

Michael.

-- 
Michael Opdenacker, CEO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

[toc] | [prev] | [next] | [standalone]

#1484143

FromMichael Opdenacker <michael.opdenacker@free-electrons.com>
Date2016-09-15 15:10 +0200
Message-ID<shEAp-7rV-9@gated-at.bofh.it>
In reply to#1484120
The t10.org website containing SCSI-2 draft specifications now requires
to be from a member company to access the documents.

Signed-off-by: Michael Opdenacker <michael.opdenacker@free-electrons.com>
---
 Documentation/DocBook/scsi.tmpl | 6 +++---
 drivers/scsi/scsicam.c          | 3 ++-
 2 files changed, 5 insertions(+), 4 deletions(-)

diff --git a/Documentation/DocBook/scsi.tmpl b/Documentation/DocBook/scsi.tmpl
index 4b9b9b286cea..b8b646426321 100644
--- a/Documentation/DocBook/scsi.tmpl
+++ b/Documentation/DocBook/scsi.tmpl
@@ -160,9 +160,9 @@
       <sect2 id="scsicam.c">
         <title>drivers/scsi/scsicam.c</title>
         <para>
-          <ulink url='http://www.t10.org/ftp/t10/drafts/cam/cam-r12b.pdf'>SCSI
-          Common Access Method</ulink> support functions, for use with
-          HDIO_GETGEO, etc.
+          <ulink url='http://www.t10.org/t10docs.htm'>SCSI Common Access
+	  Method</ulink> support functions ('cam-r12b.pdf' document,
+	  registration required), for use with HDIO_GETGEO, etc.
         </para>
 !Edrivers/scsi/scsicam.c
       </sect2>
diff --git a/drivers/scsi/scsicam.c b/drivers/scsi/scsicam.c
index 910f4a7a3924..5c446d9ef468 100644
--- a/drivers/scsi/scsicam.c
+++ b/drivers/scsi/scsicam.c
@@ -207,7 +207,8 @@ EXPORT_SYMBOL(scsi_partsize);
  *
  * WORKING                                                    X3T9.2
  * DRAFT                                                        792D
- * see http://www.t10.org/ftp/t10/drafts/cam/cam-r12b.pdf
+ * 'cam-r12b.pdf' document on http://www.t10.org/t10docs.htm
+ * (registration required)
  *
  *                                                        Revision 6
  *                                                         10-MAR-94
-- 
2.7.4

[toc] | [prev] | [next] | [standalone]

#1484211

From"Martin K. Petersen" <martin.petersen@oracle.com>
Date2016-09-15 16:10 +0200
Message-ID<shFwu-822-29@gated-at.bofh.it>
In reply to#1484143
>>>>> "Michael" == Michael Opdenacker <michael.opdenacker@free-electrons.com> writes:

Michael> + * 'cam-r12b.pdf' document on http://www.t10.org/t10docs.htm
Michael> + * (registration required)

That link really should be http://www.t10.org/drafts.htm. You can't look
up draft specifications using the proposal document search form.

-- 
Martin K. Petersen	Oracle Linux Engineering

[toc] | [prev] | [next] | [standalone]

#1484634

FromLaurence Oberman <loberman@redhat.com>
Date2016-09-16 03:10 +0200
Message-ID<shPPb-697-7@gated-at.bofh.it>
In reply to#1484211

----- Original Message -----
> From: "Martin K. Petersen" <martin.petersen@oracle.com>
> To: "Michael Opdenacker" <michael.opdenacker@free-electrons.com>
> Cc: corbet@lwn.net, jejb@linux.vnet.ibm.com, "martin petersen" <martin.petersen@oracle.com>,
> linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org
> Sent: Thursday, September 15, 2016 10:06:19 AM
> Subject: Re: [PATCH] scsi: replace broken specification URL
> 
> >>>>> "Michael" == Michael Opdenacker <michael.opdenacker@free-electrons.com>
> >>>>> writes:
> 
> Michael> + * 'cam-r12b.pdf' document on http://www.t10.org/t10docs.htm
> Michael> + * (registration required)
> 
> That link really should be http://www.t10.org/drafts.htm. You can't look
> up draft specifications using the proposal document search form.
> 
> --
> Martin K. Petersen	Oracle Linux Engineering
> --
> To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 
I looked up the original URL when reviewing, and missed the Proposal Heading.
Checked the one Martin referred to and agree with Martin's change as well.

[toc] | [prev] | [next] | [standalone]

#1484632

FromLaurence Oberman <loberman@redhat.com>
Date2016-09-16 03:00 +0200
Message-ID<shPFv-5QF-1@gated-at.bofh.it>
In reply to#1484143

----- Original Message -----
> From: "Michael Opdenacker" <michael.opdenacker@free-electrons.com>
> To: corbet@lwn.net, jejb@linux.vnet.ibm.com, "martin petersen" <martin.petersen@oracle.com>
> Cc: linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org, "Michael Opdenacker"
> <michael.opdenacker@free-electrons.com>
> Sent: Thursday, September 15, 2016 9:03:05 AM
> Subject: [PATCH] scsi: replace broken specification URL
> 
> The t10.org website containing SCSI-2 draft specifications now requires
> to be from a member company to access the documents.
> 
> Signed-off-by: Michael Opdenacker <michael.opdenacker@free-electrons.com>
> ---
>  Documentation/DocBook/scsi.tmpl | 6 +++---
>  drivers/scsi/scsicam.c          | 3 ++-
>  2 files changed, 5 insertions(+), 4 deletions(-)
> 
> diff --git a/Documentation/DocBook/scsi.tmpl
> b/Documentation/DocBook/scsi.tmpl
> index 4b9b9b286cea..b8b646426321 100644
> --- a/Documentation/DocBook/scsi.tmpl
> +++ b/Documentation/DocBook/scsi.tmpl
> @@ -160,9 +160,9 @@
>        <sect2 id="scsicam.c">
>          <title>drivers/scsi/scsicam.c</title>
>          <para>
> -          <ulink
> url='http://www.t10.org/ftp/t10/drafts/cam/cam-r12b.pdf'>SCSI
> -          Common Access Method</ulink> support functions, for use with
> -          HDIO_GETGEO, etc.
> +          <ulink url='http://www.t10.org/t10docs.htm'>SCSI Common Access
> +	  Method</ulink> support functions ('cam-r12b.pdf' document,
> +	  registration required), for use with HDIO_GETGEO, etc.
>          </para>
>  !Edrivers/scsi/scsicam.c
>        </sect2>
> diff --git a/drivers/scsi/scsicam.c b/drivers/scsi/scsicam.c
> index 910f4a7a3924..5c446d9ef468 100644
> --- a/drivers/scsi/scsicam.c
> +++ b/drivers/scsi/scsicam.c
> @@ -207,7 +207,8 @@ EXPORT_SYMBOL(scsi_partsize);
>   *
>   * WORKING                                                    X3T9.2
>   * DRAFT                                                        792D
> - * see http://www.t10.org/ftp/t10/drafts/cam/cam-r12b.pdf
> + * 'cam-r12b.pdf' document on http://www.t10.org/t10docs.htm
> + * (registration required)
>   *
>   *                                                        Revision 6
>   *                                                         10-MAR-94
> --
> 2.7.4
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 
Looks right matching what James wanted as well.
Reviewed-by: Laurence Oberman <loberman@redhat.com>

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web