Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1481190 > unrolled thread

[PATCH][V2] atm: iphase: fix newline escape and minor tweak to source formatting Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit

Started byColin King <colin.king@canonical.com>
First post2016-09-12 14:10 +0200
Last post2016-09-16 01:20 +0200
Articles 2 — 2 participants

Back to article view | Back to linux.kernel


Contents

  [PATCH][V2] atm: iphase: fix newline escape and minor tweak to source formatting Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Colin King <colin.king@canonical.com> - 2016-09-12 14:10 +0200
    Re: [PATCH][V2] atm: iphase: fix newline escape and minor tweak to  source formatting David Miller <davem@davemloft.net> - 2016-09-16 01:20 +0200

#1481190 — [PATCH][V2] atm: iphase: fix newline escape and minor tweak to source formatting Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit

FromColin King <colin.king@canonical.com>
Date2016-09-12 14:10 +0200
Subject[PATCH][V2] atm: iphase: fix newline escape and minor tweak to source formatting Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit
Message-ID<sgydH-35W-15@gated-at.bofh.it>
From: Colin Ian King <colin.king@canonical.com>

The newline escape is incorrect and needs fixing. Also adjust source
formatting / indentation and add { } to trailing else.

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 drivers/atm/iphase.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/atm/iphase.c b/drivers/atm/iphase.c
index 9d8807e..ddb244e 100644
--- a/drivers/atm/iphase.c
+++ b/drivers/atm/iphase.c
@@ -1885,9 +1885,9 @@ static int open_tx(struct atm_vcc *vcc)
                 if ((ret = ia_cbr_setup (iadev, vcc)) < 0) {     
                     return ret;
                 }
-       } 
-	else  
-           printk("iadev:  Non UBR, ABR and CBR traffic not supportedn"); 
+	} else {
+		printk("iadev:  Non UBR, ABR and CBR traffic not supported\n");
+	}
         
         iadev->testTable[vcc->vci]->vc_status |= VC_ACTIVE;
 	IF_EVENT(printk("ia open_tx returning \n");)  
-- 
2.9.3

[toc] | [next] | [standalone]


#1484614 — Re: [PATCH][V2] atm: iphase: fix newline escape and minor tweak to source formatting

FromDavid Miller <davem@davemloft.net>
Date2016-09-16 01:20 +0200
SubjectRe: [PATCH][V2] atm: iphase: fix newline escape and minor tweak to source formatting
Message-ID<shO6J-4ZP-3@gated-at.bofh.it>
In reply to#1481190
From: Colin King <colin.king@canonical.com>
Date: Mon, 12 Sep 2016 13:01:50 +0100

> From: Colin Ian King <colin.king@canonical.com>
> 
> The newline escape is incorrect and needs fixing. Also adjust source
> formatting / indentation and add { } to trailing else.
> 
> Signed-off-by: Colin Ian King <colin.king@canonical.com>

Applied.

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web