Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1484435 > unrolled thread

Re: [PATCH] sctp: Remove some redundant code

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH] sctp: Remove some redundant code Marcelo <marcelo.leitner@gmail.com> - 2016-09-15 19:40 +0200
    Re: [PATCH] sctp: Remove some redundant code Christophe JAILLET <christophe.jaillet@wanadoo.fr> - 2016-09-15 21:40 +0200
      Re: [PATCH] sctp: Remove some redundant code Marcelo <marcelo.leitner@gmail.com> - 2016-09-15 22:20 +0200

#1484435 — Re: [PATCH] sctp: Remove some redundant code

On Sun, Sep 04, 2016 at 11:38:13AM +0200, Christophe JAILLET wrote:
> In commit 311b21774f13 ("sctp: simplify sk_receive_queue locking"), a call
> to 'skb_queue_splice_tail_init()' has been made explicit. Previously it was
> hidden in 'sctp_skb_list_tail()'
> 
> Now, the code around it looks redundant. The '_init()' part of
> 'skb_queue_splice_tail_init()' should alreday do the same.
> 
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>

I just noticed you didn't include netdev@ in the destinations.

Is your patch going to be tracked somewhere else? It's not showing up in
http://patchwork.ozlabs.org/project/netdev/list/?submitter=66309&state=*&q=&archive=&delegate=

[toc] | [next] | [standalone]

#1484495

Le 15/09/2016 à 19:34, Marcelo a écrit :
> On Sun, Sep 04, 2016 at 11:38:13AM +0200, Christophe JAILLET wrote:
>> In commit 311b21774f13 ("sctp: simplify sk_receive_queue locking"), a call
>> to 'skb_queue_splice_tail_init()' has been made explicit. Previously it was
>> hidden in 'sctp_skb_list_tail()'
>>
>> Now, the code around it looks redundant. The '_init()' part of
>> 'skb_queue_splice_tail_init()' should alreday do the same.
>>
>> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> I just noticed you didn't include netdev@ in the destinations.
>
> Is your patch going to be tracked somewhere else? It's not showing up in
> http://patchwork.ozlabs.org/project/netdev/list/?submitter=66309&state=*&q=&archive=&delegate=
>
My fault, get_maintainer lists netdev@ but I missed it.

Should I resubmit or is it ok?

CJ

[toc] | [prev] | [next] | [standalone]

#1484518

On Thu, Sep 15, 2016 at 09:32:18PM +0200, Christophe JAILLET wrote:
> Le 15/09/2016 à 19:34, Marcelo a écrit :
> > On Sun, Sep 04, 2016 at 11:38:13AM +0200, Christophe JAILLET wrote:
> > > In commit 311b21774f13 ("sctp: simplify sk_receive_queue locking"), a call
> > > to 'skb_queue_splice_tail_init()' has been made explicit. Previously it was
> > > hidden in 'sctp_skb_list_tail()'
> > > 
> > > Now, the code around it looks redundant. The '_init()' part of
> > > 'skb_queue_splice_tail_init()' should alreday do the same.
> > > 
> > > Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> > I just noticed you didn't include netdev@ in the destinations.
> > 
> > Is your patch going to be tracked somewhere else? It's not showing up in
> > http://patchwork.ozlabs.org/project/netdev/list/?submitter=66309&state=*&q=&archive=&delegate=
> > 
> My fault, get_maintainer lists netdev@ but I missed it.
> 
> Should I resubmit or is it ok?

I guess you need to resubmit then, as it's not showing up in patchwork.

  Marcelo

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web