Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1483967 > unrolled thread

[PATCH 1/7] mfd: max8997-irq: 'inline' should be at the beginning of the declaration

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  [PATCH 1/7] mfd: max8997-irq: 'inline' should be at the beginning of the declaration Lee Jones <lee.jones@linaro.org> - 2016-09-15 12:50 +0200
    Re: [PATCH 1/7] mfd: max8997-irq: 'inline' should be at the beginning of the declaration Arnd Bergmann <arnd@arndb.de> - 2016-09-15 13:30 +0200

#1483967 — [PATCH 1/7] mfd: max8997-irq: 'inline' should be at the beginning of the declaration

Reported by [-Wold-style-declaration].

Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
 drivers/mfd/max8997-irq.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mfd/max8997-irq.c b/drivers/mfd/max8997-irq.c
index b95a46d7..326f17b 100644
--- a/drivers/mfd/max8997-irq.c
+++ b/drivers/mfd/max8997-irq.c
@@ -139,7 +139,7 @@ static void max8997_irq_sync_unlock(struct irq_data *data)
 	mutex_unlock(&max8997->irqlock);
 }
 
-static const inline struct max8997_irq_data *
+inline static const struct max8997_irq_data *
 irq_to_max8997_irq(struct max8997_dev *max8997, struct irq_data *data)
 {
 	return &max8997_irqs[data->hwirq];
-- 
2.9.3

[toc] | [next] | [standalone]

#1484003

On Thursday, September 15, 2016 11:45:15 AM CEST Lee Jones wrote:
> -static const inline struct max8997_irq_data *
> +inline static const struct max8997_irq_data *

I think this causes another warning, the order should be
"stastic inline const struct max8997_irq_data".

	Arnd

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web