Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1482785 > unrolled thread
| Started by | Guenter Roeck <linux@roeck-us.net> |
|---|---|
| First post | 2016-09-13 23:40 +0200 |
| Last post | 2016-09-14 22:20 +0200 |
| Articles | 4 — 3 participants |
Back to article view | Back to linux.kernel
Build error in -next due to ion patches when building sparc64:allmodconfig Guenter Roeck <linux@roeck-us.net> - 2016-09-13 23:40 +0200
[PATCH] staging: android: ion: Make ION_OF depend on OF_ADDRESS Laura Abbott <labbott@redhat.com> - 2016-09-14 17:40 +0200
Re: [PATCH] staging: android: ion: Make ION_OF depend on OF_ADDRESS Sumit Semwal <sumit.semwal@linaro.org> - 2016-09-14 18:30 +0200
Re: [PATCH] staging: android: ion: Make ION_OF depend on OF_ADDRESS Guenter Roeck <linux@roeck-us.net> - 2016-09-14 22:20 +0200
| From | Guenter Roeck <linux@roeck-us.net> |
|---|---|
| Date | 2016-09-13 23:40 +0200 |
| Subject | Build error in -next due to ion patches when building sparc64:allmodconfig |
| Message-ID | <sh3AS-7tK-7@gated-at.bofh.it> |
Hi Laura, I see the following build error in -next. Building sparc64:allmodconfig ... failed -------------- Error log: ... drivers/built-in.o: In function `ion_parse_dt': (.text+0x11aa2c): undefined reference to `of_platform_device_create' of_platform_device_create() depends on CONFIG_OF_ADDRESS, which is not supported on sparc. Maybe add "depends on OF_ADDRESS" to the Kconfig file ? Thanks, Guenter
[toc] | [next] | [standalone]
| From | Laura Abbott <labbott@redhat.com> |
|---|---|
| Date | 2016-09-14 17:40 +0200 |
| Subject | [PATCH] staging: android: ion: Make ION_OF depend on OF_ADDRESS |
| Message-ID | <shks1-2zX-1@gated-at.bofh.it> |
| In reply to | #1482785 |
The Ion platform code uses of_platform_device_create which has dependencies on OF_ADDRESS. Depending on OF is not sufficient Building sparc64:allmodconfig ... failed -------------- Error log: ... drivers/built-in.o: In function `ion_parse_dt': (.text+0x11aa2c): undefined reference to `of_platform_device_create' Add a dependency on OF_ADDRESS Reported-by: Guenter Roeck <linux@roeck-us.net> Signed-off-by: Laura Abbott <labbott@redhat.com> --- Based on next-20160914 --- drivers/staging/android/ion/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/android/ion/Kconfig b/drivers/staging/android/ion/Kconfig index 8a54ddc..9410554 100644 --- a/drivers/staging/android/ion/Kconfig +++ b/drivers/staging/android/ion/Kconfig @@ -43,7 +43,7 @@ source "drivers/staging/android/ion/hisilicon/Kconfig" config ION_OF bool "Devicetree support for Ion" - depends on ION && OF + depends on ION && OF_ADDRESS help Provides base support for defining Ion heaps in devicetree and setting them up. Also includes functions for platforms -- 2.7.4
[toc] | [prev] | [next] | [standalone]
| From | Sumit Semwal <sumit.semwal@linaro.org> |
|---|---|
| Date | 2016-09-14 18:30 +0200 |
| Subject | Re: [PATCH] staging: android: ion: Make ION_OF depend on OF_ADDRESS |
| Message-ID | <shlep-39Z-27@gated-at.bofh.it> |
| In reply to | #1483433 |
Hi Laura, On 14 September 2016 at 21:03, Laura Abbott <labbott@redhat.com> wrote: > The Ion platform code uses of_platform_device_create which has > dependencies on OF_ADDRESS. Depending on OF is not sufficient > Thanks for the patch; looks good to me. Please feel free to apply my Reviewed-by: Sumit Semwal <sumit.semwal@linaro.org> Best, Sumit. > Building sparc64:allmodconfig ... failed > -------------- > Error log: > ... > drivers/built-in.o: In function `ion_parse_dt': > (.text+0x11aa2c): undefined reference to `of_platform_device_create' > > Add a dependency on OF_ADDRESS > > Reported-by: Guenter Roeck <linux@roeck-us.net> > Signed-off-by: Laura Abbott <labbott@redhat.com> > --- > Based on next-20160914 > --- > drivers/staging/android/ion/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/android/ion/Kconfig b/drivers/staging/android/ion/Kconfig > index 8a54ddc..9410554 100644 > --- a/drivers/staging/android/ion/Kconfig > +++ b/drivers/staging/android/ion/Kconfig > @@ -43,7 +43,7 @@ source "drivers/staging/android/ion/hisilicon/Kconfig" > > config ION_OF > bool "Devicetree support for Ion" > - depends on ION && OF > + depends on ION && OF_ADDRESS > help > Provides base support for defining Ion heaps in devicetree > and setting them up. Also includes functions for platforms > -- > 2.7.4 >
[toc] | [prev] | [next] | [standalone]
| From | Guenter Roeck <linux@roeck-us.net> |
|---|---|
| Date | 2016-09-14 22:20 +0200 |
| Subject | Re: [PATCH] staging: android: ion: Make ION_OF depend on OF_ADDRESS |
| Message-ID | <shoP0-5xq-35@gated-at.bofh.it> |
| In reply to | #1483433 |
On Wed, Sep 14, 2016 at 08:33:58AM -0700, Laura Abbott wrote: > The Ion platform code uses of_platform_device_create which has > dependencies on OF_ADDRESS. Depending on OF is not sufficient > > Building sparc64:allmodconfig ... failed > -------------- > Error log: > ... > drivers/built-in.o: In function `ion_parse_dt': > (.text+0x11aa2c): undefined reference to `of_platform_device_create' > > Add a dependency on OF_ADDRESS > > Reported-by: Guenter Roeck <linux@roeck-us.net> > Signed-off-by: Laura Abbott <labbott@redhat.com> Tested-by: Guenter Roeck <linux@roeck-us.net> > --- > Based on next-20160914 > --- > drivers/staging/android/ion/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/android/ion/Kconfig b/drivers/staging/android/ion/Kconfig > index 8a54ddc..9410554 100644 > --- a/drivers/staging/android/ion/Kconfig > +++ b/drivers/staging/android/ion/Kconfig > @@ -43,7 +43,7 @@ source "drivers/staging/android/ion/hisilicon/Kconfig" > > config ION_OF > bool "Devicetree support for Ion" > - depends on ION && OF > + depends on ION && OF_ADDRESS > help > Provides base support for defining Ion heaps in devicetree > and setting them up. Also includes functions for platforms > -- > 2.7.4 >
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web