Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1481249 > unrolled thread

[PATCH] USB: wusbcore: add in missing white space in error message text

Started byColin King <colin.king@canonical.com>
First post2016-09-12 15:10 +0200
Last post2016-09-12 15:20 +0200
Articles 2 — 2 participants

Back to article view | Back to linux.kernel


Contents

  [PATCH] USB: wusbcore: add in missing white space in error message text Colin King <colin.king@canonical.com> - 2016-09-12 15:10 +0200
    Re: [PATCH] USB: wusbcore: add in missing white space in error  message text Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2016-09-12 15:20 +0200

#1481249 — [PATCH] USB: wusbcore: add in missing white space in error message text

FromColin King <colin.king@canonical.com>
Date2016-09-12 15:10 +0200
Subject[PATCH] USB: wusbcore: add in missing white space in error message text
Message-ID<sgz9M-3JB-39@gated-at.bofh.it>
From: Colin Ian King <colin.king@canonical.com>

A dev_err message spans two lines and the literal string is missing
a white space between words. Add the white space.

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 drivers/usb/wusbcore/cbaf.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/usb/wusbcore/cbaf.c b/drivers/usb/wusbcore/cbaf.c
index da1b872..62ade9f 100644
--- a/drivers/usb/wusbcore/cbaf.c
+++ b/drivers/usb/wusbcore/cbaf.c
@@ -610,7 +610,7 @@ static int cbaf_probe(struct usb_interface *iface,
 	cbaf->usb_iface = usb_get_intf(iface);
 	result = cbaf_check(cbaf);
 	if (result < 0) {
-		dev_err(dev, "This device is not WUSB-CBAF compliant"
+		dev_err(dev, "This device is not WUSB-CBAF compliant "
 			"and is not supported yet.\n");
 		goto error_check;
 	}
-- 
2.9.3

[toc] | [next] | [standalone]


#1481267 — Re: [PATCH] USB: wusbcore: add in missing white space in error message text

FromSergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Date2016-09-12 15:20 +0200
SubjectRe: [PATCH] USB: wusbcore: add in missing white space in error message text
Message-ID<sgzjr-3N9-3@gated-at.bofh.it>
In reply to#1481249
On 9/12/2016 4:01 PM, Colin King wrote:

> From: Colin Ian King <colin.king@canonical.com>
>
> A dev_err message spans two lines and the literal string is missing
> a white space between words. Add the white space.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>  drivers/usb/wusbcore/cbaf.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/wusbcore/cbaf.c b/drivers/usb/wusbcore/cbaf.c
> index da1b872..62ade9f 100644
> --- a/drivers/usb/wusbcore/cbaf.c
> +++ b/drivers/usb/wusbcore/cbaf.c
> @@ -610,7 +610,7 @@ static int cbaf_probe(struct usb_interface *iface,
>  	cbaf->usb_iface = usb_get_intf(iface);
>  	result = cbaf_check(cbaf);
>  	if (result < 0) {
> -		dev_err(dev, "This device is not WUSB-CBAF compliant"
> +		dev_err(dev, "This device is not WUSB-CBAF compliant "
>  			"and is not supported yet.\n");

    The messages just shouldn't be broken up in order to facilitate grep'ping.

[...]

MBR, Sergei

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web