Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1481085 > unrolled thread
| Started by | Colin King <colin.king@canonical.com> |
|---|---|
| First post | 2016-09-12 11:40 +0200 |
| Last post | 2016-09-12 14:00 +0200 |
| Articles | 3 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH] atm: iphase: fix newline escape and minor tweak to source formatting Colin King <colin.king@canonical.com> - 2016-09-12 11:40 +0200
Re: [PATCH] atm: iphase: fix newline escape and minor tweak to source formatting Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2016-09-12 14:00 +0200
Re: [PATCH] atm: iphase: fix newline escape and minor tweak to source formatting Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2016-09-12 14:00 +0200
| From | Colin King <colin.king@canonical.com> |
|---|---|
| Date | 2016-09-12 11:40 +0200 |
| Subject | [PATCH] atm: iphase: fix newline escape and minor tweak to source formatting |
| Message-ID | <sgvSy-1oS-31@gated-at.bofh.it> |
From: Colin Ian King <colin.king@canonical.com>
The newline escape is incorrect and needs fixing. Also adjust source
formatting / indentation and remove trailing white space.
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/atm/iphase.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/atm/iphase.c b/drivers/atm/iphase.c
index 9d8807e..256b191 100644
--- a/drivers/atm/iphase.c
+++ b/drivers/atm/iphase.c
@@ -1885,9 +1885,8 @@ static int open_tx(struct atm_vcc *vcc)
if ((ret = ia_cbr_setup (iadev, vcc)) < 0) {
return ret;
}
- }
- else
- printk("iadev: Non UBR, ABR and CBR traffic not supportedn");
+ } else
+ printk("iadev: Non UBR, ABR and CBR traffic not supported\n");
iadev->testTable[vcc->vci]->vc_status |= VC_ACTIVE;
IF_EVENT(printk("ia open_tx returning \n");)
--
2.9.3
[toc] | [next] | [standalone]
| From | Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> |
|---|---|
| Date | 2016-09-12 14:00 +0200 |
| Subject | Re: [PATCH] atm: iphase: fix newline escape and minor tweak to source formatting |
| Message-ID | <sgy42-2Jz-13@gated-at.bofh.it> |
| In reply to | #1481085 |
Hello.
On 9/12/2016 12:29 PM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The newline escape is incorrect and needs fixing. Also adjust source
> formatting / indentation and remove trailing white space.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/atm/iphase.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/atm/iphase.c b/drivers/atm/iphase.c
> index 9d8807e..256b191 100644
> --- a/drivers/atm/iphase.c
> +++ b/drivers/atm/iphase.c
> @@ -1885,9 +1885,8 @@ static int open_tx(struct atm_vcc *vcc)
> if ((ret = ia_cbr_setup (iadev, vcc)) < 0) {
> return ret;
> }
> - }
> - else
> - printk("iadev: Non UBR, ABR and CBR traffic not supportedn");
> + } else
> + printk("iadev: Non UBR, ABR and CBR traffic not supported\n");
All branches of the *if* statement should have {} if at least one has
them, perhaps a material for a follow-up patch).
[...]
MBR, Sergei
[toc] | [prev] | [next] | [standalone]
| From | Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> |
|---|---|
| Date | 2016-09-12 14:00 +0200 |
| Subject | Re: [PATCH] atm: iphase: fix newline escape and minor tweak to source formatting |
| Message-ID | <sgy43-2Jz-53@gated-at.bofh.it> |
| In reply to | #1481085 |
Hello.
On 9/12/2016 12:29 PM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The newline escape is incorrect and needs fixing. Also adjust source
> formatting / indentation and remove trailing white space.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/atm/iphase.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/atm/iphase.c b/drivers/atm/iphase.c
> index 9d8807e..256b191 100644
> --- a/drivers/atm/iphase.c
> +++ b/drivers/atm/iphase.c
> @@ -1885,9 +1885,8 @@ static int open_tx(struct atm_vcc *vcc)
> if ((ret = ia_cbr_setup (iadev, vcc)) < 0) {
> return ret;
> }
> - }
> - else
> - printk("iadev: Non UBR, ABR and CBR traffic not supportedn");
> + } else
> + printk("iadev: Non UBR, ABR and CBR traffic not supported\n");
All branches of the *if* statement should have {} if at least one has them
(perhaps a material for a follow-up patch).
[...]
MBR, Sergei
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web