Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1481128 > unrolled thread

[PATCH] arm-cci: add cci_enable_port_for_self() declaration in arm-cci.h

Back to article view | Back to linux.kernel

Contents

  [PATCH] arm-cci: add cci_enable_port_for_self() declaration in arm-cci.h Baoyou Xie <baoyou.xie@linaro.org> - 2016-09-12 12:40 +0200
    Re: [PATCH] arm-cci: add cci_enable_port_for_self() declaration in  arm-cci.h Suzuki K Poulose <Suzuki.Poulose@arm.com> - 2016-09-12 12:40 +0200

#1481128 — [PATCH] arm-cci: add cci_enable_port_for_self() declaration in arm-cci.h

We get 1 warning when building kernel with W=1:
drivers/bus/arm-cci.c:2027:25: warning: no previous prototype for 'cci_enable_port_for_self' [-Wmissing-prototypes]

In fact, this function is used in a few files,
but should be declared in a header file.

So this patch adds the declaration in arm-cci.h.

Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>
---
 include/linux/arm-cci.h | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/include/linux/arm-cci.h b/include/linux/arm-cci.h
index 521ec1f..b88f6fb 100644
--- a/include/linux/arm-cci.h
+++ b/include/linux/arm-cci.h
@@ -30,8 +30,10 @@ struct device_node;
 
 #ifdef CONFIG_ARM_CCI
 extern bool cci_probed(void);
+extern asmlinkage void __naked cci_enable_port_for_self(void);
 #else
 static inline bool cci_probed(void) { return false; }
+static inline void ci_enable_port_for_self(void) { return; }
 #endif
 
 #ifdef CONFIG_ARM_CCI400_PORT_CTRL
-- 
2.7.4

[toc] | [next] | [standalone]

#1481129 — Re: [PATCH] arm-cci: add cci_enable_port_for_self() declaration in arm-cci.h

On 12/09/16 11:33, Baoyou Xie wrote:
> We get 1 warning when building kernel with W=1:
> drivers/bus/arm-cci.c:2027:25: warning: no previous prototype for 'cci_enable_port_for_self' [-Wmissing-prototypes]
>
> In fact, this function is used in a few files,
> but should be declared in a header file.
>
> So this patch adds the declaration in arm-cci.h.
>
> Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>
> ---
>  include/linux/arm-cci.h | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/include/linux/arm-cci.h b/include/linux/arm-cci.h
> index 521ec1f..b88f6fb 100644
> --- a/include/linux/arm-cci.h
> +++ b/include/linux/arm-cci.h
> @@ -30,8 +30,10 @@ struct device_node;
>
>  #ifdef CONFIG_ARM_CCI
>  extern bool cci_probed(void);
> +extern asmlinkage void __naked cci_enable_port_for_self(void);
>  #else
>  static inline bool cci_probed(void) { return false; }
> +static inline void ci_enable_port_for_self(void) { return; }
>  #endif
>

Don't you think the above definitions should depend on

ARM_CCI400_PORT_CTRL than ARM_CCI ?


Suzuki

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web