Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1481058 > unrolled thread

Re: [PATCH v2] gpio/gpiolib: Forbid irqchip default trigger if probed over DT

Started byLinus Walleij <linus.walleij@linaro.org>
First post2016-09-12 11:10 +0200
Last post2016-09-12 11:10 +0200
Articles 1 — 1 participant

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  Re: [PATCH v2] gpio/gpiolib: Forbid irqchip default trigger if probed  over DT Linus Walleij <linus.walleij@linaro.org> - 2016-09-12 11:10 +0200

#1481058 — Re: [PATCH v2] gpio/gpiolib: Forbid irqchip default trigger if probed over DT

FromLinus Walleij <linus.walleij@linaro.org>
Date2016-09-12 11:10 +0200
SubjectRe: [PATCH v2] gpio/gpiolib: Forbid irqchip default trigger if probed over DT
Message-ID<sgvpv-1eW-3@gated-at.bofh.it>
On Thu, Sep 8, 2016 at 7:13 PM, Marc Zyngier <marc.zyngier@arm.com> wrote:
> On 07/09/16 23:18, Linus Walleij wrote:
>> On Wed, Sep 7, 2016 at 10:12 AM, Marc Zyngier <marc.zyngier@arm.com> wrote:
>>
>>> Using a default trigger is a bad idea if using DT to configure
>>> interrupts, as the device's interrupt specifier will always contain
>>> the trigger configuration.
>>>
>>> Let's warn about that particular situation, and revert to not
>>> having a default. Hopefully, the couple of drivers still using
>>> this feature will quickly be fixed.
>>>
>>> Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
>>> ---
>>> Send the tested patch this time around...
>>
>> I got it the first time, don't worry :D
>
> Errrr, the first one didn't even compile (I'm such a moron sometimes).
> Please apply this one instead, which has actually been compile-tested.
>
> Sorry for the noise.

Sending premature patches is human.

Backed the buggy one out and applied this instead!

Yours,
Linus Walleij

[toc] | [standalone]


Back to top | Article view | linux.kernel


csiph-web