Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1480956 > unrolled thread

drm/i915: undefined symbol I915_SW_FENCE_CHECK_DAG

Back to article view | Back to linux.kernel

Contents

  drm/i915: undefined symbol I915_SW_FENCE_CHECK_DAG Valentin Rothberg <valentinrothberg@gmail.com> - 2016-09-12 08:50 +0200
    Re: drm/i915: undefined symbol I915_SW_FENCE_CHECK_DAG Chris Wilson <chris@chris-wilson.co.uk> - 2016-09-12 09:00 +0200

#1480956 — drm/i915: undefined symbol I915_SW_FENCE_CHECK_DAG

Hi Chris,

your commit e68a139f6bf3 ("drm/i915: Add a sw fence for collecting up
dma fences") has shown up in today's linux-next (i.e., 20160912)
adding the following the lines (184++):

+       if (!IS_ENABLED(CONFIG_I915_SW_FENCE_CHECK_DAG))
+               return false;

The Kconfig symbol isn't defined anywhere, so the function will always
return false.  I could not find a patch on LKML adding the symbol.  Is
there a patch queued somewhere or is the yet unconditional return
intentional?

I found the issue by diffing the last and today's linux-next using
scripts/checkkconfigsymbols.py.

Kind regards,
 Valentin

[toc] | [next] | [standalone]

#1480959

On Mon, Sep 12, 2016 at 08:46:39AM +0200, Valentin Rothberg wrote:
> Hi Chris,
> 
> your commit e68a139f6bf3 ("drm/i915: Add a sw fence for collecting up
> dma fences") has shown up in today's linux-next (i.e., 20160912)
> adding the following the lines (184++):
> 
> +       if (!IS_ENABLED(CONFIG_I915_SW_FENCE_CHECK_DAG))
> +               return false;
> 
> The Kconfig symbol isn't defined anywhere, so the function will always
> return false.  I could not find a patch on LKML adding the symbol.  Is
> there a patch queued somewhere or is the yet unconditional return
> intentional?

The patch is queued up elsewhere. It's part of the selftests.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web