Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1480821 > unrolled thread
| Started by | Adrien Vergé <adrienverge@gmail.com> |
|---|---|
| First post | 2016-09-11 16:00 +0200 |
| Last post | 2016-09-13 11:40 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH] drm/i915: Ignore OpRegion panel type on Ivy Bridge + Mobile Adrien Vergé <adrienverge@gmail.com> - 2016-09-11 16:00 +0200
Re: [PATCH] drm/i915: Ignore OpRegion panel type on Ivy Bridge + Mobile Jani Nikula <jani.nikula@linux.intel.com> - 2016-09-13 11:40 +0200
| From | Adrien Vergé <adrienverge@gmail.com> |
|---|---|
| Date | 2016-09-11 16:00 +0200 |
| Subject | [PATCH] drm/i915: Ignore OpRegion panel type on Ivy Bridge + Mobile |
| Message-ID | <sgdsC-6QG-17@gated-at.bofh.it> |
On Terra Mobile Ultrabook 1450 II (Core i5-3337U, i915 devid = 0x166),
the screen is tiled in many 480×320 screens (like a mosaic) since v4.7.
This laptop is simply unusable.
I have bisected the cause to commit a05628195a0d ("drm/i915: Get
panel_type from OpRegion panel details").
Like for Skylake, it seems that using the OpRegion panel type (here, 0)
causes the problem, whereas the VBT panel type (here, 7) gives a normal
display. See commit aeddda06c1a7 ("drm/i915: Ignore panel type from
OpRegion on SKL") for background on this Skylake fix.
This patch ignores OpRegion panel type for Ivy Bridge + Mobile chips.
Tested-by: Adrien Vergé <adrienverge@gmail.com>
Signed-off-by: Adrien Vergé <adrienverge@gmail.com>
---
drivers/gpu/drm/i915/intel_opregion.c | 11 +++++++++++
1 file changed, 11 insertions(+)
diff --git a/drivers/gpu/drm/i915/intel_opregion.c b/drivers/gpu/drm/i915/intel_opregion.c
index adca262..94e2db7 100644
--- a/drivers/gpu/drm/i915/intel_opregion.c
+++ b/drivers/gpu/drm/i915/intel_opregion.c
@@ -1083,5 +1083,16 @@ intel_opregion_get_panel_type(struct drm_i915_private *dev_priv)
return -ENODEV;
}
+ /*
+ * FIXME On Terra Mobile Ultrabook 1450 II (Intel Core i5-3337U) the
+ * OpRegion panel type (0) results in tiled ("mosaic") display bug,
+ * whereas the VBT panel type (7) gives a normal display.
+ * Let's ignore the OpRegion panel type for this chip.
+ */
+ if (IS_IVYBRIDGE(dev_priv) && IS_MOBILE(dev_priv)) {
+ DRM_DEBUG_KMS("Ignoring OpRegion panel type (%d)\n", ret - 1);
+ return -ENODEV;
+ }
+
return ret - 1;
}
--
2.7.4
[toc] | [next] | [standalone]
| From | Jani Nikula <jani.nikula@linux.intel.com> |
|---|---|
| Date | 2016-09-13 11:40 +0200 |
| Message-ID | <sgSm5-8r1-1@gated-at.bofh.it> |
| In reply to | #1480821 |
On Sun, 11 Sep 2016, Adrien Vergé <adrienverge@gmail.com> wrote:
> On Terra Mobile Ultrabook 1450 II (Core i5-3337U, i915 devid = 0x166),
> the screen is tiled in many 480×320 screens (like a mosaic) since v4.7.
> This laptop is simply unusable.
>
> I have bisected the cause to commit a05628195a0d ("drm/i915: Get
> panel_type from OpRegion panel details").
>
> Like for Skylake, it seems that using the OpRegion panel type (here, 0)
> causes the problem, whereas the VBT panel type (here, 7) gives a normal
> display. See commit aeddda06c1a7 ("drm/i915: Ignore panel type from
> OpRegion on SKL") for background on this Skylake fix.
>
> This patch ignores OpRegion panel type for Ivy Bridge + Mobile chips.
Please try this patch [1] instead, and reply to it if it works for you.
BR,
Jani.
[1] http://patchwork.freedesktop.org/patch/msgid/1473758539-21565-1-git-send-email-ville.syrjala@linux.intel.com
>
> Tested-by: Adrien Vergé <adrienverge@gmail.com>
> Signed-off-by: Adrien Vergé <adrienverge@gmail.com>
> ---
> drivers/gpu/drm/i915/intel_opregion.c | 11 +++++++++++
> 1 file changed, 11 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/intel_opregion.c b/drivers/gpu/drm/i915/intel_opregion.c
> index adca262..94e2db7 100644
> --- a/drivers/gpu/drm/i915/intel_opregion.c
> +++ b/drivers/gpu/drm/i915/intel_opregion.c
> @@ -1083,5 +1083,16 @@ intel_opregion_get_panel_type(struct drm_i915_private *dev_priv)
> return -ENODEV;
> }
>
> + /*
> + * FIXME On Terra Mobile Ultrabook 1450 II (Intel Core i5-3337U) the
> + * OpRegion panel type (0) results in tiled ("mosaic") display bug,
> + * whereas the VBT panel type (7) gives a normal display.
> + * Let's ignore the OpRegion panel type for this chip.
> + */
> + if (IS_IVYBRIDGE(dev_priv) && IS_MOBILE(dev_priv)) {
> + DRM_DEBUG_KMS("Ignoring OpRegion panel type (%d)\n", ret - 1);
> + return -ENODEV;
> + }
> +
> return ret - 1;
> }
--
Jani Nikula, Intel Open Source Technology Center
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web