Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1480822 > unrolled thread
| Started by | Christoph Hellwig <hch@lst.de> |
|---|---|
| First post | 2016-09-11 16:00 +0200 |
| Last post | 2016-09-12 12:50 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH] kprobes: include <asm/sections.h> instead of <asm-generic/sections.h> Christoph Hellwig <hch@lst.de> - 2016-09-11 16:00 +0200
Re: [PATCH] kprobes: include <asm/sections.h> instead of <asm-generic/sections.h> Masami Hiramatsu <mhiramat@kernel.org> - 2016-09-12 12:50 +0200
| From | Christoph Hellwig <hch@lst.de> |
|---|---|
| Date | 2016-09-11 16:00 +0200 |
| Subject | [PATCH] kprobes: include <asm/sections.h> instead of <asm-generic/sections.h> |
| Message-ID | <sgdsC-6QG-15@gated-at.bofh.it> |
asm-generic headers are generic implementations for architecture specific code and should not be included by common code. Thus use the asm/ version of sections.h to get at the linker sections. Signed-off-by: Christoph Hellwig <hch@lst.de> --- kernel/kprobes.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/kprobes.c b/kernel/kprobes.c index d10ab6b..d630954 100644 --- a/kernel/kprobes.c +++ b/kernel/kprobes.c @@ -49,7 +49,7 @@ #include <linux/cpu.h> #include <linux/jump_label.h> -#include <asm-generic/sections.h> +#include <asm/sections.h> #include <asm/cacheflush.h> #include <asm/errno.h> #include <asm/uaccess.h> -- 2.1.4
[toc] | [next] | [standalone]
| From | Masami Hiramatsu <mhiramat@kernel.org> |
|---|---|
| Date | 2016-09-12 12:50 +0200 |
| Subject | Re: [PATCH] kprobes: include <asm/sections.h> instead of <asm-generic/sections.h> |
| Message-ID | <sgwYh-268-1@gated-at.bofh.it> |
| In reply to | #1480822 |
On Sun, 11 Sep 2016 15:58:22 +0200 Christoph Hellwig <hch@lst.de> wrote: > asm-generic headers are generic implementations for architecture specific > code and should not be included by common code. Thus use the asm/ version > of sections.h to get at the linker sections. > OK, I see. Acked-by: Masami Hiramatsu <mhiramat@kernel.org> Thanks! > Signed-off-by: Christoph Hellwig <hch@lst.de> > --- > kernel/kprobes.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/kernel/kprobes.c b/kernel/kprobes.c > index d10ab6b..d630954 100644 > --- a/kernel/kprobes.c > +++ b/kernel/kprobes.c > @@ -49,7 +49,7 @@ > #include <linux/cpu.h> > #include <linux/jump_label.h> > > -#include <asm-generic/sections.h> > +#include <asm/sections.h> > #include <asm/cacheflush.h> > #include <asm/errno.h> > #include <asm/uaccess.h> > -- > 2.1.4 > -- Masami Hiramatsu <mhiramat@kernel.org>
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web