Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1481947 > unrolled thread

Re: [PATCH v2 0/4] ARM: amlogic: Add spifc support to Amlogic's GXBB family

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH v2 0/4] ARM: amlogic: Add spifc support to Amlogic's GXBB family Kevin Hilman <khilman@baylibre.com> - 2016-09-12 22:40 +0200
    Re: [PATCH v2 0/4] ARM: amlogic: Add spifc support to Amlogic's  GXBB family jbrunet <jbrunet@baylibre.com> - 2016-09-13 10:10 +0200
      Re: [PATCH v2 0/4] ARM: amlogic: Add spifc support to Amlogic's GXBB family Kevin Hilman <khilman@baylibre.com> - 2016-09-13 16:30 +0200

#1481947 — Re: [PATCH v2 0/4] ARM: amlogic: Add spifc support to Amlogic's GXBB family

Jerome Brunet <jbrunet@baylibre.com> writes:

> This patch series adds the necessary pins, clocks and device tree nodes to
> enable the spifc controller on the GXBB family. I had to add the nand pins
> in pintctrl as the pinmux setting left by u-boot was conflicting with the
> spifc pinmux during my test on the P200.

This series seems to be missing a patch which enables the SPIfc on the
P200 board for use with the on-board NOR flash.

Kevin

> Changes since v1 at : http://lkml.kernel.org/r/1473261223-15412-1-git-send-email-jbrunet@baylibre.com
>  * Omit patches :
>   - dt-bindings: spi-meson: Add GXBB Compatible string
>   - spi: meson: Add GXBB compatible
>   Sent as dedicated series
>  * Omit patch:
>   - clk: gxbb: expose spifc clock
>   Already applied
>  * Rename SPI flash controller pins from spifc_* to nor_* to keep the
>    name aligned with the datasheet
>
> Jerome Brunet (3):
>   pinctrl: amlogic: gxbb: add spi nor pins
>   pinctrl: amlogic: gxbb: add nand pins
>   ARM64: dts: amlogic: add spi nor pins
>
> Neil Armstrong (1):
>   ARM64: dts: meson-gxbb: Add SPIFC node
>
>  arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi | 19 +++++++++++++++
>  drivers/pinctrl/meson/pinctrl-meson-gxbb.c  | 37 +++++++++++++++++++++++++++++
>  2 files changed, 56 insertions(+)

[toc] | [next] | [standalone]

#1482232 — Re: [PATCH v2 0/4] ARM: amlogic: Add spifc support to Amlogic's GXBB family

On Mon, 2016-09-12 at 13:38 -0700, Kevin Hilman wrote:
> Jerome Brunet <jbrunet@baylibre.com> writes:
> 
> > 
> > This patch series adds the necessary pins, clocks and device tree
> > nodes to
> > enable the spifc controller on the GXBB family. I had to add the
> > nand pins
> > in pintctrl as the pinmux setting left by u-boot was conflicting
> > with the
> > spifc pinmux during my test on the P200.
> 
> This series seems to be missing a patch which enables the SPIfc on
> the
> P200 board for use with the on-board NOR flash.
> 
> Kevin
> 

Indeed, I did not provide this patch, on purpose.
The SPI-NOR at 4U2 on the P200 schematics was not present on the board
I have. I assumed this was the case for all other P200 as well.

In addition, to enable the SPI-NOR, you would also need to solder
something at 4R3 (SPI_CS signal disconnected by default)

Finally, all the SPIfc lines are shared with the NAND controller which,
like the SPI-NOR, appears on the schematics (4CCN1) but is not soldered
on the actual hardware.

Of course, I can share such patch for testing purposes if you would
like me to.

Jerome.

> > 
> > Changes since v1 at : http://lkml.kernel.org/r/1473261223-15412-1-g
> > it-send-email-jbrunet@baylibre.com
> >  * Omit patches :
> >   - dt-bindings: spi-meson: Add GXBB Compatible string
> >   - spi: meson: Add GXBB compatible
> >   Sent as dedicated series
> >  * Omit patch:
> >   - clk: gxbb: expose spifc clock
> >   Already applied
> >  * Rename SPI flash controller pins from spifc_* to nor_* to keep
> > the
> >    name aligned with the datasheet
> > 
> > Jerome Brunet (3):
> >   pinctrl: amlogic: gxbb: add spi nor pins
> >   pinctrl: amlogic: gxbb: add nand pins
> >   ARM64: dts: amlogic: add spi nor pins
> > 
> > Neil Armstrong (1):
> >   ARM64: dts: meson-gxbb: Add SPIFC node
> > 
> >  arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi | 19 +++++++++++++++
> >  drivers/pinctrl/meson/pinctrl-meson-gxbb.c  | 37
> > +++++++++++++++++++++++++++++
> >  2 files changed, 56 insertions(+)

[toc] | [prev] | [next] | [standalone]

#1482533

jbrunet <jbrunet@baylibre.com> writes:

> On Mon, 2016-09-12 at 13:38 -0700, Kevin Hilman wrote:
>> Jerome Brunet <jbrunet@baylibre.com> writes:
>> 
>> > 
>> > This patch series adds the necessary pins, clocks and device tree
>> > nodes to
>> > enable the spifc controller on the GXBB family. I had to add the
>> > nand pins
>> > in pintctrl as the pinmux setting left by u-boot was conflicting
>> > with the
>> > spifc pinmux during my test on the P200.
>> 
>> This series seems to be missing a patch which enables the SPIfc on
>> the
>> P200 board for use with the on-board NOR flash.
>> 
>
> Indeed, I did not provide this patch, on purpose.
> The SPI-NOR at 4U2 on the P200 schematics was not present on the board
> I have. I assumed this was the case for all other P200 as well.
>
> In addition, to enable the SPI-NOR, you would also need to solder
> something at 4R3 (SPI_CS signal disconnected by default)

OK, that makes seense.  I thought the NOR was on the board by default.

> Finally, all the SPIfc lines are shared with the NAND controller which,
> like the SPI-NOR, appears on the schematics (4CCN1) but is not soldered
> on the actual hardware.
>
> Of course, I can share such patch for testing purposes if you would
> like me to.

Yeah, having a testing patch in the list archives would be useful.

Thanks,

Kevin

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web