Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1482138 > unrolled thread
| Started by | Stephen Rothwell <sfr@canb.auug.org.au> |
|---|---|
| First post | 2016-09-13 06:20 +0200 |
| Last post | 2016-09-15 16:00 +0200 |
| Articles | 3 — 3 participants |
Back to article view | Back to linux.kernel
linux-next: build warning after merge of the scsi tree Stephen Rothwell <sfr@canb.auug.org.au> - 2016-09-13 06:20 +0200
Re: linux-next: build warning after merge of the scsi tree "Bryant G. Ly" <bryantly@linux.vnet.ibm.com> - 2016-09-13 16:20 +0200
Re: linux-next: build warning after merge of the scsi tree "Martin K. Petersen" <martin.petersen@oracle.com> - 2016-09-15 16:00 +0200
| From | Stephen Rothwell <sfr@canb.auug.org.au> |
|---|---|
| Date | 2016-09-13 06:20 +0200 |
| Subject | linux-next: build warning after merge of the scsi tree |
| Message-ID | <sgNmp-4WR-1@gated-at.bofh.it> |
Hi James,
After merging the scsi tree, today's linux-next build (powerpc
allyesconfig) produced this warning:
drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c: In function 'ibmvscsis_rdma':
drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c:3190:20: warning: unused variable 'srp' [-Wunused-variable]
struct srp_cmd *srp = (struct srp_cmd *)iue->sbuf->buf;
^
Introduced by commit
812902159d41 ("scsi: ibmvscsis: Code cleanup of print statements")
--
Cheers,
Stephen Rothwell
[toc] | [next] | [standalone]
| From | "Bryant G. Ly" <bryantly@linux.vnet.ibm.com> |
|---|---|
| Date | 2016-09-13 16:20 +0200 |
| Message-ID | <sgWJ3-31X-15@gated-at.bofh.it> |
| In reply to | #1482138 |
On 9/12/16, 11:15 PM, "Stephen Rothwell" <sfr@canb.auug.org.au> wrote:
> Hi James,
>
> After merging the scsi tree, today's linux-next build (powerpc
> allyesconfig) produced this warning:
>
> drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c: In function 'ibmvscsis_rdma':
> drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c:3190:20: warning: unused variable 'srp' [-Wunused-variable]
> struct srp_cmd *srp = (struct srp_cmd *)iue->sbuf->buf;
> ^
>
> Introduced by commit
>
> 812902159d41 ("scsi: ibmvscsis: Code cleanup of print statements")
Looks like cleaning up the print statement made this variable unused so deleting that line would be best.
-Bryant
[toc] | [prev] | [next] | [standalone]
| From | "Martin K. Petersen" <martin.petersen@oracle.com> |
|---|---|
| Date | 2016-09-15 16:00 +0200 |
| Message-ID | <shFmP-7Jn-43@gated-at.bofh.it> |
| In reply to | #1482524 |
>>>>> "Bryant" == Bryant G Ly <bryantly@linux.vnet.ibm.com> writes:
Bryant> On 9/12/16, 11:15 PM, "Stephen Rothwell" <sfr@canb.auug.org.au> wrote:
>> Hi James,
>>
>> After merging the scsi tree, today's linux-next build (powerpc
>> allyesconfig) produced this warning:
>>
>> drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c: In function
>> 'ibmvscsis_rdma': drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c:3190:20:
>> warning: unused variable 'srp' [-Wunused-variable] struct srp_cmd
>> *srp = (struct srp_cmd *)iue->sbuf->buf; ^
>>
>> Introduced by commit
>>
>> 812902159d41 ("scsi: ibmvscsis: Code cleanup of print statements")
Bryant> Looks like cleaning up the print statement made this variable
Bryant> unused so deleting that line would be best.
Please submit a patch to do so.
--
Martin K. Petersen Oracle Linux Engineering
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web