Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1482044 > unrolled thread

Re: [PATCH v7] gpio: add Intel WhiskeyCove PMIC GPIO driver

Started byPaul Gortmaker <paul.gortmaker@windriver.com>
First post2016-09-13 00:40 +0200
Last post2016-09-13 17:50 +0200
Articles 6 — 3 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH v7] gpio: add Intel WhiskeyCove PMIC GPIO driver Paul Gortmaker <paul.gortmaker@windriver.com> - 2016-09-13 00:40 +0200
    Re: [PATCH v7] gpio: add Intel WhiskeyCove PMIC GPIO driver Andy Shevchenko <andy.shevchenko@gmail.com> - 2016-09-13 09:10 +0200
      Re: [PATCH v7] gpio: add Intel WhiskeyCove PMIC GPIO driver Paul Gortmaker <paul.gortmaker@windriver.com> - 2016-09-13 15:40 +0200
        Re: [PATCH v7] gpio: add Intel WhiskeyCove PMIC GPIO driver Andy Shevchenko <andy.shevchenko@gmail.com> - 2016-09-13 16:40 +0200
          Re: [PATCH v7] gpio: add Intel WhiskeyCove PMIC GPIO driver Paul Gortmaker <paul.gortmaker@windriver.com> - 2016-09-13 16:50 +0200
            RE: [PATCH v7] gpio: add Intel WhiskeyCove PMIC GPIO driver "Gao, Bin" <bin.gao@intel.com> - 2016-09-13 17:50 +0200

#1482044 — Re: [PATCH v7] gpio: add Intel WhiskeyCove PMIC GPIO driver

FromPaul Gortmaker <paul.gortmaker@windriver.com>
Date2016-09-13 00:40 +0200
SubjectRe: [PATCH v7] gpio: add Intel WhiskeyCove PMIC GPIO driver
Message-ID<sgI3n-1jG-15@gated-at.bofh.it>
On Mon, Jul 25, 2016 at 5:59 PM, Bin Gao <bin.gao@linux.intel.com> wrote:
> This patch introduces a separate GPIO driver for Intel WhiskeyCove PMIC.
> This driver is based on gpio-crystalcove.c.
>
> Signed-off-by: Ajay Thomas <ajay.thomas.david.rajamanickam@intel.com>

This looks like an invalid address, and ....

> Signed-off-by: Bin Gao <bin.gao@intel.com>
> Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
> Reviewed-by: Mika Westerberg <mika.westerberg@linux.intel.com>
> ---

[....]

> +module_platform_driver(wcove_gpio_driver);
> +
> +MODULE_AUTHOR("Ajay Thomas <ajay.thomas.david.rajamanickam@intel.com>");

...the same here.  In fact it sure looks like two names.  Anyway I just got a
bounce when I tried to use it...

Paul.
--

> +MODULE_AUTHOR("Bin Gao <bin.gao@intel.com>");
> +MODULE_DESCRIPTION("Intel Whiskey Cove GPIO Driver");
> +MODULE_LICENSE("GPL v2");
> +MODULE_ALIAS("platform:bxt_wcove_gpio");
> --
> 1.9.1
>

[toc] | [next] | [standalone]

#1482181

FromAndy Shevchenko <andy.shevchenko@gmail.com>
Date2016-09-13 09:10 +0200
Message-ID<sgQ0W-6Y0-3@gated-at.bofh.it>
In reply to#1482044
On Tue, Sep 13, 2016 at 1:37 AM, Paul Gortmaker
<paul.gortmaker@windriver.com> wrote:
>> Signed-off-by: Ajay Thomas <ajay.thomas.david.rajamanickam@intel.com>
>
> This looks like an invalid address, and ....

>> +MODULE_AUTHOR("Ajay Thomas <ajay.thomas.david.rajamanickam@intel.com>");
>
> ...the same here.  In fact it sure looks like two names.  Anyway I just got a
> bounce when I tried to use it...

It might be that person is no longer working for Intel, though I think
It would be better log message for that.

-- 
With Best Regards,
Andy Shevchenko

[toc] | [prev] | [next] | [standalone]

#1482482

FromPaul Gortmaker <paul.gortmaker@windriver.com>
Date2016-09-13 15:40 +0200
Message-ID<sgW6l-2yc-5@gated-at.bofh.it>
In reply to#1482181
[Re: [PATCH v7] gpio: add Intel WhiskeyCove PMIC GPIO driver] On 13/09/2016 (Tue 10:02) Andy Shevchenko wrote:

> On Tue, Sep 13, 2016 at 1:37 AM, Paul Gortmaker
> <paul.gortmaker@windriver.com> wrote:
> >> Signed-off-by: Ajay Thomas <ajay.thomas.david.rajamanickam@intel.com>
> >
> > This looks like an invalid address, and ....
> 
> >> +MODULE_AUTHOR("Ajay Thomas <ajay.thomas.david.rajamanickam@intel.com>");
> >
> > ...the same here.  In fact it sure looks like two names.  Anyway I just got a
> > bounce when I tried to use it...
> 
> It might be that person is no longer working for Intel, though I think
> It would be better log message for that.

That might make sense if the driver was old, but it hasn't even hit
mainline yet -- it is only in linux-next, so it cant be more than a few
weeks old.

P.
--

> 
> -- 
> With Best Regards,
> Andy Shevchenko

[toc] | [prev] | [next] | [standalone]

#1482544

FromAndy Shevchenko <andy.shevchenko@gmail.com>
Date2016-09-13 16:40 +0200
Message-ID<sgX2q-39g-23@gated-at.bofh.it>
In reply to#1482482
On Tue, Sep 13, 2016 at 4:37 PM, Paul Gortmaker
<paul.gortmaker@windriver.com> wrote:
>> > This looks like an invalid address, and ....
>>
>> >> +MODULE_AUTHOR("Ajay Thomas <ajay.thomas.david.rajamanickam@intel.com>");
>> >
>> > ...the same here.  In fact it sure looks like two names.  Anyway I just got a
>> > bounce when I tried to use it...
>>
>> It might be that person is no longer working for Intel, though I think
>> It would be better log message for that.
>
> That might make sense if the driver was old, but it hasn't even hit
> mainline yet -- it is only in linux-next, so it cant be more than a few
> weeks old.

It's already quite off topic, so, I would just say that it is still
valid point. Starting from some version of the series (which takes
couple of months?) Bin Gao did improvements.

-- 
With Best Regards,
Andy Shevchenko

[toc] | [prev] | [next] | [standalone]

#1482550

FromPaul Gortmaker <paul.gortmaker@windriver.com>
Date2016-09-13 16:50 +0200
Message-ID<sgXc5-3cQ-7@gated-at.bofh.it>
In reply to#1482544
[Re: [PATCH v7] gpio: add Intel WhiskeyCove PMIC GPIO driver] On 13/09/2016 (Tue 17:35) Andy Shevchenko wrote:

> On Tue, Sep 13, 2016 at 4:37 PM, Paul Gortmaker
> <paul.gortmaker@windriver.com> wrote:
> >> > This looks like an invalid address, and ....
> >>
> >> >> +MODULE_AUTHOR("Ajay Thomas <ajay.thomas.david.rajamanickam@intel.com>");
> >> >
> >> > ...the same here.  In fact it sure looks like two names.  Anyway I just got a
> >> > bounce when I tried to use it...
> >>
> >> It might be that person is no longer working for Intel, though I think
> >> It would be better log message for that.
> >
> > That might make sense if the driver was old, but it hasn't even hit
> > mainline yet -- it is only in linux-next, so it cant be more than a few
> > weeks old.
> 
> It's already quite off topic, so, I would just say that it is still
> valid point. Starting from some version of the series (which takes
> couple of months?) Bin Gao did improvements.

Not sure why you would call it off topic -- a new driver appearing in
mainline should have a valid author entry, and if it is an accidental
merge of two names into one then Bin Gao is the person who can ack that
and subsequently fix it.

P.
--

> 
> -- 
> With Best Regards,
> Andy Shevchenko

[toc] | [prev] | [next] | [standalone]

#1482602

From"Gao, Bin" <bin.gao@intel.com>
Date2016-09-13 17:50 +0200
Message-ID<sgY8a-3Ow-13@gated-at.bofh.it>
In reply to#1482550
On Fri, Sep 13, 2016 at 07:46:31AM, Paul Gortmaker wrote:
>> On Tue, Sep 13, 2016 at 4:37 PM, Paul Gortmaker 
>> <paul.gortmaker@windriver.com> wrote:
>> >> > This looks like an invalid address, and ....
>> >>
>> >> >> +MODULE_AUTHOR("Ajay Thomas 
>> >> >> +<ajay.thomas.david.rajamanickam@intel.com>");
>> >> >
>> >> > ...the same here.  In fact it sure looks like two names.  Anyway 
>> >> > I just got a bounce when I tried to use it...
>> >>
>> >> It might be that person is no longer working for Intel, though I 
>> >> think It would be better log message for that.
>> >
>> > That might make sense if the driver was old, but it hasn't even hit 
>> > mainline yet -- it is only in linux-next, so it cant be more than a 
>> > few weeks old.
>> 
>> It's already quite off topic, so, I would just say that it is still 
>> valid point. Starting from some version of the series (which takes 
>> couple of months?) Bin Gao did improvements.
>
>Not sure why you would call it off topic -- a new driver appearing in mainline should have a valid author entry, and if it is an accidental merge of two names into one then Bin Gao is the person who can ack that and subsequently fix it.
>
>P.

The original email is correct and it's not an accidental merge of two names.
The cause is Ajay quitted Intel one month back so his email address is no longer valid. 

-Bin

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web