Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1480433 > unrolled thread

Updating MAINTAINERS and Documentation/video4linux F: patterns

Started byJoe Perches <joe@perches.com>
First post2016-09-10 01:30 +0200
Last post2016-09-13 11:50 +0200
Articles 4 — 3 participants

Back to article view | Back to linux.kernel


Contents

  Updating MAINTAINERS and Documentation/video4linux F: patterns Joe Perches <joe@perches.com> - 2016-09-10 01:30 +0200
    Re: Updating MAINTAINERS and Documentation/video4linux F: patterns Jani Nikula <jani.nikula@linux.intel.com> - 2016-09-13 11:30 +0200
      Re: Updating MAINTAINERS and Documentation/video4linux F: patterns Mauro Carvalho Chehab <mchehab@s-opensource.com> - 2016-09-13 11:40 +0200
      Re: Updating MAINTAINERS and Documentation/video4linux F: patterns Joe Perches <joe@perches.com> - 2016-09-13 11:50 +0200

#1480433 — Updating MAINTAINERS and Documentation/video4linux F: patterns

FromJoe Perches <joe@perches.com>
Date2016-09-10 01:30 +0200
SubjectUpdating MAINTAINERS and Documentation/video4linux F: patterns
Message-ID<sfDp7-S6-1@gated-at.bofh.it>
Hello Mauro.

After all the moving of video4linux Documentation file locations
around and converting .txt files to .rst, can you please update
the appropriate MAINTAINERS sections and F: patterns?

Thanks.

[toc] | [next] | [standalone]


#1482292

FromJani Nikula <jani.nikula@linux.intel.com>
Date2016-09-13 11:30 +0200
Message-ID<sgScp-8ns-7@gated-at.bofh.it>
In reply to#1480433
On Sat, 10 Sep 2016, Joe Perches <joe@perches.com> wrote:
> After all the moving of video4linux Documentation file locations
> around and converting .txt files to .rst, can you please update
> the appropriate MAINTAINERS sections and F: patterns?

Hmm, for patches doing rename/create/delete, checkpatch could look at
MAINTAINERS and remind the user if a MAINTAINERS update is needed.

BR,
Jani.

-- 
Jani Nikula, Intel Open Source Technology Center

[toc] | [prev] | [next] | [standalone]


#1482304

FromMauro Carvalho Chehab <mchehab@s-opensource.com>
Date2016-09-13 11:40 +0200
Message-ID<sgSm6-8r1-13@gated-at.bofh.it>
In reply to#1482292
Em Tue, 13 Sep 2016 12:22:51 +0300
Jani Nikula <jani.nikula@linux.intel.com> escreveu:

> On Sat, 10 Sep 2016, Joe Perches <joe@perches.com> wrote:
> > After all the moving of video4linux Documentation file locations
> > around and converting .txt files to .rst, can you please update
> > the appropriate MAINTAINERS sections and F: patterns?  
> 
> Hmm, for patches doing rename/create/delete, checkpatch could look at
> MAINTAINERS and remind the user if a MAINTAINERS update is needed.

Good point. Checkpatch does that already, as I remember from time to
time I receive such warnings when a new driver is created, renamed or
removed. I didn't notice it on my patchset though. 

Perhaps it excludes Documentation/ from the check logic.

Regards,
Mauro

PS.: In the specific case of media docs, I submitted a patch
yesterday addressing those renames.

[toc] | [prev] | [next] | [standalone]


#1482312

FromJoe Perches <joe@perches.com>
Date2016-09-13 11:50 +0200
Message-ID<sgSvM-8uI-31@gated-at.bofh.it>
In reply to#1482292
On Tue, 2016-09-13 at 12:22 +0300, Jani Nikula wrote:
> > On Sat, 10 Sep 2016, Joe Perches <joe@perches.com> wrote:
> After all the moving of video4linux Documentation file locations
> around and converting .txt files to .rst, can you please update
> the appropriate MAINTAINERS sections and F: patterns?
> 
> Hmm, for patches doing rename/create/delete, checkpatch could look at
> MAINTAINERS and remind the user if a MAINTAINERS update is needed.

Thanks, checkpatch already does exactly that.

$ ./scripts/checkpatch.pl -git 43efd1edc63534d3a7486a0548c8aedf8b1128d1
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#86: 
deleted file mode 100644

total: 0 errors, 1 warnings, 56 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

Commit 43efd1edc635 ("[media] get rid of Documentation/video4linux/lifeview.txt") has style problems, please review.

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.

or another way:

$ git log --stat -p  --format=email -1 -M 43efd1edc63534d3a7486a0548c8aedf8b1128d1 | ./scripts/checkpatch.pl -
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#84: 
deleted file mode 100644

total: 0 errors, 1 warnings, 56 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

Your patch has style problems, please review.
> 

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web