Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1482208 > unrolled thread

Re: [Outreachy kernel] [PATCH v2] staging: comedi: comedi_pcmcia: Removes unnecessary blank line

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [Outreachy kernel] [PATCH v2] staging: comedi: comedi_pcmcia: Removes unnecessary blank line Arnd Bergmann <arnd@arndb.de> - 2016-09-13 09:40 +0200
    Re: [Outreachy kernel] [PATCH v2] staging: comedi: comedi_pcmcia:  Removes unnecessary blank line Julia Lawall <julia.lawall@lip6.fr> - 2016-09-13 11:40 +0200
      Re: [Outreachy kernel] [PATCH v2] staging: comedi: comedi_pcmcia:  Removes unnecessary blank line Julia Lawall <julia.lawall@lip6.fr> - 2016-09-13 12:00 +0200

#1482208 — Re: [Outreachy kernel] [PATCH v2] staging: comedi: comedi_pcmcia: Removes unnecessary blank line

On Tuesday, September 13, 2016 11:51:53 AM CEST Namrata A Shettar wrote:
> --- a/drivers/staging/comedi/comedi_pcmcia.c
> +++ b/drivers/staging/comedi/comedi_pcmcia.c
> @@ -18,7 +18,6 @@
> 
>  #include <linux/module.h>
>  #include <linux/kernel.h>
> -
>  #include "comedi_pcmcia.h"
> 
>  /**
> 

I would argue that checkpatch is wrong here, it's very common to have
an empty line between the global and the local header files.

	Arnd

[toc] | [next] | [standalone]

#1482300 — Re: [Outreachy kernel] [PATCH v2] staging: comedi: comedi_pcmcia: Removes unnecessary blank line

On Tue, 13 Sep 2016, Arnd Bergmann wrote:

> On Tuesday, September 13, 2016 11:51:53 AM CEST Namrata A Shettar wrote:
> > --- a/drivers/staging/comedi/comedi_pcmcia.c
> > +++ b/drivers/staging/comedi/comedi_pcmcia.c
> > @@ -18,7 +18,6 @@
> >
> >  #include <linux/module.h>
> >  #include <linux/kernel.h>
> > -
> >  #include "comedi_pcmcia.h"
> >
> >  /**
> >
>
> I would argue that checkpatch is wrong here, it's very common to have
> an empty line between the global and the local header files.

I forwarded this to Joe Perches, and he pointed out that checkpatch
doesn't give a warning for this.  Namrata, what version of the kernel are
you using?

julia


>
> 	Arnd
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/2284008.DIPsHg5UWl%40wuerfel.
> For more options, visit https://groups.google.com/d/optout.
>

[toc] | [prev] | [next] | [standalone]

#1482330 — Re: [Outreachy kernel] [PATCH v2] staging: comedi: comedi_pcmcia: Removes unnecessary blank line

[Multipart message — attachments visible in raw view] — view raw

On Tue, 13 Sep 2016, Namrata A Shettar wrote:

> Yes I realize that this may be wrong.Thank you for your inputs!
>
>  Also,The version of the kernel I am using is : 4.8.0-rc2+

You should be using what you get by doing the following command:

git clone -b staging-testing git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git

Maybe this is what you already have?

julia

>
> Thanks,
> Namrata
>
> On Tuesday, September 13, 2016 at 3:06:06 PM UTC+5:30, Julia Lawall wrote:
>
>
>       On Tue, 13 Sep 2016, Arnd Bergmann wrote:
>
>       > On Tuesday, September 13, 2016 11:51:53 AM CEST Namrata A
>       Shettar wrote:
>       > > --- a/drivers/staging/comedi/comedi_pcmcia.c
>       > > +++ b/drivers/staging/comedi/comedi_pcmcia.c
>       > > @@ -18,7 +18,6 @@
>       > >
>       > >  #include <linux/module.h>
>       > >  #include <linux/kernel.h>
>       > > -
>       > >  #include "comedi_pcmcia.h"
>       > >
>       > >  /**
>       > >
>       >
>       > I would argue that checkpatch is wrong here, it's very common
>       to have
>       > an empty line between the global and the local header files.
>
>       I forwarded this to Joe Perches, and he pointed out that
>       checkpatch
>       doesn't give a warning for this.  Namrata, what version of the
>       kernel are
>       you using?
>
>       julia
>
>
>
> --
> You received this message because you are subscribed to the Google Groups
> "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visithttps://groups.google.com/d/msgid/outreachy-kernel/e2fdc076-900a-4a25-9e5a-
> 49d693bd3c74%40googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>
>

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web