Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1482226 > unrolled thread

[PATCH] dmaengine: omap-dma: Correct type2 descriptor's member types

Back to article view | Back to linux.kernel

Contents

  [PATCH] dmaengine: omap-dma: Correct type2 descriptor's member types Peter Ujfalusi <peter.ujfalusi@ti.com> - 2016-09-13 10:00 +0200
    Re: [PATCH] dmaengine: omap-dma: Correct type2 descriptor's member  types Vinod Koul <vinod.koul@intel.com> - 2016-09-14 15:30 +0200

#1482226 — [PATCH] dmaengine: omap-dma: Correct type2 descriptor's member types

The type of CDEI, CSEI, CDFI and CSFI is signed.
This did not caused issue so far as we only use unsigned values.

Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
---
 drivers/dma/omap-dma.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/dma/omap-dma.c b/drivers/dma/omap-dma.c
index aef52011d7c0..1b7f5f32bf74 100644
--- a/drivers/dma/omap-dma.c
+++ b/drivers/dma/omap-dma.c
@@ -71,10 +71,10 @@ struct omap_type2_desc {
 	uint32_t addr; /* src or dst */
 	uint16_t fn;
 	uint16_t cicr;
-	uint16_t cdei;
-	uint16_t csei;
-	uint32_t cdfi;
-	uint32_t csfi;
+	int16_t cdei;
+	int16_t csei;
+	int32_t cdfi;
+	int32_t csfi;
 } __packed;
 
 struct omap_sg {
-- 
2.10.0

[toc] | [next] | [standalone]

#1483288 — Re: [PATCH] dmaengine: omap-dma: Correct type2 descriptor's member types

On Tue, Sep 13, 2016 at 10:58:43AM +0300, Peter Ujfalusi wrote:
> The type of CDEI, CSEI, CDFI and CSFI is signed.
> This did not caused issue so far as we only use unsigned values.

Applied, thanks

-- 
~Vinod

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web