Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1481781 > unrolled thread

Re: [PATCH] staging: comedi: comedi_pcmcia: Fixes multiple blank lines issue

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH] staging: comedi: comedi_pcmcia: Fixes multiple blank  lines issue Ian Abbott <abbotti@mev.co.uk> - 2016-09-12 20:10 +0200
    Re: [PATCH] staging: comedi: comedi_pcmcia: Fixes multiple blank  lines issue Joe Perches <joe@perches.com> - 2016-09-12 20:20 +0200

#1481781 — Re: [PATCH] staging: comedi: comedi_pcmcia: Fixes multiple blank lines issue

On 12/09/16 18:29, Namrata A Shettar wrote:
> This patch fixes the checkpatch.pl <http://checkpatch.pl> issue:
> -Please don't use multiple blank lines
>
> Signed-off-by: Namrata A Shettar <namrataashettar@gmail.com
> <mailto:namrataashettar@gmail.com>>
> ---
>  drivers/staging/comedi/comedi_pcmcia.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/staging/comedi/comedi_pcmcia.c
> b/drivers/staging/comedi/comedi_pcmcia.c
> index d7072a5..ec8a0ad 100644
> --- a/drivers/staging/comedi/comedi_pcmcia.c
> +++ b/drivers/staging/comedi/comedi_pcmcia.c
> @@ -18,7 +18,6 @@
>
>  #include <linux/module.h>
>  #include <linux/kernel.h>
> -
>  #include "comedi_pcmcia.h"
>
>  /**

But there is only one blank line, so why the warning about multiple 
blank lines?

-- 
-=( Ian Abbott @ MEV Ltd.    E-mail: <abbotti@mev.co.uk> )=-
-=(                          Web: http://www.mev.co.uk/  )=-

[toc] | [next] | [standalone]

#1481788

On Mon, 2016-09-12 at 19:07 +0100, Ian Abbott wrote:
> On 12/09/16 18:29, Namrata A Shettar wrote:
> > This patch fixes the checkpatch.pl <http://checkpatch.pl> issue:
> -Please don't use multiple blank lines
[]
> diff --git a/drivers/staging/comedi/comedi_pcmcia.c
[]
> @@ -18,7 +18,6 @@
> 
>  #include <linux/module.h>
>  #include <linux/kernel.h>
> -
>  #include "comedi_pcmcia.h"
> 
>  /**
> 
> 
> But there is only one blank line, so why the warning about multiple 
> blank lines?

checkpatch doesn't emit a warning here.

Also the http://checkpatch.pl link is incorrect

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web