Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1481234 > unrolled thread
| Started by | Colin King <colin.king@canonical.com> |
|---|---|
| First post | 2016-09-12 15:00 +0200 |
| Last post | 2016-09-12 17:00 +0200 |
| Articles | 4 — 4 participants |
Back to article view | Back to linux.kernel
[PATCH] ARM: dma-mapping: add in missing white space in error message text Colin King <colin.king@canonical.com> - 2016-09-12 15:00 +0200
Re: [PATCH] ARM: dma-mapping: add in missing white space in error message text Robin Murphy <robin.murphy@arm.com> - 2016-09-12 15:10 +0200
Re: [PATCH] ARM: dma-mapping: add in missing white space in error message text Russell King - ARM Linux <linux@armlinux.org.uk> - 2016-09-12 16:40 +0200
Re: [PATCH] ARM: dma-mapping: add in missing white space in error message text Colin Ian King <colin.king@canonical.com> - 2016-09-12 17:00 +0200
| From | Colin King <colin.king@canonical.com> |
|---|---|
| Date | 2016-09-12 15:00 +0200 |
| Subject | [PATCH] ARM: dma-mapping: add in missing white space in error message text |
| Message-ID | <sgz06-3qM-15@gated-at.bofh.it> |
From: Colin Ian King <colin.king@canonical.com>
A dev_warn message spans two lines and the literal string is missing
a white space between words. Add the white space.
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
arch/arm/common/dmabounce.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/common/dmabounce.c b/arch/arm/common/dmabounce.c
index 3012816..f47767b 100644
--- a/arch/arm/common/dmabounce.c
+++ b/arch/arm/common/dmabounce.c
@@ -547,7 +547,7 @@ void dmabounce_unregister_dev(struct device *dev)
if (!device_info) {
dev_warn(dev,
- "Never registered with dmabounce but attempting"
+ "Never registered with dmabounce but attempting "
"to unregister!\n");
return;
}
--
2.9.3
[toc] | [next] | [standalone]
| From | Robin Murphy <robin.murphy@arm.com> |
|---|---|
| Date | 2016-09-12 15:10 +0200 |
| Subject | Re: [PATCH] ARM: dma-mapping: add in missing white space in error message text |
| Message-ID | <sgz9M-3JB-49@gated-at.bofh.it> |
| In reply to | #1481234 |
On 12/09/16 13:52, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> A dev_warn message spans two lines and the literal string is missing
> a white space between words. Add the white space.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> arch/arm/common/dmabounce.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/common/dmabounce.c b/arch/arm/common/dmabounce.c
> index 3012816..f47767b 100644
> --- a/arch/arm/common/dmabounce.c
> +++ b/arch/arm/common/dmabounce.c
> @@ -547,7 +547,7 @@ void dmabounce_unregister_dev(struct device *dev)
>
> if (!device_info) {
> dev_warn(dev,
> - "Never registered with dmabounce but attempting"
> + "Never registered with dmabounce but attempting "
> "to unregister!\n");
Per Documentation/CodingStyle, better to put the whole thing onto one
line so that, say, "git grep 'attempting to unregister'" doesn't leave
one scratching ones head in confusion.
Of course, even better would be to get rid of the whole thing and
convert ARM to use SWIOTLB, but hey, one thing at a time ;)
Robin.
> return;
> }
>
[toc] | [prev] | [next] | [standalone]
| From | Russell King - ARM Linux <linux@armlinux.org.uk> |
|---|---|
| Date | 2016-09-12 16:40 +0200 |
| Subject | Re: [PATCH] ARM: dma-mapping: add in missing white space in error message text |
| Message-ID | <sgAyS-4vI-29@gated-at.bofh.it> |
| In reply to | #1481258 |
On Mon, Sep 12, 2016 at 02:06:09PM +0100, Robin Murphy wrote:
> On 12/09/16 13:52, Colin King wrote:
> > From: Colin Ian King <colin.king@canonical.com>
> >
> > A dev_warn message spans two lines and the literal string is missing
> > a white space between words. Add the white space.
> >
> > Signed-off-by: Colin Ian King <colin.king@canonical.com>
> > ---
> > arch/arm/common/dmabounce.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/arch/arm/common/dmabounce.c b/arch/arm/common/dmabounce.c
> > index 3012816..f47767b 100644
> > --- a/arch/arm/common/dmabounce.c
> > +++ b/arch/arm/common/dmabounce.c
> > @@ -547,7 +547,7 @@ void dmabounce_unregister_dev(struct device *dev)
> >
> > if (!device_info) {
> > dev_warn(dev,
> > - "Never registered with dmabounce but attempting"
> > + "Never registered with dmabounce but attempting "
> > "to unregister!\n");
>
> Per Documentation/CodingStyle, better to put the whole thing onto one
> line so that, say, "git grep 'attempting to unregister'" doesn't leave
> one scratching ones head in confusion.
>
> Of course, even better would be to get rid of the whole thing and
> convert ARM to use SWIOTLB, but hey, one thing at a time ;)
I doubt that can happen - dmabounce does a little more than swiotlb
because it copes with DMA masks that are _not_ a number of zeros
followed by one bits. It was written to support things like SA1111
DMA, where the device has a bug in that it can't drive certain
SDRAM address bits correctly.
It also gets used for ITE8512 PCI controllers and IXP4xx platforms,
although these should probably be converted to SWIOTLB. However,
without having test systems, I'd recommend leaving them as-is.
--
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.
[toc] | [prev] | [next] | [standalone]
| From | Colin Ian King <colin.king@canonical.com> |
|---|---|
| Date | 2016-09-12 17:00 +0200 |
| Subject | Re: [PATCH] ARM: dma-mapping: add in missing white space in error message text |
| Message-ID | <sgASd-4DC-13@gated-at.bofh.it> |
| In reply to | #1481361 |
On 12/09/16 15:33, Russell King - ARM Linux wrote:
> On Mon, Sep 12, 2016 at 02:06:09PM +0100, Robin Murphy wrote:
>> On 12/09/16 13:52, Colin King wrote:
>>> From: Colin Ian King <colin.king@canonical.com>
>>>
>>> A dev_warn message spans two lines and the literal string is missing
>>> a white space between words. Add the white space.
>>>
>>> Signed-off-by: Colin Ian King <colin.king@canonical.com>
>>> ---
>>> arch/arm/common/dmabounce.c | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/arch/arm/common/dmabounce.c b/arch/arm/common/dmabounce.c
>>> index 3012816..f47767b 100644
>>> --- a/arch/arm/common/dmabounce.c
>>> +++ b/arch/arm/common/dmabounce.c
>>> @@ -547,7 +547,7 @@ void dmabounce_unregister_dev(struct device *dev)
>>>
>>> if (!device_info) {
>>> dev_warn(dev,
>>> - "Never registered with dmabounce but attempting"
>>> + "Never registered with dmabounce but attempting "
>>> "to unregister!\n");
>>
>> Per Documentation/CodingStyle, better to put the whole thing onto one
>> line so that, say, "git grep 'attempting to unregister'" doesn't leave
>> one scratching ones head in confusion.
>>
>> Of course, even better would be to get rid of the whole thing and
>> convert ARM to use SWIOTLB, but hey, one thing at a time ;)
>
> I doubt that can happen - dmabounce does a little more than swiotlb
> because it copes with DMA masks that are _not_ a number of zeros
> followed by one bits. It was written to support things like SA1111
> DMA, where the device has a bug in that it can't drive certain
> SDRAM address bits correctly.
>
> It also gets used for ITE8512 PCI controllers and IXP4xx platforms,
> although these should probably be converted to SWIOTLB. However,
> without having test systems, I'd recommend leaving them as-is.
>
OK, nevermind this patch, drop it into /dev/null
Colin
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web