Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1481321 > unrolled thread
| Started by | Javier Martinez Canillas <javier@osg.samsung.com> |
|---|---|
| First post | 2016-09-12 16:10 +0200 |
| Last post | 2016-09-12 18:50 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
[PATCH 13/15] stmmac: use IS_ENABLED() instead of checking for built-in or module Javier Martinez Canillas <javier@osg.samsung.com> - 2016-09-12 16:10 +0200
Re: [PATCH 13/15] stmmac: use IS_ENABLED() instead of checking for built-in or module Alexandre Torgue <alexandre.torgue@st.com> - 2016-09-12 18:50 +0200
| From | Javier Martinez Canillas <javier@osg.samsung.com> |
|---|---|
| Date | 2016-09-12 16:10 +0200 |
| Subject | [PATCH 13/15] stmmac: use IS_ENABLED() instead of checking for built-in or module |
| Message-ID | <sgA5Q-4ka-11@gated-at.bofh.it> |
The IS_ENABLED() macro checks if a Kconfig symbol has been enabled either built-in or as a module, use that macro instead of open coding the same. Using the macro makes the code more readable by helping abstract away some of the Kconfig built-in and module enable details. Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com> --- drivers/net/ethernet/stmicro/stmmac/common.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/stmicro/stmmac/common.h b/drivers/net/ethernet/stmicro/stmmac/common.h index 2533b91f1421..d3292c4a6eda 100644 --- a/drivers/net/ethernet/stmicro/stmmac/common.h +++ b/drivers/net/ethernet/stmicro/stmmac/common.h @@ -30,7 +30,7 @@ #include <linux/stmmac.h> #include <linux/phy.h> #include <linux/module.h> -#if defined(CONFIG_VLAN_8021Q) || defined(CONFIG_VLAN_8021Q_MODULE) +#if IS_ENABLED(CONFIG_VLAN_8021Q) #define STMMAC_VLAN_TAG_USED #include <linux/if_vlan.h> #endif -- 2.7.4
[toc] | [next] | [standalone]
| From | Alexandre Torgue <alexandre.torgue@st.com> |
|---|---|
| Date | 2016-09-12 18:50 +0200 |
| Subject | Re: [PATCH 13/15] stmmac: use IS_ENABLED() instead of checking for built-in or module |
| Message-ID | <sgCAF-5NW-25@gated-at.bofh.it> |
| In reply to | #1481321 |
Hi Javier, On 09/12/2016 04:03 PM, Javier Martinez Canillas wrote: > The IS_ENABLED() macro checks if a Kconfig symbol has been enabled either > built-in or as a module, use that macro instead of open coding the same. > > Using the macro makes the code more readable by helping abstract away some > of the Kconfig built-in and module enable details. > > Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com> > --- > > drivers/net/ethernet/stmicro/stmmac/common.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/stmicro/stmmac/common.h b/drivers/net/ethernet/stmicro/stmmac/common.h > index 2533b91f1421..d3292c4a6eda 100644 > --- a/drivers/net/ethernet/stmicro/stmmac/common.h > +++ b/drivers/net/ethernet/stmicro/stmmac/common.h > @@ -30,7 +30,7 @@ > #include <linux/stmmac.h> > #include <linux/phy.h> > #include <linux/module.h> > -#if defined(CONFIG_VLAN_8021Q) || defined(CONFIG_VLAN_8021Q_MODULE) > +#if IS_ENABLED(CONFIG_VLAN_8021Q) > #define STMMAC_VLAN_TAG_USED > #include <linux/if_vlan.h> > #endif > Reviewed-by: Alexandre TORGUE <alexandre.torgue@st.com> Thanks, Alex
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web