Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1479955 > unrolled thread

[PATCH v3 0/9] net-next: ethernet: add sun8i-emac driver

Started byCorentin Labbe <clabbe.montjoie@gmail.com>
First post2016-09-09 14:50 +0200
Last post2016-09-10 06:00 +0200
Articles 7 on this page of 27 — 6 participants

Back to article view | Back to linux.kernel

Contents

  [PATCH v3 0/9] net-next: ethernet: add sun8i-emac driver Corentin Labbe <clabbe.montjoie@gmail.com> - 2016-09-09 14:50 +0200
    [PATCH v3 5/9] ARM: dts: sun8i-h3: add sun8i-emac ethernet driver Corentin Labbe <clabbe.montjoie@gmail.com> - 2016-09-09 14:50 +0200
      Re: [PATCH v3 5/9] ARM: dts: sun8i-h3: add sun8i-emac ethernet driver Maxime Ripard <maxime.ripard@free-electrons.com> - 2016-09-12 09:30 +0200
        Re: [PATCH v3 5/9] ARM: dts: sun8i-h3: add sun8i-emac ethernet driver LABBE Corentin <clabbe.montjoie@gmail.com> - 2016-09-14 11:00 +0200
    [PATCH v3 4/9] ARM: dts: sun8i-h3: Add dt node for the syscon control module Corentin Labbe <clabbe.montjoie@gmail.com> - 2016-09-09 14:50 +0200
      Re: [PATCH v3 4/9] ARM: dts: sun8i-h3: Add dt node for the syscon  control module Maxime Ripard <maxime.ripard@free-electrons.com> - 2016-09-12 09:30 +0200
        Re: [PATCH v3 4/9] ARM: dts: sun8i-h3: Add dt node for the syscon  control module LABBE Corentin <clabbe.montjoie@gmail.com> - 2016-09-13 15:40 +0200
    [PATCH v3 6/9] ARM: dts: sun8i: Enable sun8i-emac on the Orange PI PC Corentin Labbe <clabbe.montjoie@gmail.com> - 2016-09-09 14:50 +0200
    [PATCH v3 2/9] MAINTAINERS: Add myself as maintainer of sun8i-emac Corentin Labbe <clabbe.montjoie@gmail.com> - 2016-09-09 14:50 +0200
    [RFC PATCH 9/9] ethernet: sun8i-emac: add pm_runtime support Corentin Labbe <clabbe.montjoie@gmail.com> - 2016-09-09 14:50 +0200
      Re: [RFC PATCH 9/9] ethernet: sun8i-emac: add pm_runtime support Maxime Ripard <maxime.ripard@free-electrons.com> - 2016-09-12 22:50 +0200
        Re: [RFC PATCH 9/9] ethernet: sun8i-emac: add pm_runtime support LABBE Corentin <clabbe.montjoie@gmail.com> - 2016-09-14 16:10 +0200
          Re: [RFC PATCH 9/9] ethernet: sun8i-emac: add pm_runtime support Maxime Ripard <maxime.ripard@free-electrons.com> - 2016-09-17 15:50 +0200
          Re: [RFC PATCH 9/9] ethernet: sun8i-emac: add pm_runtime support Florian Fainelli <f.fainelli@gmail.com> - 2016-09-17 19:00 +0200
    [PATCH v3 8/9] ARM: sunxi: Enable sun8i-emac driver on sunxi_defconfig Corentin Labbe <clabbe.montjoie@gmail.com> - 2016-09-09 14:50 +0200
      Re: [PATCH v3 8/9] ARM: sunxi: Enable sun8i-emac driver on  sunxi_defconfig Maxime Ripard <maxime.ripard@free-electrons.com> - 2016-09-12 09:40 +0200
        Re: [PATCH v3 8/9] ARM: sunxi: Enable sun8i-emac driver on  sunxi_defconfig LABBE Corentin <clabbe.montjoie@gmail.com> - 2016-09-13 15:50 +0200
    [PATCH v3 3/9] ARM: sun8i: dt: Add DT bindings documentation for Allwinner sun8i-emac Corentin Labbe <clabbe.montjoie@gmail.com> - 2016-09-09 14:50 +0200
      Re: [PATCH v3 3/9] ARM: sun8i: dt: Add DT bindings documentation for  Allwinner sun8i-emac Andrew Lunn <andrew@lunn.ch> - 2016-09-09 16:10 +0200
        Re: [PATCH v3 3/9] ARM: sun8i: dt: Add DT bindings documentation for  Allwinner sun8i-emac LABBE Corentin <clabbe.montjoie@gmail.com> - 2016-09-12 17:10 +0200
          Re: [PATCH v3 3/9] ARM: sun8i: dt: Add DT bindings documentation for  Allwinner sun8i-emac Andrew Lunn <andrew@lunn.ch> - 2016-09-12 17:20 +0200
      Re: [PATCH v3 3/9] ARM: sun8i: dt: Add DT bindings documentation for  Allwinner sun8i-emac Andrew Lunn <andrew@lunn.ch> - 2016-09-09 16:20 +0200
        Re: [PATCH v3 3/9] ARM: sun8i: dt: Add DT bindings documentation for  Allwinner sun8i-emac LABBE Corentin <clabbe.montjoie@gmail.com> - 2016-09-13 15:40 +0200
          Re: [PATCH v3 3/9] ARM: sun8i: dt: Add DT bindings documentation for  Allwinner sun8i-emac Andrew Lunn <andrew@lunn.ch> - 2016-09-13 16:20 +0200
    Re: [PATCH v3 1/9] ethernet: add sun8i-emac driver Andrew Lunn <andrew@lunn.ch> - 2016-09-09 16:20 +0200
      Re: [PATCH v3 1/9] ethernet: add sun8i-emac driver LABBE Corentin <clabbe.montjoie@gmail.com> - 2016-09-13 15:40 +0200
    Re: [PATCH v3 0/9] net-next: ethernet: add sun8i-emac driver David Miller <davem@davemloft.net> - 2016-09-10 06:00 +0200

Page 2 of 2 — ← Prev page 1 [2]

#1481415 — Re: [PATCH v3 3/9] ARM: sun8i: dt: Add DT bindings documentation for Allwinner sun8i-emac

FromAndrew Lunn <andrew@lunn.ch>
Date2016-09-12 17:20 +0200
SubjectRe: [PATCH v3 3/9] ARM: sun8i: dt: Add DT bindings documentation for Allwinner sun8i-emac
Message-ID<sgBbA-50s-21@gated-at.bofh.it>
In reply to#1481407
> Hello
> 

> Since the MDIO bus is a part of the sun8i-emac, does I really need
> to create such a mdio node ?

It is good practice. Part of the issue is that there are no written
guidelines, so different drivers do different things. I'm trying to
push all new drivers to have an MDIO node.

> Anyway I try the following patch to solve your comments, but it
> breaks the PHY finding(Could not attach to PHY).

> --- a/drivers/net/ethernet/allwinner/sun8i-emac.c
> +++ b/drivers/net/ethernet/allwinner/sun8i-emac.c
> @@ -2122,7 +2122,7 @@ static int sun8i_emac_probe(struct platform_device *pdev)
>                 return -EINVAL;
>         }
>  
> -       priv->phy_node = of_parse_phandle(node, "phy", 0);
> +       priv->phy_node = of_parse_phandle(node, "phy-handle", 0);
>         if (!priv->phy_node) {
>                 netdev_err(ndev, "No associated PHY\n");
>                 return -ENODEV;
> 
>  
>  &crypto {
> 


I don't see a change here for of_mdiobus_register(). You need to pass
the mdio node.

    Andrew

[toc] | [prev] | [next] | [standalone]

#1480036 — Re: [PATCH v3 3/9] ARM: sun8i: dt: Add DT bindings documentation for Allwinner sun8i-emac

FromAndrew Lunn <andrew@lunn.ch>
Date2016-09-09 16:20 +0200
SubjectRe: [PATCH v3 3/9] ARM: sun8i: dt: Add DT bindings documentation for Allwinner sun8i-emac
Message-ID<sfuOR-3Q2-7@gated-at.bofh.it>
In reply to#1479969
> +Optional properties:
> +- allwinner,tx-delay: TX clock delay chain value. Range value is 0-0x07. Default is 0)
> +- allwinner,rx-delay: RX clock delay chain value. Range value is 0-0x1F. Default is 0)

What are the units? pS? nS?

     Andrew

[toc] | [prev] | [next] | [standalone]

#1482489 — Re: [PATCH v3 3/9] ARM: sun8i: dt: Add DT bindings documentation for Allwinner sun8i-emac

FromLABBE Corentin <clabbe.montjoie@gmail.com>
Date2016-09-13 15:40 +0200
SubjectRe: [PATCH v3 3/9] ARM: sun8i: dt: Add DT bindings documentation for Allwinner sun8i-emac
Message-ID<sgW6m-2yc-25@gated-at.bofh.it>
In reply to#1480036
On Fri, Sep 09, 2016 at 04:17:10PM +0200, Andrew Lunn wrote:
> > +Optional properties:
> > +- allwinner,tx-delay: TX clock delay chain value. Range value is 0-0x07. Default is 0)
> > +- allwinner,rx-delay: RX clock delay chain value. Range value is 0-0x1F. Default is 0)
> 
> What are the units? pS? nS?
> 
>      Andrew

No units, only raw number.
I will add a comment for this.

Regards

Corentin Labbe

[toc] | [prev] | [next] | [standalone]

#1482522 — Re: [PATCH v3 3/9] ARM: sun8i: dt: Add DT bindings documentation for Allwinner sun8i-emac

FromAndrew Lunn <andrew@lunn.ch>
Date2016-09-13 16:20 +0200
SubjectRe: [PATCH v3 3/9] ARM: sun8i: dt: Add DT bindings documentation for Allwinner sun8i-emac
Message-ID<sgWJ3-31X-5@gated-at.bofh.it>
In reply to#1482489
On Tue, Sep 13, 2016 at 03:34:17PM +0200, LABBE Corentin wrote:
> On Fri, Sep 09, 2016 at 04:17:10PM +0200, Andrew Lunn wrote:
> > > +Optional properties:
> > > +- allwinner,tx-delay: TX clock delay chain value. Range value is 0-0x07. Default is 0)
> > > +- allwinner,rx-delay: RX clock delay chain value. Range value is 0-0x1F. Default is 0)
> > 
> > What are the units? pS? nS?
> > 
> >      Andrew
> 
> No units, only raw number.
> I will add a comment for this.

And it is likely it will get NACKed by the device tree
maintainers. You should use real unit here.

       Andrew

[toc] | [prev] | [next] | [standalone]

#1480039 — Re: [PATCH v3 1/9] ethernet: add sun8i-emac driver

FromAndrew Lunn <andrew@lunn.ch>
Date2016-09-09 16:20 +0200
SubjectRe: [PATCH v3 1/9] ethernet: add sun8i-emac driver
Message-ID<sfuOS-3Q2-19@gated-at.bofh.it>
In reply to#1479955
Hi Corentin

> +static int sun8i_emac_mdio_register(struct net_device *ndev)
> +{
> +	struct sun8i_emac_priv *priv = netdev_priv(ndev);
> +	struct mii_bus *bus;
> +	int ret;
> +
> +	bus = mdiobus_alloc();

You can use devm_mdiobus_alloc() which will simplify your error
handling and unregister code.

	 Andrew

[toc] | [prev] | [next] | [standalone]

#1482493 — Re: [PATCH v3 1/9] ethernet: add sun8i-emac driver

FromLABBE Corentin <clabbe.montjoie@gmail.com>
Date2016-09-13 15:40 +0200
SubjectRe: [PATCH v3 1/9] ethernet: add sun8i-emac driver
Message-ID<sgW6m-2yc-39@gated-at.bofh.it>
In reply to#1480039
On Fri, Sep 09, 2016 at 04:15:27PM +0200, Andrew Lunn wrote:
> Hi Corentin
> 
> > +static int sun8i_emac_mdio_register(struct net_device *ndev)
> > +{
> > +	struct sun8i_emac_priv *priv = netdev_priv(ndev);
> > +	struct mii_bus *bus;
> > +	int ret;
> > +
> > +	bus = mdiobus_alloc();
> 
> You can use devm_mdiobus_alloc() which will simplify your error
> handling and unregister code.
> 
> 	 Andrew

Hello

Since the mdio bus is allocated on ndev/open, it need to be removed when ndev/stop is called.
So devm_mdiobus_alloc cannot be used.

Regards

Corentin Labbe

[toc] | [prev] | [next] | [standalone]

#1480490

FromDavid Miller <davem@davemloft.net>
Date2016-09-10 06:00 +0200
Message-ID<sfHCp-3nL-1@gated-at.bofh.it>
In reply to#1479955
From: Corentin Labbe <clabbe.montjoie@gmail.com>
Date: Fri,  9 Sep 2016 14:45:08 +0200

> This patch series add the driver for sun8i-emac which handle the
> Ethernet MAC present on Allwinner H3/A83T/A64 SoCs.

Please don't post a patch series with some subset of the series
marked as "RFC".  I will just simply toss the entire series when
you do this.

Thank you.

[toc] | [prev] | [standalone]

Page 2 of 2 — ← Prev page 1 [2]

Back to top | Article view | linux.kernel

csiph-web