Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1479913 > unrolled thread

Re: [PATCH] dmaengine: pl330: Acquire dmac's spinlock in pl330_tx_status

Started byVinod Koul <vinod.koul@intel.com>
First post2016-09-09 13:50 +0200
Last post2016-09-09 13:50 +0200
Articles 1 — 1 participant

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  Re: [PATCH] dmaengine: pl330: Acquire dmac's spinlock in  pl330_tx_status Vinod Koul <vinod.koul@intel.com> - 2016-09-09 13:50 +0200

#1479913 — Re: [PATCH] dmaengine: pl330: Acquire dmac's spinlock in pl330_tx_status

FromVinod Koul <vinod.koul@intel.com>
Date2016-09-09 13:50 +0200
SubjectRe: [PATCH] dmaengine: pl330: Acquire dmac's spinlock in pl330_tx_status
Message-ID<sfstH-2h0-11@gated-at.bofh.it>
On Tue, Aug 23, 2016 at 05:16:55PM +0800, Hsin-Yu Chao wrote:
> There is a racing when accessing dmac thread in pl330_tx_status that
> the pl330_update is handling active request at the same time and
> changing the status of descriptors. This could cause an invalid
> transferred count from BUSY descriptor added up to the residual number.
> Fix the bug by using the dmac's spinlock in pl330_tx_status to protect
> thread resources from changing.
> Note that the nested order of holding dmac's and dma_chan's spinlock is
> consistent with the rest of the driver: dma_chan first and then dmac,
> so it is safe from deadlock scenario.

Applied, thanks

-- 
~Vinod

[toc] | [standalone]


Back to top | Article view | linux.kernel


csiph-web