Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1477913 > unrolled thread

linux-next: build failure after merge of the btrfs-kdave tree

Started byStephen Rothwell <sfr@canb.auug.org.au>
First post2016-09-07 03:30 +0200
Last post2016-09-09 13:20 +0200
Articles 2 — 2 participants

Back to article view | Back to linux.kernel


Contents

  linux-next: build failure after merge of the btrfs-kdave tree Stephen Rothwell <sfr@canb.auug.org.au> - 2016-09-07 03:30 +0200
    Re: linux-next: build failure after merge of the btrfs-kdave tree David Sterba <dsterba@suse.cz> - 2016-09-09 13:20 +0200

#1477913 — linux-next: build failure after merge of the btrfs-kdave tree

FromStephen Rothwell <sfr@canb.auug.org.au>
Date2016-09-07 03:30 +0200
Subjectlinux-next: build failure after merge of the btrfs-kdave tree
Message-ID<sezQB-1pJ-7@gated-at.bofh.it>
Hi David,

After merging the btrfs-kdave tree, today's linux-next build (x86_64
allmodconfig) failed like this:

fs/ntfs/attrib.c: In function 'ntfs_attr_set':
fs/ntfs/attrib.c:2549:35: error: implicit declaration of function 'inode_to_bdi' [-Werror=implicit-function-declaration]
   balance_dirty_pages_ratelimited(inode_to_bdi(inode),
                                   ^
fs/ntfs/attrib.c:2549:35: warning: passing argument 1 of 'balance_dirty_pages_ratelimited' makes pointer from integer without a cast [-Wint-conversion]
In file included from include/linux/memcontrol.h:30:0,
                 from include/linux/swap.h:8,
                 from fs/ntfs/attrib.c:26:
include/linux/writeback.h:367:6: note: expected 'struct backing_dev_info *' but argument is of type 'int'
 void balance_dirty_pages_ratelimited(struct backing_dev_info *bdi,
      ^
fs/ntfs/attrib.c:2591:35: warning: passing argument 1 of 'balance_dirty_pages_ratelimited' makes pointer from integer without a cast [-Wint-conversion]
   balance_dirty_pages_ratelimited(inode_to_bdi(inode),
                                   ^
In file included from include/linux/memcontrol.h:30:0,
                 from include/linux/swap.h:8,
                 from fs/ntfs/attrib.c:26:
include/linux/writeback.h:367:6: note: expected 'struct backing_dev_info *' but argument is of type 'int'
 void balance_dirty_pages_ratelimited(struct backing_dev_info *bdi,
      ^
fs/ntfs/attrib.c:2609:35: warning: passing argument 1 of 'balance_dirty_pages_ratelimited' makes pointer from integer without a cast [-Wint-conversion]
   balance_dirty_pages_ratelimited(inode_to_bdi(inode),
                                   ^
In file included from include/linux/memcontrol.h:30:0,
                 from include/linux/swap.h:8,
                 from fs/ntfs/attrib.c:26:
include/linux/writeback.h:367:6: note: expected 'struct backing_dev_info *' but argument is of type 'int'
 void balance_dirty_pages_ratelimited(struct backing_dev_info *bdi,
      ^

Caused by commit

  a685fa61566d ("remove mapping from balance_dirty_pages*()")

I assume some forgotten include(s).

I have used the btrfs-kdave tree from next-20160906 for today.

-- 
Cheers,
Stephen Rothwell

[toc] | [next] | [standalone]


#1479889

FromDavid Sterba <dsterba@suse.cz>
Date2016-09-09 13:20 +0200
Message-ID<sfs0G-27K-43@gated-at.bofh.it>
In reply to#1477913
On Wed, Sep 07, 2016 at 11:22:53AM +1000, Stephen Rothwell wrote:
> Hi David,
> 
> After merging the btrfs-kdave tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
> 
> fs/ntfs/attrib.c: In function 'ntfs_attr_set':
> fs/ntfs/attrib.c:2549:35: error: implicit declaration of function 'inode_to_bdi' [-Werror=implicit-function-declaration]
>    balance_dirty_pages_ratelimited(inode_to_bdi(inode),
>                                    ^
> fs/ntfs/attrib.c:2549:35: warning: passing argument 1 of 'balance_dirty_pages_ratelimited' makes pointer from integer without a cast [-Wint-conversion]
> In file included from include/linux/memcontrol.h:30:0,
>                  from include/linux/swap.h:8,
>                  from fs/ntfs/attrib.c:26:
> include/linux/writeback.h:367:6: note: expected 'struct backing_dev_info *' but argument is of type 'int'
>  void balance_dirty_pages_ratelimited(struct backing_dev_info *bdi,
>       ^
> fs/ntfs/attrib.c:2591:35: warning: passing argument 1 of 'balance_dirty_pages_ratelimited' makes pointer from integer without a cast [-Wint-conversion]
>    balance_dirty_pages_ratelimited(inode_to_bdi(inode),
>                                    ^
> In file included from include/linux/memcontrol.h:30:0,
>                  from include/linux/swap.h:8,
>                  from fs/ntfs/attrib.c:26:
> include/linux/writeback.h:367:6: note: expected 'struct backing_dev_info *' but argument is of type 'int'
>  void balance_dirty_pages_ratelimited(struct backing_dev_info *bdi,
>       ^
> fs/ntfs/attrib.c:2609:35: warning: passing argument 1 of 'balance_dirty_pages_ratelimited' makes pointer from integer without a cast [-Wint-conversion]
>    balance_dirty_pages_ratelimited(inode_to_bdi(inode),
>                                    ^
> In file included from include/linux/memcontrol.h:30:0,
>                  from include/linux/swap.h:8,
>                  from fs/ntfs/attrib.c:26:
> include/linux/writeback.h:367:6: note: expected 'struct backing_dev_info *' but argument is of type 'int'
>  void balance_dirty_pages_ratelimited(struct backing_dev_info *bdi,
>       ^
> 
> Caused by commit
> 
>   a685fa61566d ("remove mapping from balance_dirty_pages*()")
> 
> I assume some forgotten include(s).

No, I picked a wrong version of the patchset. But the patchset should
not have been in for-next as it's a change to writeback (a prerequisity
for a btrfs patchset). Now removed.

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web