Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1479442 > unrolled thread

[PATCH] staging: comedi: comedi_fops: coding style fixes

Back to article view | Back to linux.kernel

Contents

  [PATCH] staging: comedi: comedi_fops: coding style fixes Matias Mucciolo <mmucciolo@suteba.org.ar> - 2016-09-08 20:40 +0200
    Re: [PATCH] staging: comedi: comedi_fops: coding style fixes Ian Abbott <abbotti@mev.co.uk> - 2016-09-09 12:30 +0200
    Re: [PATCH] staging: comedi: comedi_fops: coding style fixes Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-09-12 13:20 +0200

#1479442 — [PATCH] staging: comedi: comedi_fops: coding style fixes

- Fixed coding style in comedi_fops.c Symbolic to octal permission.

Signed-off-by: Matias Mucciolo <mmucciolo@suteba.org.ar>
---
 drivers/staging/comedi/comedi_fops.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/comedi/comedi_fops.c b/drivers/staging/comedi/comedi_fops.c
index 1999eed..bf922ea 100644
--- a/drivers/staging/comedi/comedi_fops.c
+++ b/drivers/staging/comedi/comedi_fops.c
@@ -81,20 +81,20 @@ struct comedi_file {
        (COMEDI_NUM_MINORS - COMEDI_NUM_BOARD_MINORS)
 
 static int comedi_num_legacy_minors;
-module_param(comedi_num_legacy_minors, int, S_IRUGO);
+module_param(comedi_num_legacy_minors, int, 0444);
 MODULE_PARM_DESC(comedi_num_legacy_minors,
                 "number of comedi minor devices to reserve for non-auto-configured devices (default 0)"
                );
 
 unsigned int comedi_default_buf_size_kb = CONFIG_COMEDI_DEFAULT_BUF_SIZE_KB;
-module_param(comedi_default_buf_size_kb, uint, S_IRUGO | S_IWUSR);
+module_param(comedi_default_buf_size_kb, uint, 0644);
 MODULE_PARM_DESC(comedi_default_buf_size_kb,
                 "default asynchronous buffer size in KiB (default "
                 __MODULE_STRING(CONFIG_COMEDI_DEFAULT_BUF_SIZE_KB) ")");
 
 unsigned int comedi_default_buf_maxsize_kb
        = CONFIG_COMEDI_DEFAULT_BUF_MAXSIZE_KB;
-module_param(comedi_default_buf_maxsize_kb, uint, S_IRUGO | S_IWUSR);
+module_param(comedi_default_buf_maxsize_kb, uint, 0644);
 MODULE_PARM_DESC(comedi_default_buf_maxsize_kb,
                 "default maximum size of asynchronous buffer in KiB (default "
                 __MODULE_STRING(CONFIG_COMEDI_DEFAULT_BUF_MAXSIZE_KB) ")");
-- 
2.1.4

[toc] | [next] | [standalone]

#1479859

On 08/09/16 19:27, Matias Mucciolo wrote:
>
> - Fixed coding style in comedi_fops.c Symbolic to octal permission.
>
> Signed-off-by: Matias Mucciolo <mmucciolo@suteba.org.ar>
> ---
>  drivers/staging/comedi/comedi_fops.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/comedi/comedi_fops.c b/drivers/staging/comedi/comedi_fops.c
> index 1999eed..bf922ea 100644
> --- a/drivers/staging/comedi/comedi_fops.c
> +++ b/drivers/staging/comedi/comedi_fops.c
> @@ -81,20 +81,20 @@ struct comedi_file {
>         (COMEDI_NUM_MINORS - COMEDI_NUM_BOARD_MINORS)
>
>  static int comedi_num_legacy_minors;
> -module_param(comedi_num_legacy_minors, int, S_IRUGO);
> +module_param(comedi_num_legacy_minors, int, 0444);
>  MODULE_PARM_DESC(comedi_num_legacy_minors,
>                  "number of comedi minor devices to reserve for non-auto-configured devices (default 0)"
>                 );
>
>  unsigned int comedi_default_buf_size_kb = CONFIG_COMEDI_DEFAULT_BUF_SIZE_KB;
> -module_param(comedi_default_buf_size_kb, uint, S_IRUGO | S_IWUSR);
> +module_param(comedi_default_buf_size_kb, uint, 0644);
>  MODULE_PARM_DESC(comedi_default_buf_size_kb,
>                  "default asynchronous buffer size in KiB (default "
>                  __MODULE_STRING(CONFIG_COMEDI_DEFAULT_BUF_SIZE_KB) ")");
>
>  unsigned int comedi_default_buf_maxsize_kb
>         = CONFIG_COMEDI_DEFAULT_BUF_MAXSIZE_KB;
> -module_param(comedi_default_buf_maxsize_kb, uint, S_IRUGO | S_IWUSR);
> +module_param(comedi_default_buf_maxsize_kb, uint, 0644);
>  MODULE_PARM_DESC(comedi_default_buf_maxsize_kb,
>                  "default maximum size of asynchronous buffer in KiB (default "
>                  __MODULE_STRING(CONFIG_COMEDI_DEFAULT_BUF_MAXSIZE_KB) ")");
>

Thanks.  It looks fine.  Personally, I find the octal constants more 
readable, as POSIX octal file permissions have been burned into my brain 
for >30 years now!

Reviewed-by: Ian Abbott <abbotti@mev.co.uk>

-- 
-=( Ian Abbott @ MEV Ltd.    E-mail: <abbotti@mev.co.uk> )=-
-=(                          Web: http://www.mev.co.uk/  )=-

[toc] | [prev] | [next] | [standalone]

#1481151

On Thu, Sep 08, 2016 at 03:27:49PM -0300, Matias Mucciolo wrote:
> 
> - Fixed coding style in comedi_fops.c Symbolic to octal permission.
> 
> Signed-off-by: Matias Mucciolo <mmucciolo@suteba.org.ar>
> Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
> ---
>  drivers/staging/comedi/comedi_fops.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)

Does not apply to my tree at all, can you rebase it against the
staging-next branch of staging.git and resend?

thanks,

greg k-h

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web