Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1479714 > unrolled thread
| Started by | Niklas Cassel <niklas.cassel@axis.com> |
|---|---|
| First post | 2016-09-09 09:50 +0200 |
| Last post | 2016-09-14 23:30 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH] PCI: artpec6: drop __init from artpec6_add_pcie_port Niklas Cassel <niklas.cassel@axis.com> - 2016-09-09 09:50 +0200
Re: [PATCH] PCI: artpec6: drop __init from artpec6_add_pcie_port Bjorn Helgaas <helgaas@kernel.org> - 2016-09-14 23:30 +0200
| From | Niklas Cassel <niklas.cassel@axis.com> |
|---|---|
| Date | 2016-09-09 09:50 +0200 |
| Subject | [PATCH] PCI: artpec6: drop __init from artpec6_add_pcie_port |
| Message-ID | <sfoJs-8tz-17@gated-at.bofh.it> |
From: Niklas Cassel <niklas.cassel@axis.com>
artpec6_add_pcie_port is called from artpec6_pcie_probe.
artpec6_pcie_probe does not have the __init section marker.
It is wrong to have the marker on artpec6_add_pcie_port
when the marker is not on artpec6_pcie_probe.
Signed-off-by: Niklas Cassel <niklas.cassel@axis.com>
---
drivers/pci/host/pcie-artpec6.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/pci/host/pcie-artpec6.c b/drivers/pci/host/pcie-artpec6.c
index 16ba70b7..39bf1a6 100644
--- a/drivers/pci/host/pcie-artpec6.c
+++ b/drivers/pci/host/pcie-artpec6.c
@@ -191,8 +191,8 @@ static irqreturn_t artpec6_pcie_msi_handler(int irq, void *arg)
return dw_handle_msi_irq(pp);
}
-static int __init artpec6_add_pcie_port(struct pcie_port *pp,
- struct platform_device *pdev)
+static int artpec6_add_pcie_port(struct pcie_port *pp,
+ struct platform_device *pdev)
{
int ret;
--
2.1.4
[toc] | [next] | [standalone]
| From | Bjorn Helgaas <helgaas@kernel.org> |
|---|---|
| Date | 2016-09-14 23:30 +0200 |
| Message-ID | <shpUJ-6dH-1@gated-at.bofh.it> |
| In reply to | #1479714 |
On Fri, Sep 09, 2016 at 09:45:30AM +0200, Niklas Cassel wrote:
> From: Niklas Cassel <niklas.cassel@axis.com>
>
> artpec6_add_pcie_port is called from artpec6_pcie_probe.
> artpec6_pcie_probe does not have the __init section marker.
> It is wrong to have the marker on artpec6_add_pcie_port
> when the marker is not on artpec6_pcie_probe.
>
> Signed-off-by: Niklas Cassel <niklas.cassel@axis.com>
Applied to pci/host-artpec for v4.9, thanks!
> ---
> drivers/pci/host/pcie-artpec6.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/pci/host/pcie-artpec6.c b/drivers/pci/host/pcie-artpec6.c
> index 16ba70b7..39bf1a6 100644
> --- a/drivers/pci/host/pcie-artpec6.c
> +++ b/drivers/pci/host/pcie-artpec6.c
> @@ -191,8 +191,8 @@ static irqreturn_t artpec6_pcie_msi_handler(int irq, void *arg)
> return dw_handle_msi_irq(pp);
> }
>
> -static int __init artpec6_add_pcie_port(struct pcie_port *pp,
> - struct platform_device *pdev)
> +static int artpec6_add_pcie_port(struct pcie_port *pp,
> + struct platform_device *pdev)
> {
> int ret;
>
> --
> 2.1.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-pci" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web