Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1478884 > unrolled thread
| Started by | Neil Armstrong <narmstrong@baylibre.com> |
|---|---|
| First post | 2016-09-08 10:00 +0200 |
| Last post | 2016-09-08 20:20 +0200 |
| Articles | 7 — 4 participants |
Back to article view | Back to linux.kernel
[PATCH 0/2] spi: meson: Add Amlogic GXBB compatible Neil Armstrong <narmstrong@baylibre.com> - 2016-09-08 10:00 +0200
[PATCH 1/2] dt-bindings: spi-meson: Add GXBB Compatible string Neil Armstrong <narmstrong@baylibre.com> - 2016-09-08 10:00 +0200
Re: [PATCH 0/2] spi: meson: Add Amlogic GXBB compatible Andreas Färber <afaerber@suse.de> - 2016-09-08 14:10 +0200
Re: [PATCH 0/2] spi: meson: Add Amlogic GXBB compatible Andreas Färber <afaerber@suse.de> - 2016-09-08 15:00 +0200
Re: [PATCH 0/2] spi: meson: Add Amlogic GXBB compatible Ben Dooks <ben.dooks@codethink.co.uk> - 2016-09-08 15:30 +0200
Re: [PATCH 0/2] spi: meson: Add Amlogic GXBB compatible Kevin Hilman <khilman@baylibre.com> - 2016-09-08 20:20 +0200
Re: [PATCH 0/2] spi: meson: Add Amlogic GXBB compatible Kevin Hilman <khilman@baylibre.com> - 2016-09-08 20:20 +0200
| From | Neil Armstrong <narmstrong@baylibre.com> |
|---|---|
| Date | 2016-09-08 10:00 +0200 |
| Subject | [PATCH 0/2] spi: meson: Add Amlogic GXBB compatible |
| Message-ID | <sf2pz-2Va-9@gated-at.bofh.it> |
This patchset adds a specific compatible string in the Meson SPIFC driver for the Amlogic Meson GXBB SoC. This patchset is SPI-only respin from Jerome Brunet patchset at [1]. [1] http://lkml.kernel.org/r/1473261223-15412-1-git-send-email-jbrunet@baylibre.com Neil Armstrong (2): dt-bindings: spi-meson: Add GXBB Compatible string spi: meson: Add GXBB compatible Documentation/devicetree/bindings/spi/spi-meson.txt | 2 +- drivers/spi/spi-meson-spifc.c | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) -- 1.9.1
[toc] | [next] | [standalone]
| From | Neil Armstrong <narmstrong@baylibre.com> |
|---|---|
| Date | 2016-09-08 10:00 +0200 |
| Subject | [PATCH 1/2] dt-bindings: spi-meson: Add GXBB Compatible string |
| Message-ID | <sf2pA-2Va-19@gated-at.bofh.it> |
| In reply to | #1478884 |
Signed-off-by: Neil Armstrong <narmstrong@baylibre.com> --- Documentation/devicetree/bindings/spi/spi-meson.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/spi/spi-meson.txt b/Documentation/devicetree/bindings/spi/spi-meson.txt index bb52a86..dc6d031 100644 --- a/Documentation/devicetree/bindings/spi/spi-meson.txt +++ b/Documentation/devicetree/bindings/spi/spi-meson.txt @@ -7,7 +7,7 @@ NOR memories, without DMA support and a 64-byte unified transmit / receive buffer. Required properties: - - compatible: should be "amlogic,meson6-spifc" + - compatible: should be "amlogic,meson6-spifc" or "amlogic,meson-gxbb-spifc" - reg: physical base address and length of the controller registers - clocks: phandle of the input clock for the baud rate generator - #address-cells: should be 1 -- 1.9.1
[toc] | [prev] | [next] | [standalone]
| From | Andreas Färber <afaerber@suse.de> |
|---|---|
| Date | 2016-09-08 14:10 +0200 |
| Message-ID | <sf6jv-5D5-19@gated-at.bofh.it> |
| In reply to | #1478884 |
Am 08.09.2016 um 09:53 schrieb Neil Armstrong: > This patchset adds a specific compatible string in the Meson SPIFC driver for > the Amlogic Meson GXBB SoC. Any particular reason? We could just reuse the meson6 one since there appear to be no code changes so far. Regards, Andreas > This patchset is SPI-only respin from Jerome Brunet patchset at [1]. > > [1] http://lkml.kernel.org/r/1473261223-15412-1-git-send-email-jbrunet@baylibre.com > > Neil Armstrong (2): > dt-bindings: spi-meson: Add GXBB Compatible string > spi: meson: Add GXBB compatible > > Documentation/devicetree/bindings/spi/spi-meson.txt | 2 +- > drivers/spi/spi-meson-spifc.c | 1 + > 2 files changed, 2 insertions(+), 1 deletion(-) -- SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg)
[toc] | [prev] | [next] | [standalone]
| From | Andreas Färber <afaerber@suse.de> |
|---|---|
| Date | 2016-09-08 15:00 +0200 |
| Message-ID | <sf75T-5Vt-11@gated-at.bofh.it> |
| In reply to | #1479151 |
Am 08.09.2016 um 14:04 schrieb Andreas Färber: > Am 08.09.2016 um 09:53 schrieb Neil Armstrong: >> This patchset adds a specific compatible string in the Meson SPIFC driver for >> the Amlogic Meson GXBB SoC. > > Any particular reason? We could just reuse the meson6 one since there > appear to be no code changes so far. So Neil is essentially telling me they don't know whether there are any differences in the IP block, so a separate compatible string was chosen. No objection from my side, but a general clarification from device tree maintainers when and when not to would be appreciated. (+ devicetree) Cheers, Andreas -- SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg)
[toc] | [prev] | [next] | [standalone]
| From | Ben Dooks <ben.dooks@codethink.co.uk> |
|---|---|
| Date | 2016-09-08 15:30 +0200 |
| Message-ID | <sf7yV-6kc-13@gated-at.bofh.it> |
| In reply to | #1479186 |
On 08/09/16 13:50, Andreas Färber wrote: > Am 08.09.2016 um 14:04 schrieb Andreas Färber: >> Am 08.09.2016 um 09:53 schrieb Neil Armstrong: >>> This patchset adds a specific compatible string in the Meson SPIFC driver for >>> the Amlogic Meson GXBB SoC. >> >> Any particular reason? We could just reuse the meson6 one since there >> appear to be no code changes so far. > > So Neil is essentially telling me they don't know whether there are any > differences in the IP block, so a separate compatible string was chosen. > > No objection from my side, but a general clarification from device tree > maintainers when and when not to would be appreciated. (+ devicetree) I prefer to add both the device-tree itself, so if there are differences found later then it can be dealt with without rebuilding both the DT and kernel. It is nice to have the new ones added to the driver so that you know the hardware choices in play. -- Ben Dooks http://www.codethink.co.uk/ Senior Engineer Codethink - Providing Genius
[toc] | [prev] | [next] | [standalone]
| From | Kevin Hilman <khilman@baylibre.com> |
|---|---|
| Date | 2016-09-08 20:20 +0200 |
| Message-ID | <sfc5A-OX-17@gated-at.bofh.it> |
| In reply to | #1479186 |
Andreas Färber <afaerber@suse.de> writes: > Am 08.09.2016 um 14:04 schrieb Andreas Färber: >> Am 08.09.2016 um 09:53 schrieb Neil Armstrong: >>> This patchset adds a specific compatible string in the Meson SPIFC driver for >>> the Amlogic Meson GXBB SoC. >> >> Any particular reason? We could just reuse the meson6 one since there >> appear to be no code changes so far. > > So Neil is essentially telling me they don't know whether there are any > differences in the IP block, so a separate compatible string was chosen. > > No objection from my side, but a general clarification from device tree > maintainers when and when not to would be appreciated. (+ devicetree) I'm not sure what the "right" way is (Rob?) but I think the usual way is to add new compatibles when needed. Kevin
[toc] | [prev] | [next] | [standalone]
| From | Kevin Hilman <khilman@baylibre.com> |
|---|---|
| Date | 2016-09-08 20:20 +0200 |
| Message-ID | <sfc5A-OX-15@gated-at.bofh.it> |
| In reply to | #1478884 |
Neil Armstrong <narmstrong@baylibre.com> writes: > This patchset adds a specific compatible string in the Meson SPIFC driver for > the Amlogic Meson GXBB SoC. > > This patchset is SPI-only respin from Jerome Brunet patchset at [1]. > > [1] http://lkml.kernel.org/r/1473261223-15412-1-git-send-email-jbrunet@baylibre.com > > Neil Armstrong (2): > dt-bindings: spi-meson: Add GXBB Compatible string > spi: meson: Add GXBB compatible Acked-by: Kevin Hilman <khilman@baylibre.com> Mark, with your ack, I could take these through the amlogic tree also. Let me know. Kevin
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web